Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2845543 by vaplas, gambry, alexpott: PostgreSQL regular expression match operators works only for text

8.4.x
Alex Pott 2017-02-13 17:25:06 +00:00
parent 3404c72982
commit 3901464895
2 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
core/lib/Drupal/Core/Database/Driver/pgsql/Connection.php
View File

@ -204,14 +204,11 @@ class Connection extends DatabaseConnection {
} }
public function prepareQuery($query) { public function prepareQuery($query) {
// mapConditionOperator converts LIKE operations to ILIKE for consistency // mapConditionOperator converts some operations (LIKE, REGEXP, etc.) to
// with MySQL. However, Postgres does not support ILIKE on bytea (blobs) // PostgreSQL equivalents (ILIKE, ~*, etc.). However PostgreSQL doesn't
// fields. // automatically cast the fields to the right type for these operators,
// To make the ILIKE operator work, we type-cast bytea fields into text. // so we need to alter the query and add the type-cast.
// @todo This workaround only affects bytea fields, but the involved field return parent::prepareQuery(preg_replace('/ ([^ ]+) +(I*LIKE|NOT +I*LIKE|~\*) /i', ' ${1}::text ${2} ', $query));
// types involved in the query are unknown, so there is no way to
// conditionally execute this for affected queries only.
return parent::prepareQuery(preg_replace('/ ([^ ]+) +(I*LIKE|NOT +I*LIKE) /i', ' ${1}::text ${2} ', $query));
} }
public function queryRange($query, $from, $count, array $args = array(), array $options = array()) { public function queryRange($query, $from, $count, array $args = array(), array $options = array()) {

7
core/tests/Drupal/KernelTests/Core/Database/SelectTest.php
View File

@ -509,6 +509,13 @@ class SelectTest extends DatabaseTestBase {
$this->assertEqual(count($result), count($test_group['expected']), 'Returns the expected number of rows.'); $this->assertEqual(count($result), count($test_group['expected']), 'Returns the expected number of rows.');
$this->assertEqual(sort($result), sort($test_group['expected']), 'Returns the expected rows.'); $this->assertEqual(sort($result), sort($test_group['expected']), 'Returns the expected rows.');
} }
// Ensure that REGEXP filter still works with no-string type field.
$query = $database->select('test', 't');
$query->addField('t', 'age');
$query->condition('t.age', '2[6]', 'REGEXP');
$result = $query->execute()->fetchField();
$this->assertEquals($result, '26', 'Regexp with number type.');
} }
/** /**