From 386d79e2e02023f7ffac87fbd408619b037b1b6a Mon Sep 17 00:00:00 2001 From: Alex Pott Date: Tue, 14 Jun 2022 14:10:16 +0100 Subject: [PATCH] Issue #3283794 by mondrake, longwave: Fix 'should return {type} but return statement is missing' PHPStan L0 errors in test code --- .../Functional/Rest/BlockResourceTestBase.php | 1 + .../Rest/BlockContentTypeResourceTestBase.php | 1 + .../src/Functional/CommentNonNodeTest.php | 4 +- .../Rest/CommentResourceTestBase.php | 7 +- .../Rest/CommentTypeResourceTestBase.php | 1 + .../Rest/ConfigTestResourceTestBase.php | 1 + .../Rest/ContactFormResourceTestBase.php | 1 + .../Rest/EditorResourceTestBase.php | 1 + .../Rest/FieldConfigResourceTestBase.php | 1 + .../FieldStorageConfigResourceTestBase.php | 1 + .../Rest/FilterFormatResourceTestBase.php | 1 + .../Rest/ImageStyleResourceTestBase.php | 1 + .../tests/src/Functional/ActionTest.php | 1 + .../src/Functional/BaseFieldOverrideTest.php | 1 + .../src/Functional/BlockContentTypeTest.php | 1 + .../tests/src/Functional/BlockTest.php | 1 + .../tests/src/Functional/CommentTypeTest.php | 1 + .../tests/src/Functional/ConfigTestTest.php | 1 + .../Functional/ConfigurableLanguageTest.php | 1 + .../tests/src/Functional/ContactFormTest.php | 1 + .../ContentLanguageSettingsTest.php | 1 + .../tests/src/Functional/DateFormatTest.php | 1 + .../tests/src/Functional/EditorTest.php | 1 + .../src/Functional/EntityFormDisplayTest.php | 1 + .../src/Functional/EntityFormModeTest.php | 1 + .../src/Functional/EntityViewDisplayTest.php | 1 + .../src/Functional/EntityViewModeTest.php | 1 + .../tests/src/Functional/FieldConfigTest.php | 1 + .../src/Functional/FieldStorageConfigTest.php | 1 + .../tests/src/Functional/FileUploadTest.php | 3 + .../tests/src/Functional/FilterFormatTest.php | 1 + .../tests/src/Functional/ImageStyleTest.php | 1 + .../tests/src/Functional/MediaTypeTest.php | 1 + .../jsonapi/tests/src/Functional/MenuTest.php | 1 + .../jsonapi/tests/src/Functional/NodeTest.php | 1 + .../tests/src/Functional/NodeTypeTest.php | 1 + .../tests/src/Functional/RdfMappingTest.php | 1 + .../Functional/ResponsiveImageStyleTest.php | 1 + .../src/Functional/RestJsonApiUnsupported.php | 9 +- .../src/Functional/RestResourceConfigTest.php | 1 + .../jsonapi/tests/src/Functional/RoleTest.php | 1 + .../tests/src/Functional/SearchPageTest.php | 1 + .../tests/src/Functional/ShortcutSetTest.php | 1 + .../jsonapi/tests/src/Functional/TourTest.php | 1 + .../jsonapi/tests/src/Functional/ViewTest.php | 1 + .../tests/src/Functional/VocabularyTest.php | 1 + .../tests/src/Functional/WorkflowTest.php | 1 + .../ConfigurableLanguageResourceTestBase.php | 1 + ...ontentLanguageSettingsResourceTestBase.php | 1 + .../TestStateBasedSectionStorage.php | 43 +- .../Functional/Rest/LayoutRestTestBase.php | 5 +- .../Rest/MediaTypeResourceTestBase.php | 1 + .../migrate/tests/src/Kernel/SqlBaseTest.php | 8 +- .../migrate/tests/src/Unit/SqlBaseTest.php | 8 +- .../tests/src/Unit/TestMigrateExecutable.php | 1 + .../src/Unit/source/DrupalSqlBaseTest.php | 1 + .../src/Functional/d6/IdConflictTest.php | 4 + .../src/Functional/d6/NodeClassicTest.php | 4 + .../tests/src/Functional/d7/FilePathTest.php | 5 + .../src/Functional/d7/IdConflictTest.php | 4 + .../Rest/NodeTypeResourceTestBase.php | 1 + .../Rest/RdfMappingResourceTestBase.php | 1 + .../ResponsiveImageStyleResourceTestBase.php | 1 + .../Functional/FileUploadResourceTestBase.php | 2 + .../tests/src/Functional/ResourceTestBase.php | 2 + .../RestResourceConfigResourceTestBase.php | 1 + .../Rest/SearchPageResourceTestBase.php | 1 + .../Rest/ShortcutSetResourceTestBase.php | 1 + .../Rest/EntityTestBundleResourceTestBase.php | 1 + .../tests/src/Functional/Form/StubForm.php | 2 +- .../Rest/ActionResourceTestBase.php | 1 + .../Functional/Rest/MenuResourceTestBase.php | 1 + .../PathBasedBreadcrumbBuilderTest.php | 1 + .../Rest/VocabularyResourceTestBase.php | 1 + .../Functional/Rest/TourResourceTestBase.php | 1 + .../Functional/Rest/RoleResourceTestBase.php | 1 + .../Functional/UserRegistrationRestTest.php | 9 +- .../src/Tests/ViewResultAssertionTrait.php | 23 +- .../Functional/Rest/ViewResourceTestBase.php | 1 + .../Rest/WorkflowResourceTestBase.php | 1 + core/phpstan-baseline.neon | 720 ------------------ .../BaseFieldOverrideResourceTestBase.php | 1 + .../Rest/DateFormatResourceTestBase.php | 1 + .../EntityFormDisplayResourceTestBase.php | 1 + .../Rest/EntityFormModeResourceTestBase.php | 1 + .../EntityViewDisplayResourceTestBase.php | 1 + .../Rest/EntityViewModeResourceTestBase.php | 1 + .../Drupal/KernelTests/AssertContentTrait.php | 39 +- .../Core/Entity/EntityResolverManagerTest.php | 6 + .../Tests/Core/Entity/FieldDefinitionTest.php | 1 + .../Drupal/Tests/Core/Form/FormStateTest.php | 4 +- .../Drupal/Tests/Core/Image/ImageTest.php | 4 + .../Plugin/LazyPluginCollectionTestBase.php | 4 +- 93 files changed, 192 insertions(+), 797 deletions(-) diff --git a/core/modules/block/tests/src/Functional/Rest/BlockResourceTestBase.php b/core/modules/block/tests/src/Functional/Rest/BlockResourceTestBase.php index dd0e131391d..47ef41b446e 100644 --- a/core/modules/block/tests/src/Functional/Rest/BlockResourceTestBase.php +++ b/core/modules/block/tests/src/Functional/Rest/BlockResourceTestBase.php @@ -109,6 +109,7 @@ abstract class BlockResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/block_content/tests/src/Functional/Rest/BlockContentTypeResourceTestBase.php b/core/modules/block_content/tests/src/Functional/Rest/BlockContentTypeResourceTestBase.php index 7592a1368a6..f41577634d2 100644 --- a/core/modules/block_content/tests/src/Functional/Rest/BlockContentTypeResourceTestBase.php +++ b/core/modules/block_content/tests/src/Functional/Rest/BlockContentTypeResourceTestBase.php @@ -66,6 +66,7 @@ abstract class BlockContentTypeResourceTestBase extends ConfigEntityResourceTest */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/comment/tests/src/Functional/CommentNonNodeTest.php b/core/modules/comment/tests/src/Functional/CommentNonNodeTest.php index 106e832b45e..9820d255340 100644 --- a/core/modules/comment/tests/src/Functional/CommentNonNodeTest.php +++ b/core/modules/comment/tests/src/Functional/CommentNonNodeTest.php @@ -179,9 +179,7 @@ class CommentNonNodeTest extends BrowserTestBase { $this->assertArrayHasKey(1, $match); } - if (isset($match[1])) { - return Comment::load($match[1]); - } + return Comment::load($match[1]); } /** diff --git a/core/modules/comment/tests/src/Functional/Rest/CommentResourceTestBase.php b/core/modules/comment/tests/src/Functional/Rest/CommentResourceTestBase.php index aef51880de8..67c3bd12dd5 100644 --- a/core/modules/comment/tests/src/Functional/Rest/CommentResourceTestBase.php +++ b/core/modules/comment/tests/src/Functional/Rest/CommentResourceTestBase.php @@ -317,16 +317,17 @@ abstract class CommentResourceTestBase extends EntityResourceTestBase { */ protected function getExpectedUnauthorizedAccessMessage($method) { switch ($method) { - case 'GET'; + case 'GET': return "The 'access comments' permission is required and the comment must be published."; - case 'POST'; + case 'POST': return "The 'post comments' permission is required."; - case 'PATCH'; + case 'PATCH': return "The 'edit own comments' permission is required, the user must be the comment author, and the comment must be published."; case 'DELETE': + default: // \Drupal\comment\CommentAccessControlHandler::checkAccess() does not // specify a reason for not allowing a comment to be deleted. return ''; diff --git a/core/modules/comment/tests/src/Functional/Rest/CommentTypeResourceTestBase.php b/core/modules/comment/tests/src/Functional/Rest/CommentTypeResourceTestBase.php index b3479156d42..7862f0cec0b 100644 --- a/core/modules/comment/tests/src/Functional/Rest/CommentTypeResourceTestBase.php +++ b/core/modules/comment/tests/src/Functional/Rest/CommentTypeResourceTestBase.php @@ -72,6 +72,7 @@ abstract class CommentTypeResourceTestBase extends ConfigEntityResourceTestBase */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/config/tests/config_test/tests/src/Functional/Rest/ConfigTestResourceTestBase.php b/core/modules/config/tests/config_test/tests/src/Functional/Rest/ConfigTestResourceTestBase.php index ef9a7701a9f..8f975199338 100644 --- a/core/modules/config/tests/config_test/tests/src/Functional/Rest/ConfigTestResourceTestBase.php +++ b/core/modules/config/tests/config_test/tests/src/Functional/Rest/ConfigTestResourceTestBase.php @@ -68,6 +68,7 @@ abstract class ConfigTestResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/contact/tests/src/Functional/Rest/ContactFormResourceTestBase.php b/core/modules/contact/tests/src/Functional/Rest/ContactFormResourceTestBase.php index 43d4ec5bd15..ea30b901251 100644 --- a/core/modules/contact/tests/src/Functional/Rest/ContactFormResourceTestBase.php +++ b/core/modules/contact/tests/src/Functional/Rest/ContactFormResourceTestBase.php @@ -85,6 +85,7 @@ abstract class ContactFormResourceTestBase extends ConfigEntityResourceTestBase */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/editor/tests/src/Functional/Rest/EditorResourceTestBase.php b/core/modules/editor/tests/src/Functional/Rest/EditorResourceTestBase.php index dc40d05b461..2612c7215ff 100644 --- a/core/modules/editor/tests/src/Functional/Rest/EditorResourceTestBase.php +++ b/core/modules/editor/tests/src/Functional/Rest/EditorResourceTestBase.php @@ -122,6 +122,7 @@ abstract class EditorResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/field/tests/src/Functional/Rest/FieldConfigResourceTestBase.php b/core/modules/field/tests/src/Functional/Rest/FieldConfigResourceTestBase.php index 7728cd2c722..025b820df17 100644 --- a/core/modules/field/tests/src/Functional/Rest/FieldConfigResourceTestBase.php +++ b/core/modules/field/tests/src/Functional/Rest/FieldConfigResourceTestBase.php @@ -94,6 +94,7 @@ abstract class FieldConfigResourceTestBase extends ConfigEntityResourceTestBase */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/field/tests/src/Functional/Rest/FieldStorageConfigResourceTestBase.php b/core/modules/field/tests/src/Functional/Rest/FieldStorageConfigResourceTestBase.php index fed650e093b..c623edb5a72 100644 --- a/core/modules/field/tests/src/Functional/Rest/FieldStorageConfigResourceTestBase.php +++ b/core/modules/field/tests/src/Functional/Rest/FieldStorageConfigResourceTestBase.php @@ -73,6 +73,7 @@ abstract class FieldStorageConfigResourceTestBase extends ConfigEntityResourceTe */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/filter/tests/src/Functional/Rest/FilterFormatResourceTestBase.php b/core/modules/filter/tests/src/Functional/Rest/FilterFormatResourceTestBase.php index 611dca559e0..95db23e65ad 100644 --- a/core/modules/filter/tests/src/Functional/Rest/FilterFormatResourceTestBase.php +++ b/core/modules/filter/tests/src/Functional/Rest/FilterFormatResourceTestBase.php @@ -83,6 +83,7 @@ abstract class FilterFormatResourceTestBase extends ConfigEntityResourceTestBase */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/image/tests/src/Functional/Rest/ImageStyleResourceTestBase.php b/core/modules/image/tests/src/Functional/Rest/ImageStyleResourceTestBase.php index ec348d0a807..fdad4a2e9b6 100644 --- a/core/modules/image/tests/src/Functional/Rest/ImageStyleResourceTestBase.php +++ b/core/modules/image/tests/src/Functional/Rest/ImageStyleResourceTestBase.php @@ -99,6 +99,7 @@ abstract class ImageStyleResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/ActionTest.php b/core/modules/jsonapi/tests/src/Functional/ActionTest.php index 1495e9aaca1..ba0b527c4c1 100644 --- a/core/modules/jsonapi/tests/src/Functional/ActionTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ActionTest.php @@ -112,6 +112,7 @@ class ActionTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/BaseFieldOverrideTest.php b/core/modules/jsonapi/tests/src/Functional/BaseFieldOverrideTest.php index 756db12545e..083603090ae 100644 --- a/core/modules/jsonapi/tests/src/Functional/BaseFieldOverrideTest.php +++ b/core/modules/jsonapi/tests/src/Functional/BaseFieldOverrideTest.php @@ -123,6 +123,7 @@ class BaseFieldOverrideTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/BlockContentTypeTest.php b/core/modules/jsonapi/tests/src/Functional/BlockContentTypeTest.php index 8db3069331f..77aa86470ee 100644 --- a/core/modules/jsonapi/tests/src/Functional/BlockContentTypeTest.php +++ b/core/modules/jsonapi/tests/src/Functional/BlockContentTypeTest.php @@ -103,6 +103,7 @@ class BlockContentTypeTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/BlockTest.php b/core/modules/jsonapi/tests/src/Functional/BlockTest.php index 16c5213f3d4..41911a900c3 100644 --- a/core/modules/jsonapi/tests/src/Functional/BlockTest.php +++ b/core/modules/jsonapi/tests/src/Functional/BlockTest.php @@ -136,6 +136,7 @@ class BlockTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update once https://www.drupal.org/node/2300677 is fixed. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/CommentTypeTest.php b/core/modules/jsonapi/tests/src/Functional/CommentTypeTest.php index 1179c811225..e3654b49e9d 100644 --- a/core/modules/jsonapi/tests/src/Functional/CommentTypeTest.php +++ b/core/modules/jsonapi/tests/src/Functional/CommentTypeTest.php @@ -104,6 +104,7 @@ class CommentTypeTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/ConfigTestTest.php b/core/modules/jsonapi/tests/src/Functional/ConfigTestTest.php index c4dc049eef0..df19a11b85f 100644 --- a/core/modules/jsonapi/tests/src/Functional/ConfigTestTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ConfigTestTest.php @@ -116,6 +116,7 @@ class ConfigTestTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/ConfigurableLanguageTest.php b/core/modules/jsonapi/tests/src/Functional/ConfigurableLanguageTest.php index 97dd34593bd..ad2c2617799 100644 --- a/core/modules/jsonapi/tests/src/Functional/ConfigurableLanguageTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ConfigurableLanguageTest.php @@ -105,6 +105,7 @@ class ConfigurableLanguageTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/ContactFormTest.php b/core/modules/jsonapi/tests/src/Functional/ContactFormTest.php index 1e90a94fcb7..b91d4b7d5ac 100644 --- a/core/modules/jsonapi/tests/src/Functional/ContactFormTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ContactFormTest.php @@ -112,6 +112,7 @@ class ContactFormTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/ContentLanguageSettingsTest.php b/core/modules/jsonapi/tests/src/Functional/ContentLanguageSettingsTest.php index e80d50fc5ff..60825490762 100644 --- a/core/modules/jsonapi/tests/src/Functional/ContentLanguageSettingsTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ContentLanguageSettingsTest.php @@ -116,6 +116,7 @@ class ContentLanguageSettingsTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/DateFormatTest.php b/core/modules/jsonapi/tests/src/Functional/DateFormatTest.php index 4381a24ffc3..42e673c526b 100644 --- a/core/modules/jsonapi/tests/src/Functional/DateFormatTest.php +++ b/core/modules/jsonapi/tests/src/Functional/DateFormatTest.php @@ -108,6 +108,7 @@ class DateFormatTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/EditorTest.php b/core/modules/jsonapi/tests/src/Functional/EditorTest.php index b1c4a8afff3..8dc45e7e784 100644 --- a/core/modules/jsonapi/tests/src/Functional/EditorTest.php +++ b/core/modules/jsonapi/tests/src/Functional/EditorTest.php @@ -156,6 +156,7 @@ class EditorTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/EntityFormDisplayTest.php b/core/modules/jsonapi/tests/src/Functional/EntityFormDisplayTest.php index 2cbe0d41243..b4162427f70 100644 --- a/core/modules/jsonapi/tests/src/Functional/EntityFormDisplayTest.php +++ b/core/modules/jsonapi/tests/src/Functional/EntityFormDisplayTest.php @@ -173,6 +173,7 @@ class EntityFormDisplayTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/EntityFormModeTest.php b/core/modules/jsonapi/tests/src/Functional/EntityFormModeTest.php index 5e012df6221..91804ab3649 100644 --- a/core/modules/jsonapi/tests/src/Functional/EntityFormModeTest.php +++ b/core/modules/jsonapi/tests/src/Functional/EntityFormModeTest.php @@ -106,6 +106,7 @@ class EntityFormModeTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/EntityViewDisplayTest.php b/core/modules/jsonapi/tests/src/Functional/EntityViewDisplayTest.php index 89aade958ee..6a96388a8f1 100644 --- a/core/modules/jsonapi/tests/src/Functional/EntityViewDisplayTest.php +++ b/core/modules/jsonapi/tests/src/Functional/EntityViewDisplayTest.php @@ -127,6 +127,7 @@ class EntityViewDisplayTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/EntityViewModeTest.php b/core/modules/jsonapi/tests/src/Functional/EntityViewModeTest.php index e33fc3a9d58..27bf64d45c2 100644 --- a/core/modules/jsonapi/tests/src/Functional/EntityViewModeTest.php +++ b/core/modules/jsonapi/tests/src/Functional/EntityViewModeTest.php @@ -106,6 +106,7 @@ class EntityViewModeTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/FieldConfigTest.php b/core/modules/jsonapi/tests/src/Functional/FieldConfigTest.php index 88a78698ba0..eb81f50912d 100644 --- a/core/modules/jsonapi/tests/src/Functional/FieldConfigTest.php +++ b/core/modules/jsonapi/tests/src/Functional/FieldConfigTest.php @@ -133,6 +133,7 @@ class FieldConfigTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/FieldStorageConfigTest.php b/core/modules/jsonapi/tests/src/Functional/FieldStorageConfigTest.php index 0a788410438..d7f770803ae 100644 --- a/core/modules/jsonapi/tests/src/Functional/FieldStorageConfigTest.php +++ b/core/modules/jsonapi/tests/src/Functional/FieldStorageConfigTest.php @@ -112,6 +112,7 @@ class FieldStorageConfigTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/FileUploadTest.php b/core/modules/jsonapi/tests/src/Functional/FileUploadTest.php index 8d6908302a9..b054b694b23 100644 --- a/core/modules/jsonapi/tests/src/Functional/FileUploadTest.php +++ b/core/modules/jsonapi/tests/src/Functional/FileUploadTest.php @@ -5,6 +5,7 @@ namespace Drupal\Tests\jsonapi\Functional; use Drupal\Component\Render\PlainTextOutput; use Drupal\Component\Serialization\Json; use Drupal\Component\Utility\NestedArray; +use Drupal\Core\Cache\CacheableMetadata; use Drupal\Core\Field\FieldStorageDefinitionInterface; use Drupal\Core\Url; use Drupal\entity_test\Entity\EntityTest; @@ -775,6 +776,7 @@ class FileUploadTest extends ResourceTestBase { case 'PATCH': return "The current user is not permitted to upload a file for this field. The 'administer entity_test content' permission is required."; } + return ''; } /** @@ -927,6 +929,7 @@ class FileUploadTest extends ResourceTestBase { protected function getExpectedUnauthorizedAccessCacheability() { // There is cacheability metadata to check as file uploads only allows POST // requests, which will not return cacheable responses. + return new CacheableMetadata(); } } diff --git a/core/modules/jsonapi/tests/src/Functional/FilterFormatTest.php b/core/modules/jsonapi/tests/src/Functional/FilterFormatTest.php index 66cb157c3c7..c40e249d688 100644 --- a/core/modules/jsonapi/tests/src/Functional/FilterFormatTest.php +++ b/core/modules/jsonapi/tests/src/Functional/FilterFormatTest.php @@ -120,6 +120,7 @@ class FilterFormatTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/ImageStyleTest.php b/core/modules/jsonapi/tests/src/Functional/ImageStyleTest.php index 4180a6ef21c..1bafcf55bd7 100644 --- a/core/modules/jsonapi/tests/src/Functional/ImageStyleTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ImageStyleTest.php @@ -130,6 +130,7 @@ class ImageStyleTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/MediaTypeTest.php b/core/modules/jsonapi/tests/src/Functional/MediaTypeTest.php index 5e02fa47fda..cd26f4af3d0 100644 --- a/core/modules/jsonapi/tests/src/Functional/MediaTypeTest.php +++ b/core/modules/jsonapi/tests/src/Functional/MediaTypeTest.php @@ -110,6 +110,7 @@ class MediaTypeTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/MenuTest.php b/core/modules/jsonapi/tests/src/Functional/MenuTest.php index fb22eecee5c..c367ab61795 100644 --- a/core/modules/jsonapi/tests/src/Functional/MenuTest.php +++ b/core/modules/jsonapi/tests/src/Functional/MenuTest.php @@ -106,6 +106,7 @@ class MenuTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/NodeTest.php b/core/modules/jsonapi/tests/src/Functional/NodeTest.php index 6e3d99a7623..ec45b2d0b4e 100644 --- a/core/modules/jsonapi/tests/src/Functional/NodeTest.php +++ b/core/modules/jsonapi/tests/src/Functional/NodeTest.php @@ -265,6 +265,7 @@ class NodeTest extends ResourceTestBase { case 'DELETE': return "The 'access content' permission is required."; } + return ''; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/NodeTypeTest.php b/core/modules/jsonapi/tests/src/Functional/NodeTypeTest.php index 42890aa208e..ea93316bbd1 100644 --- a/core/modules/jsonapi/tests/src/Functional/NodeTypeTest.php +++ b/core/modules/jsonapi/tests/src/Functional/NodeTypeTest.php @@ -106,6 +106,7 @@ class NodeTypeTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/RdfMappingTest.php b/core/modules/jsonapi/tests/src/Functional/RdfMappingTest.php index f820095ff26..61e0f378ee1 100644 --- a/core/modules/jsonapi/tests/src/Functional/RdfMappingTest.php +++ b/core/modules/jsonapi/tests/src/Functional/RdfMappingTest.php @@ -148,6 +148,7 @@ class RdfMappingTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/ResponsiveImageStyleTest.php b/core/modules/jsonapi/tests/src/Functional/ResponsiveImageStyleTest.php index 86e4c384802..32b14bd9611 100644 --- a/core/modules/jsonapi/tests/src/Functional/ResponsiveImageStyleTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ResponsiveImageStyleTest.php @@ -142,6 +142,7 @@ class ResponsiveImageStyleTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php b/core/modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php index 317550c40b6..77a2dcbab9c 100644 --- a/core/modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php +++ b/core/modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php @@ -2,6 +2,7 @@ namespace Drupal\Tests\jsonapi\Functional; +use Drupal\Core\Cache\CacheableMetadata; use Drupal\Core\Url; use Drupal\node\Entity\Node; use Drupal\node\Entity\NodeType; @@ -117,11 +118,15 @@ class RestJsonApiUnsupported extends ResourceTestBase { /** * {@inheritdoc} */ - protected function getExpectedUnauthorizedAccessMessage($method) {} + protected function getExpectedUnauthorizedAccessMessage($method) { + return ''; + } /** * {@inheritdoc} */ - protected function getExpectedUnauthorizedAccessCacheability() {} + protected function getExpectedUnauthorizedAccessCacheability() { + return (new CacheableMetadata()); + } } diff --git a/core/modules/jsonapi/tests/src/Functional/RestResourceConfigTest.php b/core/modules/jsonapi/tests/src/Functional/RestResourceConfigTest.php index c900db5a903..5dbeeff934e 100644 --- a/core/modules/jsonapi/tests/src/Functional/RestResourceConfigTest.php +++ b/core/modules/jsonapi/tests/src/Functional/RestResourceConfigTest.php @@ -126,6 +126,7 @@ class RestResourceConfigTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/RoleTest.php b/core/modules/jsonapi/tests/src/Functional/RoleTest.php index e82b53e9f4f..a5116132252 100644 --- a/core/modules/jsonapi/tests/src/Functional/RoleTest.php +++ b/core/modules/jsonapi/tests/src/Functional/RoleTest.php @@ -101,6 +101,7 @@ class RoleTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/SearchPageTest.php b/core/modules/jsonapi/tests/src/Functional/SearchPageTest.php index fc4ffaa49be..ea1e4a00871 100644 --- a/core/modules/jsonapi/tests/src/Functional/SearchPageTest.php +++ b/core/modules/jsonapi/tests/src/Functional/SearchPageTest.php @@ -119,6 +119,7 @@ class SearchPageTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/ShortcutSetTest.php b/core/modules/jsonapi/tests/src/Functional/ShortcutSetTest.php index a5e080b8d2a..657cd1c3c9e 100644 --- a/core/modules/jsonapi/tests/src/Functional/ShortcutSetTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ShortcutSetTest.php @@ -123,6 +123,7 @@ class ShortcutSetTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/TourTest.php b/core/modules/jsonapi/tests/src/Functional/TourTest.php index 9a3a1d24270..13861609902 100644 --- a/core/modules/jsonapi/tests/src/Functional/TourTest.php +++ b/core/modules/jsonapi/tests/src/Functional/TourTest.php @@ -131,6 +131,7 @@ class TourTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/ViewTest.php b/core/modules/jsonapi/tests/src/Functional/ViewTest.php index a94c3c7194e..a4c105aae9f 100644 --- a/core/modules/jsonapi/tests/src/Functional/ViewTest.php +++ b/core/modules/jsonapi/tests/src/Functional/ViewTest.php @@ -121,6 +121,7 @@ class ViewTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/jsonapi/tests/src/Functional/VocabularyTest.php b/core/modules/jsonapi/tests/src/Functional/VocabularyTest.php index 49e548dcf16..cf86bb3e77b 100644 --- a/core/modules/jsonapi/tests/src/Functional/VocabularyTest.php +++ b/core/modules/jsonapi/tests/src/Functional/VocabularyTest.php @@ -100,6 +100,7 @@ class VocabularyTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/jsonapi/tests/src/Functional/WorkflowTest.php b/core/modules/jsonapi/tests/src/Functional/WorkflowTest.php index 94cda92d29e..7a2a00a8e03 100644 --- a/core/modules/jsonapi/tests/src/Functional/WorkflowTest.php +++ b/core/modules/jsonapi/tests/src/Functional/WorkflowTest.php @@ -126,6 +126,7 @@ class WorkflowTest extends ConfigEntityResourceTestBase { */ protected function getPostDocument() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/language/tests/src/Functional/Rest/ConfigurableLanguageResourceTestBase.php b/core/modules/language/tests/src/Functional/Rest/ConfigurableLanguageResourceTestBase.php index 933202a1222..02a976c7406 100644 --- a/core/modules/language/tests/src/Functional/Rest/ConfigurableLanguageResourceTestBase.php +++ b/core/modules/language/tests/src/Functional/Rest/ConfigurableLanguageResourceTestBase.php @@ -73,6 +73,7 @@ abstract class ConfigurableLanguageResourceTestBase extends ConfigEntityResource */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/language/tests/src/Functional/Rest/ContentLanguageSettingsResourceTestBase.php b/core/modules/language/tests/src/Functional/Rest/ContentLanguageSettingsResourceTestBase.php index 3eafb0be074..30683f0a14a 100644 --- a/core/modules/language/tests/src/Functional/Rest/ContentLanguageSettingsResourceTestBase.php +++ b/core/modules/language/tests/src/Functional/Rest/ContentLanguageSettingsResourceTestBase.php @@ -77,6 +77,7 @@ abstract class ContentLanguageSettingsResourceTestBase extends ConfigEntityResou */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php b/core/modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php index d51cdc72c09..378975db6b3 100644 --- a/core/modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php +++ b/core/modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php @@ -43,56 +43,77 @@ class TestStateBasedSectionStorage extends SectionStorageBase { /** * {@inheritdoc} */ - public function access($operation, AccountInterface $account = NULL, $return_as_object = FALSE) {} + public function access($operation, AccountInterface $account = NULL, $return_as_object = FALSE) { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - protected function getSectionList() {} + protected function getSectionList() { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - public function getStorageId() {} + public function getStorageId() { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - public function getSectionListFromId($id) {} + public function getSectionListFromId($id) { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - public function buildRoutes(RouteCollection $collection) {} + public function buildRoutes(RouteCollection $collection) { + } /** * {@inheritdoc} */ - public function getRedirectUrl() {} + public function getRedirectUrl() { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - public function getLayoutBuilderUrl($rel = 'view') {} + public function getLayoutBuilderUrl($rel = 'view') { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - public function extractIdFromRoute($value, $definition, $name, array $defaults) {} + public function extractIdFromRoute($value, $definition, $name, array $defaults) { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - public function deriveContextsFromRoute($value, $definition, $name, array $defaults) {} + public function deriveContextsFromRoute($value, $definition, $name, array $defaults) { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - public function label() {} + public function label() { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - public function save() {} + public function save() { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } } diff --git a/core/modules/layout_builder/tests/src/Functional/Rest/LayoutRestTestBase.php b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutRestTestBase.php index 5c6e9786ccb..e156864a30c 100644 --- a/core/modules/layout_builder/tests/src/Functional/Rest/LayoutRestTestBase.php +++ b/core/modules/layout_builder/tests/src/Functional/Rest/LayoutRestTestBase.php @@ -3,6 +3,7 @@ namespace Drupal\Tests\layout_builder\Functional\Rest; use Drupal\Component\Utility\NestedArray; +use Drupal\Core\Cache\CacheableMetadata; use Drupal\Core\Url; use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait; use Drupal\Tests\rest\Functional\ResourceTestBase; @@ -131,7 +132,9 @@ abstract class LayoutRestTestBase extends ResourceTestBase { /** * {@inheritdoc} */ - protected function getExpectedUnauthorizedAccessCacheability() {} + protected function getExpectedUnauthorizedAccessCacheability() { + return (new CacheableMetadata()); + } /** * Gets the decoded contents. diff --git a/core/modules/media/tests/src/Functional/Rest/MediaTypeResourceTestBase.php b/core/modules/media/tests/src/Functional/Rest/MediaTypeResourceTestBase.php index c935962fb5c..c74909e6f1a 100644 --- a/core/modules/media/tests/src/Functional/Rest/MediaTypeResourceTestBase.php +++ b/core/modules/media/tests/src/Functional/Rest/MediaTypeResourceTestBase.php @@ -73,6 +73,7 @@ abstract class MediaTypeResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/migrate/tests/src/Kernel/SqlBaseTest.php b/core/modules/migrate/tests/src/Kernel/SqlBaseTest.php index 71eaef1a4e6..1661aece762 100644 --- a/core/modules/migrate/tests/src/Kernel/SqlBaseTest.php +++ b/core/modules/migrate/tests/src/Kernel/SqlBaseTest.php @@ -225,12 +225,16 @@ class TestSqlBase extends SqlBase { /** * {@inheritdoc} */ - public function getIds() {} + public function getIds() { + return []; + } /** * {@inheritdoc} */ - public function fields() {} + public function fields() { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} diff --git a/core/modules/migrate/tests/src/Unit/SqlBaseTest.php b/core/modules/migrate/tests/src/Unit/SqlBaseTest.php index aa843c4ea28..749d9937f04 100644 --- a/core/modules/migrate/tests/src/Unit/SqlBaseTest.php +++ b/core/modules/migrate/tests/src/Unit/SqlBaseTest.php @@ -220,12 +220,16 @@ class TestSqlBase extends SqlBase { /** * {@inheritdoc} */ - public function fields() {} + public function fields() { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} */ - public function query() {} + public function query() { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); + } /** * {@inheritdoc} diff --git a/core/modules/migrate/tests/src/Unit/TestMigrateExecutable.php b/core/modules/migrate/tests/src/Unit/TestMigrateExecutable.php index 312472d7341..ecd56ca9c84 100644 --- a/core/modules/migrate/tests/src/Unit/TestMigrateExecutable.php +++ b/core/modules/migrate/tests/src/Unit/TestMigrateExecutable.php @@ -32,6 +32,7 @@ class TestMigrateExecutable extends MigrateExecutable { */ public function setStringTranslation(TranslationInterface $string_translation) { $this->stringTranslation = $string_translation; + return $this; } /** diff --git a/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php b/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php index 0be44f6ee39..d21e103e4de 100644 --- a/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php +++ b/core/modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php @@ -184,6 +184,7 @@ class TestDrupalSqlBase extends DrupalSqlBase { * {@inheritdoc} */ public function query() { + throw new \RuntimeException(__METHOD__ . " not implemented for " . __CLASS__); } /** diff --git a/core/modules/migrate_drupal_ui/tests/src/Functional/d6/IdConflictTest.php b/core/modules/migrate_drupal_ui/tests/src/Functional/d6/IdConflictTest.php index 7e9412f25d9..e03d0f7f39e 100644 --- a/core/modules/migrate_drupal_ui/tests/src/Functional/d6/IdConflictTest.php +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d6/IdConflictTest.php @@ -44,24 +44,28 @@ class IdConflictTest extends MigrateUpgradeExecuteTestBase { * {@inheritdoc} */ protected function getEntityCounts() { + return []; } /** * {@inheritdoc} */ protected function getEntityCountsIncremental() { + return []; } /** * {@inheritdoc} */ protected function getAvailablePaths() { + return []; } /** * {@inheritdoc} */ protected function getMissingPaths() { + return []; } /** diff --git a/core/modules/migrate_drupal_ui/tests/src/Functional/d6/NodeClassicTest.php b/core/modules/migrate_drupal_ui/tests/src/Functional/d6/NodeClassicTest.php index 6cea7ef5a44..72365989464 100644 --- a/core/modules/migrate_drupal_ui/tests/src/Functional/d6/NodeClassicTest.php +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d6/NodeClassicTest.php @@ -51,24 +51,28 @@ class NodeClassicTest extends MigrateUpgradeExecuteTestBase { * {@inheritdoc} */ protected function getEntityCounts() { + return []; } /** * {@inheritdoc} */ protected function getEntityCountsIncremental() { + return []; } /** * {@inheritdoc} */ protected function getAvailablePaths() { + return []; } /** * {@inheritdoc} */ protected function getMissingPaths() { + return []; } /** diff --git a/core/modules/migrate_drupal_ui/tests/src/Functional/d7/FilePathTest.php b/core/modules/migrate_drupal_ui/tests/src/Functional/d7/FilePathTest.php index 5f8652e8d20..6ccb1f97ff0 100644 --- a/core/modules/migrate_drupal_ui/tests/src/Functional/d7/FilePathTest.php +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d7/FilePathTest.php @@ -287,30 +287,35 @@ class FilePathTest extends MigrateUpgradeTestBase { * {@inheritdoc} */ protected function getEntityCounts() { + return []; } /** * {@inheritdoc} */ protected function getEntityCountsIncremental() { + return []; } /** * {@inheritdoc} */ protected function getAvailablePaths() { + return []; } /** * {@inheritdoc} */ protected function getMissingPaths() { + return []; } /** * {@inheritdoc} */ protected function getSourceBasePath() { + return ''; } } diff --git a/core/modules/migrate_drupal_ui/tests/src/Functional/d7/IdConflictTest.php b/core/modules/migrate_drupal_ui/tests/src/Functional/d7/IdConflictTest.php index 961e24dcfc3..892e4df6c29 100644 --- a/core/modules/migrate_drupal_ui/tests/src/Functional/d7/IdConflictTest.php +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d7/IdConflictTest.php @@ -44,24 +44,28 @@ class IdConflictTest extends MigrateUpgradeExecuteTestBase { * {@inheritdoc} */ protected function getEntityCounts() { + return []; } /** * {@inheritdoc} */ protected function getEntityCountsIncremental() { + return []; } /** * {@inheritdoc} */ protected function getAvailablePaths() { + return []; } /** * {@inheritdoc} */ protected function getMissingPaths() { + return []; } /** diff --git a/core/modules/node/tests/src/Functional/Rest/NodeTypeResourceTestBase.php b/core/modules/node/tests/src/Functional/Rest/NodeTypeResourceTestBase.php index b65a2b0433a..9b3e21cc862 100644 --- a/core/modules/node/tests/src/Functional/Rest/NodeTypeResourceTestBase.php +++ b/core/modules/node/tests/src/Functional/Rest/NodeTypeResourceTestBase.php @@ -74,6 +74,7 @@ abstract class NodeTypeResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/rdf/tests/src/Functional/Rest/RdfMappingResourceTestBase.php b/core/modules/rdf/tests/src/Functional/Rest/RdfMappingResourceTestBase.php index 45d3b3ef402..3a7e26bd341 100644 --- a/core/modules/rdf/tests/src/Functional/Rest/RdfMappingResourceTestBase.php +++ b/core/modules/rdf/tests/src/Functional/Rest/RdfMappingResourceTestBase.php @@ -111,6 +111,7 @@ abstract class RdfMappingResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/responsive_image/tests/src/Functional/Rest/ResponsiveImageStyleResourceTestBase.php b/core/modules/responsive_image/tests/src/Functional/Rest/ResponsiveImageStyleResourceTestBase.php index 1e115fd8bc1..7b0c7f0752a 100644 --- a/core/modules/responsive_image/tests/src/Functional/Rest/ResponsiveImageStyleResourceTestBase.php +++ b/core/modules/responsive_image/tests/src/Functional/Rest/ResponsiveImageStyleResourceTestBase.php @@ -117,6 +117,7 @@ abstract class ResponsiveImageStyleResourceTestBase extends ConfigEntityResource */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/rest/tests/src/Functional/FileUploadResourceTestBase.php b/core/modules/rest/tests/src/Functional/FileUploadResourceTestBase.php index 5156e095cda..56bceaf366b 100644 --- a/core/modules/rest/tests/src/Functional/FileUploadResourceTestBase.php +++ b/core/modules/rest/tests/src/Functional/FileUploadResourceTestBase.php @@ -4,6 +4,7 @@ namespace Drupal\Tests\rest\Functional; use Drupal\Component\Render\PlainTextOutput; use Drupal\Component\Utility\NestedArray; +use Drupal\Core\Cache\CacheableMetadata; use Drupal\Core\Field\FieldStorageDefinitionInterface; use Drupal\Core\Url; use Drupal\entity_test\Entity\EntityTest; @@ -819,6 +820,7 @@ abstract class FileUploadResourceTestBase extends ResourceTestBase { protected function getExpectedUnauthorizedAccessCacheability() { // There is cacheability metadata to check as file uploads only allows POST // requests, which will not return cacheable responses. + return new CacheableMetadata(); } } diff --git a/core/modules/rest/tests/src/Functional/ResourceTestBase.php b/core/modules/rest/tests/src/Functional/ResourceTestBase.php index e7d48795419..5d32aa20bf4 100644 --- a/core/modules/rest/tests/src/Functional/ResourceTestBase.php +++ b/core/modules/rest/tests/src/Functional/ResourceTestBase.php @@ -501,6 +501,8 @@ abstract class ResourceTestBase extends BrowserTestBase { static::recursiveKSort($value); } } + + return $array; } } diff --git a/core/modules/rest/tests/src/Functional/Rest/RestResourceConfigResourceTestBase.php b/core/modules/rest/tests/src/Functional/Rest/RestResourceConfigResourceTestBase.php index 45e94739509..f63cd257da2 100644 --- a/core/modules/rest/tests/src/Functional/Rest/RestResourceConfigResourceTestBase.php +++ b/core/modules/rest/tests/src/Functional/Rest/RestResourceConfigResourceTestBase.php @@ -89,6 +89,7 @@ abstract class RestResourceConfigResourceTestBase extends ConfigEntityResourceTe */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/search/tests/src/Functional/Rest/SearchPageResourceTestBase.php b/core/modules/search/tests/src/Functional/Rest/SearchPageResourceTestBase.php index b9f00855a72..5555e0211d0 100644 --- a/core/modules/search/tests/src/Functional/Rest/SearchPageResourceTestBase.php +++ b/core/modules/search/tests/src/Functional/Rest/SearchPageResourceTestBase.php @@ -80,6 +80,7 @@ abstract class SearchPageResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/shortcut/tests/src/Functional/Rest/ShortcutSetResourceTestBase.php b/core/modules/shortcut/tests/src/Functional/Rest/ShortcutSetResourceTestBase.php index e019984eb3e..5efce2740a0 100644 --- a/core/modules/shortcut/tests/src/Functional/Rest/ShortcutSetResourceTestBase.php +++ b/core/modules/shortcut/tests/src/Functional/Rest/ShortcutSetResourceTestBase.php @@ -83,6 +83,7 @@ abstract class ShortcutSetResourceTestBase extends ConfigEntityResourceTestBase */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/system/tests/modules/entity_test/tests/src/Functional/Rest/EntityTestBundleResourceTestBase.php b/core/modules/system/tests/modules/entity_test/tests/src/Functional/Rest/EntityTestBundleResourceTestBase.php index 26ed9224573..87ff2589940 100644 --- a/core/modules/system/tests/modules/entity_test/tests/src/Functional/Rest/EntityTestBundleResourceTestBase.php +++ b/core/modules/system/tests/modules/entity_test/tests/src/Functional/Rest/EntityTestBundleResourceTestBase.php @@ -68,6 +68,7 @@ abstract class EntityTestBundleResourceTestBase extends ConfigEntityResourceTest */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/system/tests/src/Functional/Form/StubForm.php b/core/modules/system/tests/src/Functional/Form/StubForm.php index 9e20c365ba8..4c30673d825 100644 --- a/core/modules/system/tests/src/Functional/Form/StubForm.php +++ b/core/modules/system/tests/src/Functional/Form/StubForm.php @@ -43,7 +43,7 @@ class StubForm extends FormBase { * {@inheritdoc} */ public function getFormId() { - $this->formId; + return $this->formId; } /** diff --git a/core/modules/system/tests/src/Functional/Rest/ActionResourceTestBase.php b/core/modules/system/tests/src/Functional/Rest/ActionResourceTestBase.php index 36a3222a966..b53be1b7b4f 100644 --- a/core/modules/system/tests/src/Functional/Rest/ActionResourceTestBase.php +++ b/core/modules/system/tests/src/Functional/Rest/ActionResourceTestBase.php @@ -75,6 +75,7 @@ abstract class ActionResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/system/tests/src/Functional/Rest/MenuResourceTestBase.php b/core/modules/system/tests/src/Functional/Rest/MenuResourceTestBase.php index d378086e865..a30f442648d 100644 --- a/core/modules/system/tests/src/Functional/Rest/MenuResourceTestBase.php +++ b/core/modules/system/tests/src/Functional/Rest/MenuResourceTestBase.php @@ -64,6 +64,7 @@ abstract class MenuResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php b/core/modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php index 78d82a2baf9..a0885b34621 100644 --- a/core/modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php +++ b/core/modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php @@ -417,6 +417,7 @@ class TestPathBasedBreadcrumbBuilder extends PathBasedBreadcrumbBuilder { public function setStringTranslation(TranslationInterface $string_translation) { $this->stringTranslation = $string_translation; + return $this; } public function setLinkGenerator(LinkGeneratorInterface $link_generator) { diff --git a/core/modules/taxonomy/tests/src/Functional/Rest/VocabularyResourceTestBase.php b/core/modules/taxonomy/tests/src/Functional/Rest/VocabularyResourceTestBase.php index 0693daf166a..de8e7a58040 100644 --- a/core/modules/taxonomy/tests/src/Functional/Rest/VocabularyResourceTestBase.php +++ b/core/modules/taxonomy/tests/src/Functional/Rest/VocabularyResourceTestBase.php @@ -63,6 +63,7 @@ abstract class VocabularyResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/tour/tests/src/Functional/Rest/TourResourceTestBase.php b/core/modules/tour/tests/src/Functional/Rest/TourResourceTestBase.php index 40bfced3dd6..813505a304e 100644 --- a/core/modules/tour/tests/src/Functional/Rest/TourResourceTestBase.php +++ b/core/modules/tour/tests/src/Functional/Rest/TourResourceTestBase.php @@ -94,6 +94,7 @@ abstract class TourResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/modules/user/tests/src/Functional/Rest/RoleResourceTestBase.php b/core/modules/user/tests/src/Functional/Rest/RoleResourceTestBase.php index bb090a103e8..0c12f123ce5 100644 --- a/core/modules/user/tests/src/Functional/Rest/RoleResourceTestBase.php +++ b/core/modules/user/tests/src/Functional/Rest/RoleResourceTestBase.php @@ -64,6 +64,7 @@ abstract class RoleResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/user/tests/src/Functional/UserRegistrationRestTest.php b/core/modules/user/tests/src/Functional/UserRegistrationRestTest.php index 27da6e3c37f..fe5283f1a74 100644 --- a/core/modules/user/tests/src/Functional/UserRegistrationRestTest.php +++ b/core/modules/user/tests/src/Functional/UserRegistrationRestTest.php @@ -2,6 +2,7 @@ namespace Drupal\Tests\user\Functional; +use Drupal\Core\Cache\CacheableMetadata; use Drupal\Core\Test\AssertMailTrait; use Drupal\Core\Url; use Drupal\Tests\rest\Functional\CookieResourceTestTrait; @@ -255,11 +256,15 @@ class UserRegistrationRestTest extends ResourceTestBase { /** * {@inheritdoc} */ - protected function getExpectedUnauthorizedAccessMessage($method) {} + protected function getExpectedUnauthorizedAccessMessage($method) { + return ''; + } /** * {@inheritdoc} */ - protected function getExpectedUnauthorizedAccessCacheability() {} + protected function getExpectedUnauthorizedAccessCacheability() { + return new CacheableMetadata(); + } } diff --git a/core/modules/views/src/Tests/ViewResultAssertionTrait.php b/core/modules/views/src/Tests/ViewResultAssertionTrait.php index 09a373d406e..a98c18e6471 100644 --- a/core/modules/views/src/Tests/ViewResultAssertionTrait.php +++ b/core/modules/views/src/Tests/ViewResultAssertionTrait.php @@ -27,12 +27,9 @@ trait ViewResultAssertionTrait { * @param string $message * (optional) A custom message to display with the assertion. Defaults to * 'Identical result set.' - * - * @return bool - * TRUE if the assertion succeeded, or FALSE otherwise. */ - protected function assertIdenticalResultset($view, $expected_result, $column_map = [], $message = NULL) { - return $this->assertIdenticalResultsetHelper($view, $expected_result, $column_map, 'assertIdentical', $message); + protected function assertIdenticalResultset($view, $expected_result, $column_map = [], $message = NULL): void { + $this->assertIdenticalResultsetHelper($view, $expected_result, $column_map, 'assertIdentical', $message); } /** @@ -50,12 +47,9 @@ trait ViewResultAssertionTrait { * @param string $message * (optional) A custom message to display with the assertion. Defaults to * 'Non-identical result set.' - * - * @return bool - * TRUE if the assertion succeeded, or FALSE otherwise. */ - protected function assertNotIdenticalResultset($view, $expected_result, $column_map = [], $message = NULL) { - return $this->assertIdenticalResultsetHelper($view, $expected_result, $column_map, 'assertNotIdentical', $message); + protected function assertNotIdenticalResultset($view, $expected_result, $column_map = [], $message = NULL): void { + $this->assertIdenticalResultsetHelper($view, $expected_result, $column_map, 'assertNotIdentical', $message); } /** @@ -76,11 +70,8 @@ trait ViewResultAssertionTrait { * 'assertNotIdentical'). * @param string $message * (optional) The message to display with the assertion. - * - * @return bool - * TRUE if the assertion succeeded. */ - protected function assertIdenticalResultsetHelper($view, $expected_result, $column_map, $assert_method, $message = NULL) { + protected function assertIdenticalResultsetHelper($view, $expected_result, $column_map, $assert_method, $message = NULL): void { // Convert $view->result to an array of arrays. $result = []; foreach ($view->result as $key => $value) { @@ -142,11 +133,11 @@ trait ViewResultAssertionTrait { switch ($assert_method) { case 'assertIdentical': $this->assertSame($expected_result, $result, $message); - return TRUE; + break; case 'assertNotIdentical': $this->assertNotSame($expected_result, $result, $message); - return TRUE; + break; } } diff --git a/core/modules/views/tests/src/Functional/Rest/ViewResourceTestBase.php b/core/modules/views/tests/src/Functional/Rest/ViewResourceTestBase.php index 6c5c5d9376a..27ae6226901 100644 --- a/core/modules/views/tests/src/Functional/Rest/ViewResourceTestBase.php +++ b/core/modules/views/tests/src/Functional/Rest/ViewResourceTestBase.php @@ -84,6 +84,7 @@ abstract class ViewResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/modules/workflows/tests/src/Functional/Rest/WorkflowResourceTestBase.php b/core/modules/workflows/tests/src/Functional/Rest/WorkflowResourceTestBase.php index a9317f1e1f8..a192a419d91 100644 --- a/core/modules/workflows/tests/src/Functional/Rest/WorkflowResourceTestBase.php +++ b/core/modules/workflows/tests/src/Functional/Rest/WorkflowResourceTestBase.php @@ -102,6 +102,7 @@ abstract class WorkflowResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/phpstan-baseline.neon b/core/phpstan-baseline.neon index 43eb969041a..36adef829b1 100644 --- a/core/phpstan-baseline.neon +++ b/core/phpstan-baseline.neon @@ -680,11 +680,6 @@ parameters: count: 2 path: modules/block/tests/modules/block_test/src/Plugin/Block/TestAccessBlock.php - - - message: "#^Method Drupal\\\\Tests\\\\block\\\\Functional\\\\Rest\\\\BlockResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/block/tests/src/Functional/Rest/BlockResourceTestBase.php - - message: "#^Method Drupal\\\\block_content\\\\BlockContentForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#" count: 1 @@ -705,11 +700,6 @@ parameters: count: 1 path: modules/block_content/tests/src/Functional/BlockContentSaveTest.php - - - message: "#^Method Drupal\\\\Tests\\\\block_content\\\\Functional\\\\Rest\\\\BlockContentTypeResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/block_content/tests/src/Functional/Rest/BlockContentTypeResourceTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 2 @@ -720,16 +710,6 @@ parameters: count: 3 path: modules/block_content/tests/src/Kernel/Migrate/d6/MigrateCustomBlockContentTranslationTest.php - - - message: "#^Method Drupal\\\\Tests\\\\block_content\\\\Kernel\\\\Views\\\\RevisionRelationshipsTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/block_content/tests/src/Kernel/Views/RevisionRelationshipsTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\block_content\\\\Kernel\\\\Views\\\\RevisionUserTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/block_content/tests/src/Kernel/Views/RevisionUserTest.php - - message: "#^Method Drupal\\\\book\\\\BookOutline\\:\\:nextLink\\(\\) should return array but return statement is missing\\.$#" count: 1 @@ -850,41 +830,16 @@ parameters: count: 1 path: modules/comment/tests/src/Functional/CommentBlockTest.php - - - message: "#^Method Drupal\\\\Tests\\\\comment\\\\Functional\\\\CommentNonNodeTest\\:\\:postComment\\(\\) should return Drupal\\\\comment\\\\CommentInterface but return statement is missing\\.$#" - count: 1 - path: modules/comment/tests/src/Functional/CommentNonNodeTest.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 path: modules/comment/tests/src/Functional/CommentTranslationUITest.php - - - message: "#^Method Drupal\\\\Tests\\\\comment\\\\Functional\\\\Rest\\\\CommentResourceTestBase\\:\\:getExpectedUnauthorizedAccessMessage\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: modules/comment/tests/src/Functional/Rest/CommentResourceTestBase.php - - - - message: "#^Method Drupal\\\\Tests\\\\comment\\\\Functional\\\\Rest\\\\CommentTypeResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/comment/tests/src/Functional/Rest/CommentTypeResourceTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 path: modules/comment/tests/src/Functional/Views/DefaultViewRecentCommentsTest.php - - - message: "#^Method Drupal\\\\Tests\\\\comment\\\\Kernel\\\\Views\\\\CommentFieldNameTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/comment/tests/src/Kernel/Views/CommentFieldNameTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\comment\\\\Kernel\\\\Views\\\\FilterAndArgumentUserUidTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/comment/tests/src/Kernel/Views/FilterAndArgumentUserUidTest.php - - message: "#^Access to constant DEFAULT_COLLECTION on an unknown class Drupal\\\\config_override_test\\\\StorageInterface\\.$#" count: 1 @@ -895,11 +850,6 @@ parameters: count: 1 path: modules/config/tests/config_test/src/ConfigTestForm.php - - - message: "#^Method Drupal\\\\Tests\\\\config_test\\\\Functional\\\\Rest\\\\ConfigTestResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/config/tests/config_test/tests/src/Functional/Rest/ConfigTestResourceTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 @@ -925,11 +875,6 @@ parameters: count: 1 path: modules/contact/src/MessageForm.php - - - message: "#^Method Drupal\\\\Tests\\\\contact\\\\Functional\\\\Rest\\\\ContactFormResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/contact/tests/src/Functional/Rest/ContactFormResourceTestBase.php - - message: "#^Method Drupal\\\\content_moderation\\\\ModerationInformation\\:\\:getAffectedRevisionTranslation\\(\\) should return Drupal\\\\Core\\\\Entity\\\\ContentEntityInterface but return statement is missing\\.$#" count: 1 @@ -995,11 +940,6 @@ parameters: count: 1 path: modules/dblog/tests/src/Kernel/DbLogTest.php - - - message: "#^Method Drupal\\\\Tests\\\\editor\\\\Functional\\\\Rest\\\\EditorResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/editor/tests/src/Functional/Rest/EditorResourceTestBase.php - - message: "#^Access to an undefined property Drupal\\\\field\\\\Entity\\\\FieldConfig\\:\\:\\$original\\.$#" count: 4 @@ -1015,16 +955,6 @@ parameters: count: 2 path: modules/field/tests/src/Functional/NestedFormTest.php - - - message: "#^Method Drupal\\\\Tests\\\\field\\\\Functional\\\\Rest\\\\FieldConfigResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/field/tests/src/Functional/Rest/FieldConfigResourceTestBase.php - - - - message: "#^Method Drupal\\\\Tests\\\\field\\\\Functional\\\\Rest\\\\FieldStorageConfigResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/field/tests/src/Functional/Rest/FieldStorageConfigResourceTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 @@ -1110,11 +1040,6 @@ parameters: count: 2 path: modules/file/tests/src/Kernel/UsageTest.php - - - message: "#^Method Drupal\\\\Tests\\\\file\\\\Kernel\\\\Views\\\\RelationshipUserFileDataTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/file/tests/src/Kernel/Views/RelationshipUserFileDataTest.php - - message: "#^\\#lazy_builder value 'string' at key '0' is invalid\\.$#" count: 1 @@ -1125,11 +1050,6 @@ parameters: count: 1 path: modules/filter/src/Plugin/migrate/process/d6/FilterFormatPermission.php - - - message: "#^Method Drupal\\\\Tests\\\\filter\\\\Functional\\\\Rest\\\\FilterFormatResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/filter/tests/src/Functional/Rest/FilterFormatResourceTestBase.php - - message: "#^Method Drupal\\\\forum\\\\ForumManager\\:\\:getTopicOrder\\(\\) should return array but return statement is missing\\.$#" count: 1 @@ -1175,11 +1095,6 @@ parameters: count: 1 path: modules/image/src/Form/ImageStyleFormBase.php - - - message: "#^Method Drupal\\\\Tests\\\\image\\\\Functional\\\\Rest\\\\ImageStyleResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/image/tests/src/Functional/Rest/ImageStyleResourceTestBase.php - - message: "#^Method Drupal\\\\jsonapi\\\\JsonApiResource\\\\ResourceIdentifier\\:\\:getDataReferencePropertyName\\(\\) should return string but return statement is missing\\.$#" count: 1 @@ -1190,196 +1105,11 @@ parameters: count: 1 path: modules/jsonapi/src/Revisions/VersionNegotiator.php - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\ActionTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/ActionTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\BaseFieldOverrideTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/BaseFieldOverrideTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\BlockContentTypeTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/BlockContentTypeTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\BlockTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/BlockTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\CommentTypeTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/CommentTypeTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\ConfigTestTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/ConfigTestTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\ConfigurableLanguageTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/ConfigurableLanguageTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\ContactFormTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/ContactFormTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\ContentLanguageSettingsTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/ContentLanguageSettingsTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\DateFormatTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/DateFormatTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\EditorTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/EditorTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\EntityFormDisplayTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/EntityFormDisplayTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\EntityFormModeTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/EntityFormModeTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\EntityViewDisplayTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/EntityViewDisplayTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\EntityViewModeTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/EntityViewModeTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\FieldConfigTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/FieldConfigTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\FieldStorageConfigTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/FieldStorageConfigTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\FileUploadTest\\:\\:getExpectedUnauthorizedAccessCacheability\\(\\) should return Drupal\\\\Core\\\\Cache\\\\CacheableMetadata but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/FileUploadTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\FileUploadTest\\:\\:getExpectedUnauthorizedAccessMessage\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/FileUploadTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\FilterFormatTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/FilterFormatTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\ImageStyleTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/ImageStyleTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\MediaTypeTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/MediaTypeTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\MenuTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/MenuTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\NodeTest\\:\\:getExpectedUnauthorizedAccessMessage\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/NodeTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\NodeTypeTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/NodeTypeTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\RdfMappingTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/RdfMappingTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\ResponsiveImageStyleTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/ResponsiveImageStyleTest.php - - message: "#^Access to an undefined property Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\RestJsonApiUnsupported\\:\\:\\$httpClient\\.$#" count: 1 path: modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\RestJsonApiUnsupported\\:\\:getExpectedUnauthorizedAccessCacheability\\(\\) should return Drupal\\\\Core\\\\Cache\\\\RefinableCacheableDependencyInterface but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\RestJsonApiUnsupported\\:\\:getExpectedUnauthorizedAccessMessage\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/RestJsonApiUnsupported.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\RestResourceConfigTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/RestResourceConfigTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\RoleTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/RoleTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\SearchPageTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/SearchPageTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\ShortcutSetTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/ShortcutSetTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\TourTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/TourTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\ViewTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/ViewTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\VocabularyTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/VocabularyTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\jsonapi\\\\Functional\\\\WorkflowTest\\:\\:getPostDocument\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/jsonapi/tests/src/Functional/WorkflowTest.php - - message: "#^Method Drupal\\\\language\\\\Form\\\\LanguageAddForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#" count: 1 @@ -1395,61 +1125,6 @@ parameters: count: 1 path: modules/language/src/LanguageNegotiationMethodManager.php - - - message: "#^Method Drupal\\\\Tests\\\\language\\\\Functional\\\\Rest\\\\ConfigurableLanguageResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/language/tests/src/Functional/Rest/ConfigurableLanguageResourceTestBase.php - - - - message: "#^Method Drupal\\\\Tests\\\\language\\\\Functional\\\\Rest\\\\ContentLanguageSettingsResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/language/tests/src/Functional/Rest/ContentLanguageSettingsResourceTestBase.php - - - - message: "#^Method Drupal\\\\layout_builder_test\\\\Plugin\\\\SectionStorage\\\\TestStateBasedSectionStorage\\:\\:access\\(\\) should return bool\\|Drupal\\\\Core\\\\Access\\\\AccessResultInterface but return statement is missing\\.$#" - count: 1 - path: modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php - - - - message: "#^Method Drupal\\\\layout_builder_test\\\\Plugin\\\\SectionStorage\\\\TestStateBasedSectionStorage\\:\\:deriveContextsFromRoute\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php - - - - message: "#^Method Drupal\\\\layout_builder_test\\\\Plugin\\\\SectionStorage\\\\TestStateBasedSectionStorage\\:\\:getLayoutBuilderUrl\\(\\) should return Drupal\\\\Core\\\\Url but return statement is missing\\.$#" - count: 1 - path: modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php - - - - message: "#^Method Drupal\\\\layout_builder_test\\\\Plugin\\\\SectionStorage\\\\TestStateBasedSectionStorage\\:\\:getRedirectUrl\\(\\) should return Drupal\\\\Core\\\\Url but return statement is missing\\.$#" - count: 1 - path: modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php - - - - message: "#^Method Drupal\\\\layout_builder_test\\\\Plugin\\\\SectionStorage\\\\TestStateBasedSectionStorage\\:\\:getSectionList\\(\\) should return Drupal\\\\layout_builder\\\\SectionListInterface but return statement is missing\\.$#" - count: 1 - path: modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php - - - - message: "#^Method Drupal\\\\layout_builder_test\\\\Plugin\\\\SectionStorage\\\\TestStateBasedSectionStorage\\:\\:getStorageId\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php - - - - message: "#^Method Drupal\\\\layout_builder_test\\\\Plugin\\\\SectionStorage\\\\TestStateBasedSectionStorage\\:\\:label\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php - - - - message: "#^Method Drupal\\\\layout_builder_test\\\\Plugin\\\\SectionStorage\\\\TestStateBasedSectionStorage\\:\\:save\\(\\) should return int but return statement is missing\\.$#" - count: 1 - path: modules/layout_builder/tests/modules/layout_builder_test/src/Plugin/SectionStorage/TestStateBasedSectionStorage.php - - - - message: "#^Method Drupal\\\\Tests\\\\layout_builder\\\\Functional\\\\Rest\\\\LayoutRestTestBase\\:\\:getExpectedUnauthorizedAccessCacheability\\(\\) should return Drupal\\\\Core\\\\Cache\\\\RefinableCacheableDependencyInterface but return statement is missing\\.$#" - count: 1 - path: modules/layout_builder/tests/src/Functional/Rest/LayoutRestTestBase.php - - message: "#^Call to an undefined method Drupal\\\\Tests\\\\layout_builder\\\\Unit\\\\DefaultsSectionStorageTest\\:\\:getThirdPartySetting\\(\\)\\.$#" count: 1 @@ -1550,16 +1225,6 @@ parameters: count: 1 path: modules/media/src/MediaTypeForm.php - - - message: "#^Method Drupal\\\\Tests\\\\media\\\\Functional\\\\Rest\\\\MediaTypeResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/media/tests/src/Functional/Rest/MediaTypeResourceTestBase.php - - - - message: "#^Method Drupal\\\\Tests\\\\media\\\\Kernel\\\\Views\\\\RevisionUserTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/media/tests/src/Kernel/Views/RevisionUserTest.php - - message: "#^Method Drupal\\\\menu_link_content\\\\Form\\\\MenuLinkContentForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#" count: 1 @@ -1620,31 +1285,6 @@ parameters: count: 1 path: modules/migrate/tests/src/Kernel/MigrateTestBase.php - - - message: "#^Method Drupal\\\\Tests\\\\migrate\\\\Kernel\\\\TestSqlBase\\:\\:fields\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/migrate/tests/src/Kernel/SqlBaseTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate\\\\Kernel\\\\TestSqlBase\\:\\:getIds\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate/tests/src/Kernel/SqlBaseTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate\\\\Unit\\\\TestSqlBase\\:\\:fields\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/migrate/tests/src/Unit/SqlBaseTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate\\\\Unit\\\\TestSqlBase\\:\\:query\\(\\) should return Drupal\\\\Core\\\\Database\\\\Query\\\\SelectInterface but return statement is missing\\.$#" - count: 1 - path: modules/migrate/tests/src/Unit/SqlBaseTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate\\\\Unit\\\\TestMigrateExecutable\\:\\:setStringTranslation\\(\\) should return \\$this\\(Drupal\\\\Tests\\\\migrate\\\\Unit\\\\TestMigrateExecutable\\) but return statement is missing\\.$#" - count: 1 - path: modules/migrate/tests/src/Unit/TestMigrateExecutable.php - - message: """ #^Cannot unset offset 'menu_ui' on array\\{system\\: 'finished\\: @@ -1658,11 +1298,6 @@ parameters: count: 1 path: modules/migrate_drupal/tests/src/Unit/MigrationStateUnitTest.php - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal\\\\Unit\\\\source\\\\TestDrupalSqlBase\\:\\:query\\(\\) should return Drupal\\\\Core\\\\Database\\\\Query\\\\SelectInterface but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal/tests/src/Unit/source/DrupalSqlBaseTest.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 2 @@ -1713,91 +1348,6 @@ parameters: count: 8 path: modules/migrate_drupal_ui/tests/src/Functional/MultilingualReviewPageTestBase.php - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d6\\\\IdConflictTest\\:\\:getAvailablePaths\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d6/IdConflictTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d6\\\\IdConflictTest\\:\\:getEntityCounts\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d6/IdConflictTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d6\\\\IdConflictTest\\:\\:getEntityCountsIncremental\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d6/IdConflictTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d6\\\\IdConflictTest\\:\\:getMissingPaths\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d6/IdConflictTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d6\\\\NodeClassicTest\\:\\:getAvailablePaths\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d6/NodeClassicTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d6\\\\NodeClassicTest\\:\\:getEntityCounts\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d6/NodeClassicTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d6\\\\NodeClassicTest\\:\\:getEntityCountsIncremental\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d6/NodeClassicTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d6\\\\NodeClassicTest\\:\\:getMissingPaths\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d6/NodeClassicTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d7\\\\FilePathTest\\:\\:getAvailablePaths\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d7/FilePathTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d7\\\\FilePathTest\\:\\:getEntityCounts\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d7/FilePathTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d7\\\\FilePathTest\\:\\:getEntityCountsIncremental\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d7/FilePathTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d7\\\\FilePathTest\\:\\:getMissingPaths\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d7/FilePathTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d7\\\\FilePathTest\\:\\:getSourceBasePath\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d7/FilePathTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d7\\\\IdConflictTest\\:\\:getAvailablePaths\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d7/IdConflictTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d7\\\\IdConflictTest\\:\\:getEntityCounts\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d7/IdConflictTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d7\\\\IdConflictTest\\:\\:getEntityCountsIncremental\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d7/IdConflictTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\migrate_drupal_ui\\\\Functional\\\\d7\\\\IdConflictTest\\:\\:getMissingPaths\\(\\) should return array\\ but return statement is missing\\.$#" - count: 1 - path: modules/migrate_drupal_ui/tests/src/Functional/d7/IdConflictTest.php - - message: "#^Method Drupal\\\\node\\\\ConfigTranslation\\\\NodeTypeMapper\\:\\:setEntity\\(\\) should return bool but return statement is missing\\.$#" count: 1 @@ -1863,11 +1413,6 @@ parameters: count: 1 path: modules/node/tests/src/Functional/NodeTranslationUITest.php - - - message: "#^Method Drupal\\\\Tests\\\\node\\\\Functional\\\\Rest\\\\NodeTypeResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/node/tests/src/Functional/Rest/NodeTypeResourceTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 3 @@ -1888,16 +1433,6 @@ parameters: count: 1 path: modules/node/tests/src/Kernel/Plugin/migrate/source/d7/NodeTest.php - - - message: "#^Method Drupal\\\\Tests\\\\node\\\\Kernel\\\\Views\\\\FilterUidRevisionTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/node/tests/src/Kernel/Views/FilterUidRevisionTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\node\\\\Kernel\\\\Views\\\\RevisionUidTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/node/tests/src/Kernel/Views/RevisionUidTest.php - - message: "#^Method Drupal\\\\options\\\\Plugin\\\\Field\\\\FieldType\\\\ListFloatItem\\:\\:validateAllowedValue\\(\\) should return string but return statement is missing\\.$#" count: 1 @@ -1948,11 +1483,6 @@ parameters: count: 1 path: modules/pgsql/src/Driver/Database/pgsql/Upsert.php - - - message: "#^Method Drupal\\\\Tests\\\\rdf\\\\Functional\\\\Rest\\\\RdfMappingResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/rdf/tests/src/Functional/Rest/RdfMappingResourceTestBase.php - - message: "#^Call to an undefined method Drupal\\\\Tests\\\\rdf\\\\Kernel\\\\Field\\\\FieldRdfaTestBase\\:\\:drupalGet\\(\\)\\.$#" count: 2 @@ -1963,11 +1493,6 @@ parameters: count: 1 path: modules/responsive_image/src/ResponsiveImageStyleForm.php - - - message: "#^Method Drupal\\\\Tests\\\\responsive_image\\\\Functional\\\\Rest\\\\ResponsiveImageStyleResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/responsive_image/tests/src/Functional/Rest/ResponsiveImageStyleResourceTestBase.php - - message: "#^Method Drupal\\\\rest\\\\Plugin\\\\Deriver\\\\EntityDeriver\\:\\:getDerivativeDefinition\\(\\) should return array but return statement is missing\\.$#" count: 1 @@ -1978,21 +1503,6 @@ parameters: count: 1 path: modules/rest/src/Routing/ResourceRoutes.php - - - message: "#^Method Drupal\\\\Tests\\\\rest\\\\Functional\\\\FileUploadResourceTestBase\\:\\:getExpectedUnauthorizedAccessCacheability\\(\\) should return Drupal\\\\Core\\\\Cache\\\\RefinableCacheableDependencyInterface but return statement is missing\\.$#" - count: 1 - path: modules/rest/tests/src/Functional/FileUploadResourceTestBase.php - - - - message: "#^Method Drupal\\\\Tests\\\\rest\\\\Functional\\\\ResourceTestBase\\:\\:recursiveKSort\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/rest/tests/src/Functional/ResourceTestBase.php - - - - message: "#^Method Drupal\\\\Tests\\\\rest\\\\Functional\\\\Rest\\\\RestResourceConfigResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/rest/tests/src/Functional/Rest/RestResourceConfigResourceTestBase.php - - message: "#^Method Drupal\\\\search\\\\Form\\\\SearchPageAddForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#" count: 1 @@ -2038,11 +1548,6 @@ parameters: count: 1 path: modules/search/tests/modules/search_extra_type/src/Plugin/Search/SearchExtraTypeSearch.php - - - message: "#^Method Drupal\\\\Tests\\\\search\\\\Functional\\\\Rest\\\\SearchPageResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/search/tests/src/Functional/Rest/SearchPageResourceTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 @@ -2078,11 +1583,6 @@ parameters: count: 1 path: modules/shortcut/src/ShortcutSetForm.php - - - message: "#^Method Drupal\\\\Tests\\\\shortcut\\\\Functional\\\\Rest\\\\ShortcutSetResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/shortcut/tests/src/Functional/Rest/ShortcutSetResourceTestBase.php - - message: "#^Method Drupal\\\\system\\\\Controller\\\\BatchController\\:\\:batchPage\\(\\) should return array\\|Symfony\\\\Component\\\\HttpFoundation\\\\Response but return statement is missing\\.$#" count: 1 @@ -2153,11 +1653,6 @@ parameters: count: 1 path: modules/system/tests/modules/entity_test/src/Plugin/Field/FieldType/ChangedTestItem.php - - - message: "#^Method Drupal\\\\Tests\\\\entity_test\\\\Functional\\\\Rest\\\\EntityTestBundleResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/system/tests/modules/entity_test/tests/src/Functional/Rest/EntityTestBundleResourceTestBase.php - - message: "#^Access to an undefined property Drupal\\\\error_service_test\\\\Controller\\\\LonelyMonkeyController\\:\\:\\$class\\.$#" count: 1 @@ -2208,21 +1703,6 @@ parameters: count: 1 path: modules/system/tests/src/Functional/FileTransfer/FileTransferTest.php - - - message: "#^Method Drupal\\\\Tests\\\\system\\\\Functional\\\\Form\\\\StubForm\\:\\:getFormId\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: modules/system/tests/src/Functional/Form/StubForm.php - - - - message: "#^Method Drupal\\\\Tests\\\\system\\\\Functional\\\\Rest\\\\ActionResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/system/tests/src/Functional/Rest/ActionResourceTestBase.php - - - - message: "#^Method Drupal\\\\Tests\\\\system\\\\Functional\\\\Rest\\\\MenuResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/system/tests/src/Functional/Rest/MenuResourceTestBase.php - - message: "#^Call to an undefined method Drupal\\\\Tests\\\\system\\\\Kernel\\\\Common\\\\PageRenderTest\\:\\:error\\(\\)\\.$#" count: 2 @@ -2233,11 +1713,6 @@ parameters: count: 1 path: modules/system/tests/src/Kernel/Token/TokenReplaceKernelTest.php - - - message: "#^Method Drupal\\\\Tests\\\\system\\\\Unit\\\\Breadcrumbs\\\\TestPathBasedBreadcrumbBuilder\\:\\:setStringTranslation\\(\\) should return \\$this\\(Drupal\\\\Tests\\\\system\\\\Unit\\\\Breadcrumbs\\\\TestPathBasedBreadcrumbBuilder\\) but return statement is missing\\.$#" - count: 1 - path: modules/system/tests/src/Unit/Breadcrumbs/PathBasedBreadcrumbBuilderTest.php - - message: "#^Method Drupal\\\\taxonomy\\\\Plugin\\\\migrate\\\\source\\\\d7\\\\TermTranslation\\:\\:prepareRow\\(\\) should return bool but return statement is missing\\.$#" count: 1 @@ -2298,11 +1773,6 @@ parameters: count: 1 path: modules/taxonomy/src/VocabularyForm.php - - - message: "#^Method Drupal\\\\Tests\\\\taxonomy\\\\Functional\\\\Rest\\\\VocabularyResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/taxonomy/tests/src/Functional/Rest/VocabularyResourceTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 @@ -2313,16 +1783,6 @@ parameters: count: 1 path: modules/tour/src/TipPluginBase.php - - - message: "#^Method Drupal\\\\Tests\\\\tour\\\\Functional\\\\Rest\\\\TourResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/tour/tests/src/Functional/Rest/TourResourceTestBase.php - - - - message: "#^Method Drupal\\\\Tests\\\\tracker\\\\Kernel\\\\Views\\\\TrackerUserUidTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/tracker/tests/src/Kernel/Views/TrackerUserUidTest.php - - message: "#^Access to an undefined property Drupal\\\\update\\\\UpdateProcessor\\:\\:\\$fetchTasks\\.$#" count: 2 @@ -2388,11 +1848,6 @@ parameters: count: 1 path: modules/user/src/RoleForm.php - - - message: "#^Method Drupal\\\\Tests\\\\user\\\\Functional\\\\Rest\\\\RoleResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/user/tests/src/Functional/Rest/RoleResourceTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 2 @@ -2418,16 +1873,6 @@ parameters: count: 1 path: modules/user/tests/src/Functional/UserRegistrationRestTest.php - - - message: "#^Method Drupal\\\\Tests\\\\user\\\\Functional\\\\UserRegistrationRestTest\\:\\:getExpectedUnauthorizedAccessCacheability\\(\\) should return Drupal\\\\Core\\\\Cache\\\\RefinableCacheableDependencyInterface but return statement is missing\\.$#" - count: 1 - path: modules/user/tests/src/Functional/UserRegistrationRestTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\user\\\\Functional\\\\UserRegistrationRestTest\\:\\:getExpectedUnauthorizedAccessMessage\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: modules/user/tests/src/Functional/UserRegistrationRestTest.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 @@ -2443,11 +1888,6 @@ parameters: count: 1 path: modules/user/tests/src/FunctionalJavascript/UserPasswordResetTest.php - - - message: "#^Method Drupal\\\\Tests\\\\user\\\\Kernel\\\\Views\\\\RelationshipRepresentativeNodeTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/user/tests/src/Kernel/Views/RelationshipRepresentativeNodeTest.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 5 @@ -2863,16 +2303,6 @@ parameters: count: 2 path: modules/views/tests/src/Functional/GlossaryTest.php - - - message: "#^Method Drupal\\\\Tests\\\\views\\\\Functional\\\\Rest\\\\ViewResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/views/tests/src/Functional/Rest/ViewResourceTestBase.php - - - - message: "#^Method Drupal\\\\Tests\\\\views\\\\Functional\\\\ViewTestBase\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/views/tests/src/Functional/ViewTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 6 @@ -2923,11 +2353,6 @@ parameters: count: 2 path: modules/views/tests/src/Kernel/RenderCacheIntegrationTest.php - - - message: "#^Method Drupal\\\\Tests\\\\views\\\\Kernel\\\\ViewsKernelTestBase\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/views/tests/src/Kernel/ViewsKernelTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 1 @@ -2993,11 +2418,6 @@ parameters: count: 1 path: modules/workflows/src/Form/WorkflowTransitionEditForm.php - - - message: "#^Method Drupal\\\\Tests\\\\workflows\\\\Functional\\\\Rest\\\\WorkflowResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: modules/workflows/tests/src/Functional/Rest/WorkflowResourceTestBase.php - - message: "#^Method Drupal\\\\workspaces\\\\EntityTypeInfo\\:\\:entityBaseFieldInfo\\(\\) should return array\\ but return statement is missing\\.$#" count: 1 @@ -3018,46 +2438,11 @@ parameters: count: 1 path: modules/workspaces/src/WorkspacePublisher.php - - - message: "#^Method Drupal\\\\Tests\\\\workspaces\\\\Kernel\\\\WorkspaceIntegrationTest\\:\\:assertIdenticalResultsetHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: modules/workspaces/tests/src/Kernel/WorkspaceIntegrationTest.php - - message: "#^Access to an undefined property Drupal\\\\demo_umami_content\\\\InstallHelper\\:\\:\\$module_path\\.$#" count: 5 path: profiles/demo_umami/modules/demo_umami_content/src/InstallHelper.php - - - message: "#^Method Drupal\\\\FunctionalTests\\\\Rest\\\\BaseFieldOverrideResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/FunctionalTests/Rest/BaseFieldOverrideResourceTestBase.php - - - - message: "#^Method Drupal\\\\FunctionalTests\\\\Rest\\\\DateFormatResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/FunctionalTests/Rest/DateFormatResourceTestBase.php - - - - message: "#^Method Drupal\\\\FunctionalTests\\\\Rest\\\\EntityFormDisplayResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/FunctionalTests/Rest/EntityFormDisplayResourceTestBase.php - - - - message: "#^Method Drupal\\\\FunctionalTests\\\\Rest\\\\EntityFormModeResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/FunctionalTests/Rest/EntityFormModeResourceTestBase.php - - - - message: "#^Method Drupal\\\\FunctionalTests\\\\Rest\\\\EntityViewDisplayResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/FunctionalTests/Rest/EntityViewDisplayResourceTestBase.php - - - - message: "#^Method Drupal\\\\FunctionalTests\\\\Rest\\\\EntityViewModeResourceTestBase\\:\\:getNormalizedPostEntity\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/FunctionalTests/Rest/EntityViewModeResourceTestBase.php - - message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#" count: 12 @@ -3118,31 +2503,6 @@ parameters: count: 5 path: tests/Drupal/KernelTests/Core/TypedData/TypedDataTest.php - - - message: "#^Method Drupal\\\\KernelTests\\\\KernelTestBase\\:\\:assertEscaped\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/KernelTests/KernelTestBase.php - - - - message: "#^Method Drupal\\\\KernelTests\\\\KernelTestBase\\:\\:assertNoEscaped\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/KernelTests/KernelTestBase.php - - - - message: "#^Method Drupal\\\\KernelTests\\\\KernelTestBase\\:\\:assertNoRaw\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/KernelTests/KernelTestBase.php - - - - message: "#^Method Drupal\\\\KernelTests\\\\KernelTestBase\\:\\:assertRaw\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/KernelTests/KernelTestBase.php - - - - message: "#^Method Drupal\\\\KernelTests\\\\KernelTestBase\\:\\:assertTextHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/KernelTests/KernelTestBase.php - - message: "#^Parameter \\$template of method Drupal\\\\KernelTests\\\\KernelTestBase\\:\\:prepareTemplate\\(\\) has invalid type Text_Template\\.$#" count: 1 @@ -3263,66 +2623,16 @@ parameters: count: 3 path: tests/Drupal/Tests/Core/Entity/EntityFieldManagerTest.php - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Entity\\\\BasicForm\\:\\:buildForm\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Entity\\\\BasicForm\\:\\:getFormId\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Entity\\\\BasicFormNoContainerInjectionInterface\\:\\:buildForm\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Entity\\\\BasicFormNoContainerInjectionInterface\\:\\:getFormId\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Entity\\\\BasicFormNoUpcasting\\:\\:buildForm\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Entity\\\\BasicFormNoUpcasting\\:\\:getFormId\\(\\) should return string but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php - - message: "#^Call to an undefined method Drupal\\\\Tests\\\\Core\\\\Entity\\\\EntityTypeBundleInfoTest\\:\\:get\\(\\)\\.$#" count: 1 path: tests/Drupal/Tests/Core/Entity/EntityTypeBundleInfoTest.php - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Entity\\\\FieldDefinitionTest\\:\\:initializeFieldUsingFactory\\(\\) should return Drupal\\\\Core\\\\Field\\\\FieldDefinition but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Entity/FieldDefinitionTest.php - - message: "#^Cannot unset offset 'data\\-drupal\\-link…' on array\\{data\\-drupal\\-link\\-system\\-path\\: '\\'\\}\\.$#" count: 2 path: tests/Drupal/Tests/Core/EventSubscriber/ActiveLinkResponseFilterTest.php - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Form\\\\PrepareCallbackTestForm\\:\\:buildForm\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Form/FormStateTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Image\\\\ImageTest\\:\\:getTestImage\\(\\) should return Drupal\\\\Core\\\\Image\\\\Image but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Image/ImageTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Image\\\\ImageTest\\:\\:getTestImageForOperation\\(\\) should return Drupal\\\\Core\\\\Image\\\\Image but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Image/ImageTest.php - - message: "#^Call to method getDefinitions\\(\\) on an unknown class Drupal\\\\Core\\\\Plugin\\\\CategorizingPluginManagerTrait\\.$#" count: 3 @@ -3333,11 +2643,6 @@ parameters: count: 1 path: tests/Drupal/Tests/Core/Plugin/CategorizingPluginManagerTraitTest.php - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Plugin\\\\LazyPluginCollectionTestBase\\:\\:returnPluginMap\\(\\) should return Drupal\\\\Component\\\\Plugin\\\\PluginInspectionInterface\\|PHPUnit\\\\Framework\\\\MockObject\\\\MockObject but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Plugin/LazyPluginCollectionTestBase.php - - message: "#^\\#access_callback callback class '\\$this\\(Drupal\\\\Tests\\\\Core\\\\Render\\\\RendererCallbackTest\\)' at key '0' does not implement Drupal\\\\Core\\\\Security\\\\TrustedCallbackInterface\\.$#" count: 1 @@ -3432,28 +2737,3 @@ parameters: message: "#^Call to an undefined method Drupal\\\\Tests\\\\Core\\\\Test\\\\TestClass\\:\\:fail\\(\\)\\.$#" count: 3 path: tests/Drupal/Tests/Core/Test/AssertContentTraitTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Test\\\\TestClass\\:\\:assertEscaped\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Test/AssertContentTraitTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Test\\\\TestClass\\:\\:assertNoEscaped\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Test/AssertContentTraitTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Test\\\\TestClass\\:\\:assertNoRaw\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Test/AssertContentTraitTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Test\\\\TestClass\\:\\:assertRaw\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Test/AssertContentTraitTest.php - - - - message: "#^Method Drupal\\\\Tests\\\\Core\\\\Test\\\\TestClass\\:\\:assertTextHelper\\(\\) should return bool but return statement is missing\\.$#" - count: 1 - path: tests/Drupal/Tests/Core/Test/AssertContentTraitTest.php diff --git a/core/tests/Drupal/FunctionalTests/Rest/BaseFieldOverrideResourceTestBase.php b/core/tests/Drupal/FunctionalTests/Rest/BaseFieldOverrideResourceTestBase.php index 8e729b90fc8..4bd2f5aa1b6 100644 --- a/core/tests/Drupal/FunctionalTests/Rest/BaseFieldOverrideResourceTestBase.php +++ b/core/tests/Drupal/FunctionalTests/Rest/BaseFieldOverrideResourceTestBase.php @@ -86,6 +86,7 @@ abstract class BaseFieldOverrideResourceTestBase extends ConfigEntityResourceTes */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/tests/Drupal/FunctionalTests/Rest/DateFormatResourceTestBase.php b/core/tests/Drupal/FunctionalTests/Rest/DateFormatResourceTestBase.php index 73fb238d2f2..0ae1c2fb3c4 100644 --- a/core/tests/Drupal/FunctionalTests/Rest/DateFormatResourceTestBase.php +++ b/core/tests/Drupal/FunctionalTests/Rest/DateFormatResourceTestBase.php @@ -71,6 +71,7 @@ abstract class DateFormatResourceTestBase extends ConfigEntityResourceTestBase { */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/tests/Drupal/FunctionalTests/Rest/EntityFormDisplayResourceTestBase.php b/core/tests/Drupal/FunctionalTests/Rest/EntityFormDisplayResourceTestBase.php index 44f2e6ab22a..65c925320e2 100644 --- a/core/tests/Drupal/FunctionalTests/Rest/EntityFormDisplayResourceTestBase.php +++ b/core/tests/Drupal/FunctionalTests/Rest/EntityFormDisplayResourceTestBase.php @@ -137,6 +137,7 @@ abstract class EntityFormDisplayResourceTestBase extends ConfigEntityResourceTes */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/tests/Drupal/FunctionalTests/Rest/EntityFormModeResourceTestBase.php b/core/tests/Drupal/FunctionalTests/Rest/EntityFormModeResourceTestBase.php index cb367bcde73..93d734a7d8e 100644 --- a/core/tests/Drupal/FunctionalTests/Rest/EntityFormModeResourceTestBase.php +++ b/core/tests/Drupal/FunctionalTests/Rest/EntityFormModeResourceTestBase.php @@ -69,6 +69,7 @@ abstract class EntityFormModeResourceTestBase extends ConfigEntityResourceTestBa */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/tests/Drupal/FunctionalTests/Rest/EntityViewDisplayResourceTestBase.php b/core/tests/Drupal/FunctionalTests/Rest/EntityViewDisplayResourceTestBase.php index cea9928f534..51e1f2a8eba 100644 --- a/core/tests/Drupal/FunctionalTests/Rest/EntityViewDisplayResourceTestBase.php +++ b/core/tests/Drupal/FunctionalTests/Rest/EntityViewDisplayResourceTestBase.php @@ -95,6 +95,7 @@ abstract class EntityViewDisplayResourceTestBase extends ConfigEntityResourceTes */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } /** diff --git a/core/tests/Drupal/FunctionalTests/Rest/EntityViewModeResourceTestBase.php b/core/tests/Drupal/FunctionalTests/Rest/EntityViewModeResourceTestBase.php index 35777e02c74..86876e5b6f4 100644 --- a/core/tests/Drupal/FunctionalTests/Rest/EntityViewModeResourceTestBase.php +++ b/core/tests/Drupal/FunctionalTests/Rest/EntityViewModeResourceTestBase.php @@ -69,6 +69,7 @@ abstract class EntityViewModeResourceTestBase extends ConfigEntityResourceTestBa */ protected function getNormalizedPostEntity() { // @todo Update in https://www.drupal.org/node/2300677. + return []; } } diff --git a/core/tests/Drupal/KernelTests/AssertContentTrait.php b/core/tests/Drupal/KernelTests/AssertContentTrait.php index 73f427da598..739c62301d5 100644 --- a/core/tests/Drupal/KernelTests/AssertContentTrait.php +++ b/core/tests/Drupal/KernelTests/AssertContentTrait.php @@ -429,11 +429,8 @@ trait AssertContentTrait { * in test output. Use 'Debug' to indicate this is debugging output. Do not * translate this string. Defaults to 'Other'; most tests do not override * this default. - * - * @return bool - * TRUE on pass, FALSE on fail. */ - protected function assertRaw($raw, $message = '', $group = 'Other') { + protected function assertRaw($raw, $message = '', $group = 'Other'): void { if (!$message) { $message = 'Raw "' . Html::escape($raw) . '" found'; } @@ -457,11 +454,8 @@ trait AssertContentTrait { * in test output. Use 'Debug' to indicate this is debugging output. Do not * translate this string. Defaults to 'Other'; most tests do not override * this default. - * - * @return bool - * TRUE on pass, FALSE on fail. */ - protected function assertNoRaw($raw, $message = '', $group = 'Other') { + protected function assertNoRaw($raw, $message = '', $group = 'Other'): void { if (!$message) { $message = 'Raw "' . Html::escape($raw) . '" not found'; } @@ -485,11 +479,8 @@ trait AssertContentTrait { * in test output. Use 'Debug' to indicate this is debugging output. Do not * translate this string. Defaults to 'Other'; most tests do not override * this default. - * - * @return bool - * TRUE on pass, FALSE on fail. */ - protected function assertEscaped($raw, $message = '', $group = 'Other') { + protected function assertEscaped($raw, $message = '', $group = 'Other'): void { if (!$message) { $message = 'Escaped "' . Html::escape($raw) . '" found'; } @@ -514,11 +505,8 @@ trait AssertContentTrait { * in test output. Use 'Debug' to indicate this is debugging output. Do not * translate this string. Defaults to 'Other'; most tests do not override * this default. - * - * @return bool - * TRUE on pass, FALSE on fail. */ - protected function assertNoEscaped($raw, $message = '', $group = 'Other') { + protected function assertNoEscaped($raw, $message = '', $group = 'Other'): void { if (!$message) { $message = 'Escaped "' . Html::escape($raw) . '" not found'; } @@ -544,13 +532,10 @@ trait AssertContentTrait { * translate this string. Defaults to 'Other'; most tests do not override * this default. * - * @return bool - * TRUE on pass, FALSE on fail. - * * @see \Drupal\simpletest\AssertContentTrait::assertRaw() */ - protected function assertText($text, $message = '', $group = 'Other') { - return $this->assertTextHelper($text, $message, $group, FALSE); + protected function assertText($text, $message = '', $group = 'Other'): void { + $this->assertTextHelper($text, $message, $group, FALSE); } /** @@ -572,13 +557,10 @@ trait AssertContentTrait { * translate this string. Defaults to 'Other'; most tests do not override * this default. * - * @return bool - * TRUE on pass, FALSE on fail. - * * @see \Drupal\simpletest\AssertContentTrait::assertNoRaw() */ - protected function assertNoText($text, $message = '', $group = 'Other') { - return $this->assertTextHelper($text, $message, $group, TRUE); + protected function assertNoText($text, $message = '', $group = 'Other'): void { + $this->assertTextHelper($text, $message, $group, TRUE); } /** @@ -601,11 +583,8 @@ trait AssertContentTrait { * @param bool $not_exists * (optional) TRUE if this text should not exist, FALSE if it should. * Defaults to TRUE. - * - * @return bool - * TRUE on pass, FALSE on fail. */ - protected function assertTextHelper($text, $message = '', $group = 'Other', $not_exists = TRUE) { + protected function assertTextHelper($text, $message = '', $group = 'Other', $not_exists = TRUE): void { if (!$message) { $message = !$not_exists ? new FormattableMarkup('"@text" found', ['@text' => $text]) : new FormattableMarkup('"@text" not found', ['@text' => $text]); } diff --git a/core/tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php b/core/tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php index 4b66ca8c394..829d2dfa9a0 100644 --- a/core/tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php +++ b/core/tests/Drupal/Tests/Core/Entity/EntityResolverManagerTest.php @@ -515,12 +515,14 @@ class BasicForm extends FormBase { * {@inheritdoc} */ public function getFormId() { + return ''; } /** * {@inheritdoc} */ public function buildForm(array $form, FormStateInterface $form_state, EntityInterface $entity_test = NULL) { + return []; } /** @@ -540,12 +542,14 @@ class BasicFormNoUpcasting extends FormBase { * {@inheritdoc} */ public function getFormId() { + return ''; } /** * {@inheritdoc} */ public function buildForm(array $form, FormStateInterface $form_state, $entity_test = NULL) { + return []; } /** @@ -562,12 +566,14 @@ class BasicFormNoContainerInjectionInterface implements FormInterface { * {@inheritdoc} */ public function getFormId() { + return ''; } /** * {@inheritdoc} */ public function buildForm(array $form, FormStateInterface $form_state, EntityInterface $entity_test = NULL) { + return []; } /** diff --git a/core/tests/Drupal/Tests/Core/Entity/FieldDefinitionTest.php b/core/tests/Drupal/Tests/Core/Entity/FieldDefinitionTest.php index 7f1e27289de..a857c6f2534 100644 --- a/core/tests/Drupal/Tests/Core/Entity/FieldDefinitionTest.php +++ b/core/tests/Drupal/Tests/Core/Entity/FieldDefinitionTest.php @@ -385,6 +385,7 @@ class FieldDefinitionTest extends UnitTestCase { $definition->setFieldStorageDefinition($this->storageDefinition); return $definition; } + throw new \InvalidArgumentException("Invalid factory name '$factory_name' passed to " . __METHOD__); } } diff --git a/core/tests/Drupal/Tests/Core/Form/FormStateTest.php b/core/tests/Drupal/Tests/Core/Form/FormStateTest.php index 9e8d552e0c3..e553d887cd9 100644 --- a/core/tests/Drupal/Tests/Core/Form/FormStateTest.php +++ b/core/tests/Drupal/Tests/Core/Form/FormStateTest.php @@ -441,7 +441,9 @@ class PrepareCallbackTestForm implements FormInterface { return 'test_form'; } - public function buildForm(array $form, FormStateInterface $form_state) {} + public function buildForm(array $form, FormStateInterface $form_state) { + return []; + } public function validateForm(array &$form, FormStateInterface $form_state) {} diff --git a/core/tests/Drupal/Tests/Core/Image/ImageTest.php b/core/tests/Drupal/Tests/Core/Image/ImageTest.php index b2d96361292..e0a15e2a826 100644 --- a/core/tests/Drupal/Tests/Core/Image/ImageTest.php +++ b/core/tests/Drupal/Tests/Core/Image/ImageTest.php @@ -116,6 +116,8 @@ class ImageTest extends UnitTestCase { } $this->image = new Image($this->toolkit, $this->source); + + return $this->image; } /** @@ -140,6 +142,8 @@ class ImageTest extends UnitTestCase { ->will($this->returnValue($this->toolkitOperation)); $this->image = new Image($this->toolkit, $this->source); + + return $this->image; } /** diff --git a/core/tests/Drupal/Tests/Core/Plugin/LazyPluginCollectionTestBase.php b/core/tests/Drupal/Tests/Core/Plugin/LazyPluginCollectionTestBase.php index a3dec70ad6a..5d363f280e4 100644 --- a/core/tests/Drupal/Tests/Core/Plugin/LazyPluginCollectionTestBase.php +++ b/core/tests/Drupal/Tests/Core/Plugin/LazyPluginCollectionTestBase.php @@ -86,9 +86,7 @@ abstract class LazyPluginCollectionTestBase extends UnitTestCase { * The mock plugin object. */ public function returnPluginMap($plugin_id) { - if (isset($this->pluginInstances[$plugin_id])) { - return $this->pluginInstances[$plugin_id]; - } + return $this->pluginInstances[$plugin_id]; } /**