From 36e082ba9165d6583ccbf64fd5441ddc3986693b Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Tue, 11 Aug 2009 20:18:28 +0000 Subject: [PATCH] - Patch #541686 by catch: unnecessary query in block_page_alter(). --- modules/block/block.module | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/modules/block/block.module b/modules/block/block.module index 48171affa65..91f71211bdd 100644 --- a/modules/block/block.module +++ b/modules/block/block.module @@ -237,7 +237,6 @@ function block_page_alter($page) { // Populate all block regions $all_regions = system_region_list($theme); - $visible_regions = system_region_list($theme, REGIONS_VISIBLE); // Load all region content assigned via blocks. foreach (array_keys($all_regions) as $region) { @@ -250,12 +249,15 @@ function block_page_alter($page) { // Append region description if we are rendering the block admin page. $item = menu_get_item(); - if ($item['path'] == 'admin/structure/block' && isset($visible_regions[$region])) { - $description = '
' . $all_regions[$region] . '
'; - $page[$region]['block_description'] = array( - '#markup' => $description, - '#weight' => 15, - ); + if ($item['path'] == 'admin/structure/block') { + $visible_regions = system_region_list($theme, REGIONS_VISIBLE); + if (isset($visible_regions[$region])) { + $description = '
' . $all_regions[$region] . '
'; + $page[$region]['block_description'] = array( + '#markup' => $description, + '#weight' => 15, + ); + } } } }