Issue #3270434 by Spokje, dww, longwave, catch, smustgrave: Mark Quick Edit deprecated

(cherry picked from commit 6379200236)

core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/BasicStringFormatter.php

@@ -14,9 +14,6 @@ use Drupal\Core\Field\FieldItemListInterface;
  *   field_types = {
  *     "string_long",
  *     "email"
- *   },
- *   quickedit = {
- *     "editor" = "plain_text"
  *   }
  * )
  */

core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/StringFormatter.php

@@ -20,9 +20,6 @@ use Symfony\Component\DependencyInjection\ContainerInterface;
  *   field_types = {
  *     "string",
  *     "uri",
- *   },
- *   quickedit = {
- *     "editor" = "plain_text"
  *   }
  * )
  */

core/modules/quickedit/quickedit.info.yml

@@ -1,6 +1,8 @@
 name: Quick Edit
 type: module
 description: 'In-place content editing.'
+lifecycle: deprecated
+lifecycle_link: https://www.drupal.org/node/3223395#s-quick-edit
 package: Core
 version: VERSION
 dependencies:

core/modules/quickedit/quickedit.module

@@ -125,6 +125,9 @@ function quickedit_field_formatter_info_alter(&$info) {
     }
   }
 
+  $info['basic_string']['quickedit'] = ['editor' => 'plain_text'];
+  $info['string']['quickedit'] = ['editor' => 'plain_text'];
+
   // Update \Drupal\text\Plugin\Field\FieldFormatter\TextDefaultFormatter's
   // annotation to indicate that it supports the 'editor' in-place editor
   // provided by this module, if enabled.

core/modules/quickedit/tests/src/Functional/EditorIntegrationLoadingTest.php

@@ -11,6 +11,7 @@ use Drupal\Tests\BrowserTestBase;
  * Tests Quick Edit module integration endpoints.
  *
  * @group quickedit
+ * @group legacy
  */
 class EditorIntegrationLoadingTest extends BrowserTestBase {
 

core/modules/quickedit/tests/src/Functional/Jsonapi/QuickEditLayoutBuilderEntityViewDisplayTest.php

@@ -10,6 +10,7 @@ use Drupal\Tests\layout_builder\Functional\Jsonapi\LayoutBuilderEntityViewDispla
  * @group jsonapi
  * @group layout_builder
  * @group quickedit
+ * @group legacy
  */
 class QuickEditLayoutBuilderEntityViewDisplayTest extends LayoutBuilderEntityViewDisplayTest {
 

core/modules/quickedit/tests/src/Functional/LayoutBuilderQuickEditTest.php

@@ -9,6 +9,7 @@ use Drupal\Tests\BrowserTestBase;
  * Tests Layout Builder integration with Quick Edit.
  *
  * @group quickedit
+ * @group legacy
  */
 class LayoutBuilderQuickEditTest extends BrowserTestBase {
 

core/modules/quickedit/tests/src/Functional/QuickEditCustomPipelineTest.php

@@ -10,6 +10,7 @@ use Drupal\Tests\BrowserTestBase;
  * Tests using a custom pipeline with Quick Edit.
  *
  * @group quickedit
+ * @group legacy
  */
 class QuickEditCustomPipelineTest extends BrowserTestBase {
 

core/modules/quickedit/tests/src/Functional/QuickEditEndPointAccessTest.php

@@ -11,6 +11,7 @@ use GuzzleHttp\RequestOptions;
  * Tests accessing the Quick Edit endpoints.
  *
  * @group quickedit
+ * @group legacy
  */
 class QuickEditEndPointAccessTest extends BrowserTestBase {
 

core/modules/quickedit/tests/src/Functional/QuickEditImageControllerTest.php

@@ -11,6 +11,7 @@ use Drupal\Tests\TestFileCreationTrait;
  * Tests the endpoints used by the "image" in-place editor.
  *
  * @group quickedit
+ * @group legacy
  */
 class QuickEditImageControllerTest extends BrowserTestBase {
 

core/modules/quickedit/tests/src/Functional/QuickEditMinimalTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\BrowserTestBase;
  * Tests Quick Edit can be installed with Minimal.
  *
  * @group quickedit
+ * @group legacy
  */
 class QuickEditMinimalTest extends BrowserTestBase {
 

core/modules/quickedit/tests/src/Functional/Rest/QuickEditLayoutBuilderEntityViewDisplayJsonAnonTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\layout_builder\Functional\Rest\LayoutBuilderEntityViewDisplayJs
  * @group quickedit
  * @group layout_builder
  * @group rest
+ * @group legacy
  */
 class QuickEditLayoutBuilderEntityViewDisplayJsonAnonTest extends LayoutBuilderEntityViewDisplayJsonAnonTest {
 

core/modules/quickedit/tests/src/Functional/Rest/QuickEditLayoutBuilderEntityViewDisplayJsonBasicAuthTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\layout_builder\Functional\Rest\LayoutBuilderEntityViewDisplayJs
  * @group quickedit
  * @group layout_builder
  * @group rest
+ * @group legacy
  */
 class QuickEditLayoutBuilderEntityViewDisplayJsonBasicAuthTest extends LayoutBuilderEntityViewDisplayJsonBasicAuthTest {
 

core/modules/quickedit/tests/src/Functional/Rest/QuickEditLayoutBuilderEntityViewDisplayJsonCookieTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\layout_builder\Functional\Rest\LayoutBuilderEntityViewDisplayJs
  * @group quickedit
  * @group layout_builder
  * @group rest
+ * @group legacy
  */
 class QuickEditLayoutBuilderEntityViewDisplayJsonCookieTest extends LayoutBuilderEntityViewDisplayJsonCookieTest {
 

core/modules/quickedit/tests/src/Functional/Rest/QuickEditLayoutBuilderEntityViewDisplayXmlAnonTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\layout_builder\Functional\Rest\LayoutBuilderEntityViewDisplayXm
  * @group quickedit
  * @group layout_builder
  * @group rest
+ * @group legacy
  */
 class QuickEditLayoutBuilderEntityViewDisplayXmlAnonTest extends LayoutBuilderEntityViewDisplayXmlAnonTest {
 

core/modules/quickedit/tests/src/Functional/Rest/QuickEditLayoutBuilderEntityViewDisplayXmlBasicAuthTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\layout_builder\Functional\Rest\LayoutBuilderEntityViewDisplayXm
  * @group quickedit
  * @group layout_builder
  * @group rest
+ * @group legacy
  */
 class QuickEditLayoutBuilderEntityViewDisplayXmlBasicAuthTest extends LayoutBuilderEntityViewDisplayXmlBasicAuthTest {
 

core/modules/quickedit/tests/src/Functional/Rest/QuickEditLayoutBuilderEntityViewDisplayXmlCookieTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\layout_builder\Functional\Rest\LayoutBuilderEntityViewDisplayXm
  * @group quickedit
  * @group layout_builder
  * @group rest
+ * @group legacy
  */
 class QuickEditLayoutBuilderEntityViewDisplayXmlCookieTest extends LayoutBuilderEntityViewDisplayXmlCookieTest {
 

core/modules/quickedit/tests/src/FunctionalJavascript/CKEditor5IntegrationTest.php

@@ -12,6 +12,7 @@ use Symfony\Component\Validator\ConstraintViolation;
  * Tests that Quick Edit can load CKEditor 5.
  *
  * @group quickedit
+ * @group legacy
  * @internal
  */
 class CKEditor5IntegrationTest extends QuickEditJavascriptTestBase {

core/modules/quickedit/tests/src/FunctionalJavascript/FieldTest.php

@@ -13,6 +13,7 @@ use Drupal\Tests\contextual\FunctionalJavascript\ContextualLinkClickTrait;
  * Tests quickedit.
  *
  * @group quickedit
+ * @group legacy
  */
 class FieldTest extends WebDriverTestBase {
 

core/modules/quickedit/tests/src/FunctionalJavascript/InlineFormErrorsIntegrationTest.php

@@ -9,6 +9,7 @@ use Drupal\node\Entity\NodeType;
  * Tests Inline Form Errors compatibility with Quick Edit.
  *
  * @group quickedit
+ * @group legacy
  */
 class InlineFormErrorsIntegrationTest extends WebDriverTestBase {
 

core/modules/quickedit/tests/src/FunctionalJavascript/LayoutBuilderIntegrationTest.php

@@ -13,6 +13,7 @@ use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
 
 /**
  * @group quickedit
+ * @group legacy
  */
 class LayoutBuilderIntegrationTest extends QuickEditJavascriptTestBase {
 

core/modules/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php

@@ -13,6 +13,7 @@ use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
  * @covers layout_builder_quickedit_render_field()
  *
  * @group quickedit
+ * @group legacy
  */
 class LayoutBuilderQuickEditTest extends QuickEditJavascriptTestBase {
 

core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditAutocompleteTermTest.php

@@ -14,6 +14,7 @@ use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
  * Tests in-place editing of autocomplete tags.
  *
  * @group quickedit
+ * @group legacy
  */
 class QuickEditAutocompleteTermTest extends WebDriverTestBase {
 

core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditFileTest.php

@@ -10,6 +10,7 @@ use Drupal\Tests\TestFileCreationTrait;
 
 /**
  * @group quickedit
+ * @group legacy
  */
 class QuickEditFileTest extends QuickEditJavascriptTestBase {
 

core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditImageTest.php

@@ -9,6 +9,7 @@ use Drupal\Tests\TestFileCreationTrait;
 /**
  * @coversDefaultClass \Drupal\quickedit\Plugin\InPlaceEditor\Image
  * @group quickedit
+ * @group legacy
  */
 class QuickEditImageTest extends QuickEditJavascriptTestBase {
 

core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditLoadingTest.php

@@ -19,6 +19,7 @@ use Drupal\Tests\TestFileCreationTrait;
  * in-place editors.
  *
  * @group quickedit
+ * @group legacy
  */
 class QuickEditLoadingTest extends WebDriverTestBase {
 

core/modules/quickedit/tests/src/FunctionalJavascript/SettingsTrayIntegrationTest.php

@@ -11,6 +11,7 @@ use Drupal\user\Entity\Role;
  * Test Settings Tray and Quick Edit modules integration.
  *
  * @group quickedit
+ * @group legacy
  */
 class SettingsTrayIntegrationTest extends SettingsTrayTestBase {
 

core/modules/quickedit/tests/src/Kernel/EditorSelectionTest.php

@@ -9,6 +9,7 @@ use Drupal\quickedit\EditorSelector;
  * Tests in-place field editor selection.
  *
  * @group quickedit
+ * @group legacy
  */
 class EditorSelectionTest extends QuickEditTestBase {
 

core/modules/quickedit/tests/src/Kernel/MediaEmbedFilterDisabledIntegrationsTest.php

@@ -9,6 +9,7 @@ use Drupal\Tests\media\Kernel\MediaEmbedFilterTestBase;
  *
  * @coversDefaultClass \Drupal\media\Plugin\Filter\MediaEmbed
  * @group quickedit
+ * @group legacy
  */
 class MediaEmbedFilterDisabledIntegrationsTest extends MediaEmbedFilterTestBase {
 

core/modules/quickedit/tests/src/Kernel/MetadataGeneratorTest.php

@@ -12,6 +12,7 @@ use Drupal\filter\Entity\FilterFormat;
  * Tests in-place field editing metadata.
  *
  * @group quickedit
+ * @group legacy
  */
 class MetadataGeneratorTest extends QuickEditTestBase {
 

core/modules/quickedit/tests/src/Kernel/QuickEditLoadingTest.php

@@ -13,6 +13,7 @@ use Drupal\Tests\user\Traits\UserCreationTrait;
  * in-place editors.
  *
  * @group quickedit
+ * @group legacy
  */
 class QuickEditLoadingTest extends KernelTestBase {
 

core/modules/quickedit/tests/src/Unit/Access/QuickEditEntityFieldAccessCheckTest.php

@@ -13,6 +13,7 @@ use Drupal\Core\Language\LanguageInterface;
  * @coversDefaultClass \Drupal\quickedit\Access\QuickEditEntityFieldAccessCheck
  * @group Access
  * @group quickedit
+ * @group legacy
  */
 class QuickEditEntityFieldAccessCheckTest extends UnitTestCase {