Issue #3267513 by quietone, andregp, danflanagan8: Handle migration tests for removing RDF

core/.cspell.json

@@ -20,6 +20,7 @@
       "modules/media/tests/fixtures/oembed/*",
       "modules/migrate_drupal/tests/fixtures/drupal6.php",
       "modules/migrate_drupal/tests/fixtures/drupal7.php",
+      "modules/rdf/tests/fixtures/drupal7.php",
       "modules/search/tests/UnicodeTest.txt",
       "modules/system/tests/logo.svgz",
       "node_modules/*",

core/modules/migrate_drupal/tests/src/Kernel/StateFileExistsTest.php

@@ -65,6 +65,7 @@ class StateFileExistsTest extends MigrateDrupalTestBase {
     'node',
     'options',
     'path',
+    // @todo Remove RDF in https://www.drupal.org/node/3267515
     'rdf',
     'responsive_image',
     'search',

core/modules/migrate_drupal_ui/tests/src/Functional/d6/Upgrade6Test.php

@@ -53,6 +53,9 @@ class Upgrade6Test extends MigrateUpgradeExecuteTestBase {
     $this->nodeStorage->delete($this->nodeStorage->loadMultiple());
 
     $this->loadFixture($this->getModulePath('migrate_drupal') . '/tests/fixtures/drupal6.php');
+
+    // @todo Remove this in https://www.drupal.org/node/3267515
+    \Drupal::service('module_installer')->uninstall(['rdf']);
   }
 
   /**
@@ -88,7 +91,6 @@ class Upgrade6Test extends MigrateUpgradeExecuteTestBase {
       // The 'book' module provides the 'book' node type, and the migration
       // creates 12 node types.
       'node_type' => 14,
-      'rdf_mapping' => 7,
       'search_page' => 2,
       'shortcut' => 2,
       'shortcut_set' => 1,

core/modules/migrate_drupal_ui/tests/src/Functional/d7/MultilingualReviewPageTest.php

@@ -41,6 +41,9 @@ class MultilingualReviewPageTest extends MultilingualReviewPageTestBase {
   protected function setUp(): void {
     parent::setUp();
     $this->loadFixture($this->getModulePath('migrate_drupal') . '/tests/fixtures/drupal7.php');
+
+    // @todo Remove this in https://www.drupal.org/node/3267515
+    \Drupal::service('module_installer')->uninstall(['rdf']);
   }
 
   /**
@@ -114,7 +117,6 @@ class MultilingualReviewPageTest extends MultilingualReviewPageTestBase {
       'Phone',
       'Poll',
       'Profile',
-      'RDF',
       'Search',
       'Search embedded form',
       'Shortcut',
@@ -168,6 +170,7 @@ class MultilingualReviewPageTest extends MultilingualReviewPageTestBase {
       'Options',
       'Path translation',
       'Picture',
+      'RDF',
       'References',
       'References UUID',
       'Translation redirect',

core/modules/migrate_drupal_ui/tests/src/Functional/d7/NoMultilingualReviewPageTest.php

@@ -37,6 +37,9 @@ class NoMultilingualReviewPageTest extends NoMultilingualReviewPageTestBase {
   protected function setUp(): void {
     parent::setUp();
     $this->loadFixture($this->getModulePath('migrate_drupal') . '/tests/fixtures/drupal7.php');
+
+    // @todo Remove this in https://www.drupal.org/node/3267515
+    \Drupal::service('module_installer')->uninstall(['rdf']);
   }
 
   /**
@@ -105,7 +108,6 @@ class NoMultilingualReviewPageTest extends NoMultilingualReviewPageTestBase {
       'Phone',
       'Poll',
       'Profile',
-      'RDF',
       'Search',
       'Search embedded form',
       'Shortcut',
@@ -166,6 +168,7 @@ class NoMultilingualReviewPageTest extends NoMultilingualReviewPageTestBase {
       'Multilingual select',
       'Path translation',
       'Picture',
+      'RDF',
       'References',
       'References UUID',
       'Translation redirect',

core/modules/migrate_drupal_ui/tests/src/Functional/d7/Upgrade7Test.php

@@ -56,6 +56,9 @@ class Upgrade7Test extends MigrateUpgradeExecuteTestBase {
     $this->nodeStorage->delete($this->nodeStorage->loadMultiple());
 
     $this->loadFixture($this->getModulePath('migrate_drupal') . '/tests/fixtures/drupal7.php');
+
+    // @todo Remove this in https://www.drupal.org/node/3267515
+    \Drupal::service('module_installer')->uninstall(['rdf']);
   }
 
   /**
@@ -91,7 +94,6 @@ class Upgrade7Test extends MigrateUpgradeExecuteTestBase {
       'language_content_settings' => 24,
       'node' => 7,
       'node_type' => 8,
-      'rdf_mapping' => 8,
       'search_page' => 2,
       'shortcut' => 6,
       'shortcut_set' => 2,
@@ -169,7 +171,6 @@ class Upgrade7Test extends MigrateUpgradeExecuteTestBase {
       'Options',
       'Path',
       'Phone',
-      'RDF',
       'Search',
       'Shortcut',
       'Statistics',
@@ -205,6 +206,8 @@ class Upgrade7Test extends MigrateUpgradeExecuteTestBase {
   protected function getMissingPaths() {
     return [
       'Aggregator',
+      // @todo Remove RDF in https://www.drupal.org/node/3267515
+      'RDF',
       'References',
       'Translation sets',
       'Variable realm',

core/modules/rdf/tests/src/Functional/Migrate/NoMultilingualReviewPageTest.php

@@ -0,0 +1,76 @@
+<?php
+
+namespace Drupal\Tests\rdf\Functional\Migrate;
+
+use Drupal\Tests\migrate_drupal_ui\Functional\NoMultilingualReviewPageTestBase;
+
+/**
+ * Tests review page.
+ *
+ * The test method is provided by the MigrateUpgradeTestBase class.
+ *
+ * @group rdf
+ */
+class NoMultilingualReviewPageTest extends NoMultilingualReviewPageTestBase {
+
+  /**
+   * {@inheritdoc}
+   */
+  protected static $modules = [
+    'rdf',
+  ];
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp(): void {
+    parent::setUp();
+    $this->loadFixture($this->getModulePath('rdf') . '/tests/fixtures/drupal7.php');
+  }
+
+  /**
+   * Tests that RDF is displayed in the will be upgraded list.
+   */
+  public function testMigrateUpgradeReviewPage() {
+    $this->prepare();
+    // Start the upgrade process.
+    $this->submitCredentialForm();
+
+    $session = $this->assertSession();
+    $this->submitForm([], 'I acknowledge I may lose data. Continue anyway.');
+    $session->statusCodeEquals(200);
+
+    // Confirm that RDF will be upgraded.
+    $session->elementExists('xpath', "//td[contains(@class, 'checked') and text() = 'RDF']");
+    $session->elementNotExists('xpath', "//td[contains(@class, 'error') and text() = 'RDF']");
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getSourceBasePath() {
+    return __DIR__;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getAvailablePaths() {
+    return [];
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getIncompletePaths() {
+    return [];
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getMissingPaths() {
+    return [];
+  }
+
+}

core/modules/rdf/tests/src/Functional/Migrate/Upgrade7Test.php

@@ -0,0 +1,160 @@
+<?php
+
+namespace Drupal\Tests\rdf\Functional\Migrate;
+
+use Drupal\Tests\migrate_drupal_ui\Functional\MigrateUpgradeTestBase;
+
+/**
+ * Tests Drupal 7 upgrade using the migrate UI.
+ *
+ * The test method is provided by the MigrateUpgradeTestBase class.
+ *
+ * @group rdf
+ */
+class Upgrade7Test extends MigrateUpgradeTestBase {
+
+  /**
+   * {@inheritdoc}
+   */
+  protected static $modules = [
+    'rdf',
+    'migrate_drupal_ui',
+  ];
+
+  /**
+   * The entity storage for node.
+   *
+   * @var \Drupal\Core\Entity\EntityStorageInterface
+   */
+  protected $nodeStorage;
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp(): void {
+    parent::setUp();
+    $this->loadFixture($this->getModulePath('rdf') . '/tests/fixtures/drupal7.php');
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getSourceBasePath() {
+    return __DIR__;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getEntityCounts() {
+    return [
+      'action' => 21,
+      'base_field_override' => 2,
+      'block' => 30,
+      'block_content' => 0,
+      'block_content_type' => 1,
+      'comment' => 0,
+      'comment_type' => 5,
+      'contact_form' => 2,
+      'contact_message' => 0,
+      'date_format' => 11,
+      'editor' => 2,
+      'entity_form_display' => 11,
+      'entity_form_mode' => 1,
+      'entity_view_display' => 17,
+      'entity_view_mode' => 10,
+      'field_config' => 19,
+      'field_storage_config' => 12,
+      'file' => 0,
+      'filter_format' => 5,
+      'image_style' => 4,
+      'menu' => 5,
+      'menu_link_content' => 1,
+      'node' => 0,
+      'node_type' => 4,
+      'path_alias' => 0,
+      'rdf_mapping' => 8,
+      'search_page' => 2,
+      'shortcut' => 4,
+      'shortcut_set' => 1,
+      'taxonomy_term' => 1,
+      'taxonomy_vocabulary' => 2,
+      'tour' => 2,
+      'user' => 2,
+      'user_role' => 4,
+      'view' => 14,
+    ];
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getEntityCountsIncremental() {
+    return [];
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getAvailablePaths() {
+    return [
+      'Block',
+      'Blog',
+      'Color',
+      'Comment',
+      'Contextual links',
+      'Dashboard',
+      'Database logging',
+      'Field',
+      'Field SQL storage',
+      'Field UI',
+      'File',
+      'Filter',
+      'Help',
+      'Image',
+      'List',
+      'Menu',
+      'Node',
+      'Number',
+      'Options',
+      'Overlay',
+      'Path',
+      'RDF',
+      'Search',
+      'Shortcut',
+      'System',
+      'Taxonomy',
+      'Text',
+      'Toolbar',
+      'User',
+    ];
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getMissingPaths() {
+    return [
+      'Forum',
+    ];
+  }
+
+  /**
+   * Executes all steps of migrations upgrade.
+   */
+  public function testUpgrade() {
+    // Start the upgrade process.
+    $this->submitCredentialForm();
+    $session = $this->assertSession();
+
+    $this->submitForm([], 'I acknowledge I may lose data. Continue anyway.');
+    $session->statusCodeEquals(200);
+
+    // Test the review form.
+    $this->assertReviewForm();
+
+    $this->submitForm([], 'Perform upgrade');
+    $this->assertUpgrade($this->getEntityCounts());
+  }
+
+}

core/modules/rdf/tests/src/Kernel/Migrate/d7/MigrateRdfMappingTest.php

@@ -2,15 +2,15 @@
 
 namespace Drupal\Tests\rdf\Kernel\Migrate\d7;
 
+use Drupal\Tests\migrate_drupal\Kernel\MigrateDrupalTestBase;
 use Drupal\rdf\RdfMappingInterface;
-use Drupal\Tests\migrate_drupal\Kernel\d7\MigrateDrupal7TestBase;
 
 /**
  * Tests RDF mappings migration from Drupal 7 to 8.
  *
  * @group rdf
  */
-class MigrateRdfMappingTest extends MigrateDrupal7TestBase {
+class MigrateRdfMappingTest extends MigrateDrupalTestBase {
 
   /**
    * {@inheritdoc}
@@ -29,6 +29,7 @@ class MigrateRdfMappingTest extends MigrateDrupal7TestBase {
   protected function setUp(): void {
     parent::setUp();
 
+    $this->loadFixture(__DIR__ . '/../../../../fixtures/drupal7.php');
     $this->installConfig(static::$modules);
 
     $this->executeMigrations([