Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2387627 by olli: Changing access plugins in views leaves invalid settings around

8.0.x
Alex Pott 2014-12-15 17:15:04 +00:00
parent 000f3924f3
commit 2c214a7559
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/modules/user/src/Tests/Views/AccessRoleUITest.php
View File

@ -56,6 +56,14 @@ class AccessRoleUITest extends UITestBase {
$display = $view->getDisplay('default');
$this->assertEqual($display['display_options']['access']['options']['role'], array('custom_role' => 'custom_role'));
// Test changing access plugin from role to none.
$this->drupalPostForm('admin/structure/views/nojs/display/test_access_role/default/access', ['access[type]' => 'none'], t('Apply'));
$this->drupalPostForm(NULL, array(), t('Save'));
// Verify that role option is not set.
$view = $entity_manager->getStorage('view')->load('test_access_role');
$display = $view->getDisplay('default');
$this->assertFalse(isset($display['display_options']['access']['options']['role']));
}
}

2
core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
View File

@ -1994,6 +1994,7 @@ abstract class DisplayPluginBase extends PluginBase {
$plugin_options = $this->getOption($plugin_type);
$type = $form_state->getValue(array($plugin_type, 'type'));
if ($plugin_options['type'] != $type) {
/** @var \Drupal\views\Plugin\views\ViewsPluginInterface $plugin */
$plugin = Views::pluginManager($plugin_type)->createInstance($type);
if ($plugin) {
$plugin->init($this->view, $this, $plugin_options['options']);
@ -2001,6 +2002,7 @@ abstract class DisplayPluginBase extends PluginBase {
'type' => $type,
'options' => $plugin->options,
);
$plugin->filterByDefinedOptions($plugin_options['options']);
$this->setOption($plugin_type, $plugin_options);
if ($plugin->usesOptions()) {
$form_state->get('view')->addFormToStack('display', $this->display['id'], $plugin_type . '_options');