Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

- Patch #674626 by asimmonds: fixed text format filter list not being ordered correctly.

merge-requests/26/head
Dries Buytaert 2010-02-05 21:44:35 +00:00
parent 03d9f68161
commit 2acf463dfe
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/filter/filter.admin.inc
View File

@ -182,6 +182,7 @@ function filter_admin_format_form($form, &$form_state, $format) {
'#default_value' => $filters[$name]->weight,
'#parents' => array('filters', $name, 'weight'),
);
$form['filters']['order'][$name]['#weight'] = $filters[$name]->weight;
}
// Filter settings.

8
modules/filter/filter.test
View File

@ -231,6 +231,9 @@ class FilterAdminTestCase extends DrupalWebTestCase {
$result = db_query('SELECT * FROM {cache_filter}')->fetchObject();
$this->assertFalse($result, t('Cache cleared.'));
$elements = $this->xpath('//select[@name="filters[' . $first_filter . '][weight]"]/following::select[@name="filters[' . $second_filter . '][weight]"]');
$this->assertTrue(!empty($elements), t('Order confirmed in admin interface.'));
// Reorder filters.
$edit = array();
$edit['filters[' . $second_filter . '][weight]'] = 1;
@ -239,6 +242,9 @@ class FilterAdminTestCase extends DrupalWebTestCase {
$this->assertFieldByName('filters[' . $second_filter . '][weight]', 1, t('Order saved successfully.'));
$this->assertFieldByName('filters[' . $first_filter . '][weight]', 2, t('Order saved successfully.'));
$elements = $this->xpath('//select[@name="filters[' . $second_filter . '][weight]"]/following::select[@name="filters[' . $first_filter . '][weight]"]');
$this->assertTrue(!empty($elements), t('Reorder confirmed in admin interface.'));
$result = db_query('SELECT * FROM {filter} WHERE format = :format ORDER BY weight ASC', array(':format' => $filtered));
$filters = array();
foreach ($result as $filter) {
@ -246,7 +252,7 @@ class FilterAdminTestCase extends DrupalWebTestCase {
$filters[] = $filter;
}
}
$this->assertTrue(($filters[0]->name == $second_filter && $filters[1]->name == $first_filter), t('Order confirmed.'));
$this->assertTrue(($filters[0]->name == $second_filter && $filters[1]->name == $first_filter), t('Order confirmed in database.'));
// Add format.
$edit = array();