Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

- Patch #258397 by Dries: fixed spoofing attack.

merge-requests/26/head
Dries Buytaert 2008-07-04 22:54:09 +00:00
parent 1415340ce3
commit 2a34c23bc8
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
includes/bootstrap.inc
View File

@ -1175,22 +1175,25 @@ function ip_address($reset = false) {
if (!isset($ip_address) || $reset) { if (!isset($ip_address) || $reset) {
$ip_address = $_SERVER['REMOTE_ADDR']; $ip_address = $_SERVER['REMOTE_ADDR'];
if (variable_get('reverse_proxy', 0) && array_key_exists('HTTP_X_FORWARDED_FOR', $_SERVER)) {
// If an array of known reverse proxy IPs is provided, then trust if (variable_get('reverse_proxy', 0)) {
// the XFF header if request really comes from one of them. if (array_key_exists('HTTP_X_FORWARDED_FOR', $_SERVER)) {
$reverse_proxy_addresses = variable_get('reverse_proxy_addresses', array()); // If an array of known reverse proxy IPs is provided, then trust
if (!empty($reverse_proxy_addresses) && in_array($ip_address, $reverse_proxy_addresses, TRUE)) { // the XFF header if request really comes from one of them.
// If there are several arguments, we need to check the most $reverse_proxy_addresses = variable_get('reverse_proxy_addresses', array());
// recently added one, i.e. the last one. if (!empty($reverse_proxy_addresses) && in_array($ip_address, $reverse_proxy_addresses, TRUE)) {
$ip_address = array_pop(explode(',', $_SERVER['HTTP_X_FORWARDED_FOR'])); // If there are several arguments, we need to check the most
// recently added one, i.e. the last one.
$ip_address = array_pop(explode(',', $_SERVER['HTTP_X_FORWARDED_FOR']));
}
} }
}
// When Drupal is run in a cluster environment, REMOTE_ADDR contains the IP // When Drupal is run in a cluster environment, REMOTE_ADDR contains the IP
// address of a server in the cluster, while the IP address of the client is // address of a server in the cluster, while the IP address of the client is
// stored in HTTP_X_CLUSTER_CLIENT_IP. // stored in HTTP_X_CLUSTER_CLIENT_IP.
if (array_key_exists('HTTP_X_CLUSTER_CLIENT_IP', $_SERVER)) { if (array_key_exists('HTTP_X_CLUSTER_CLIENT_IP', $_SERVER)) {
$ip_address = $_SERVER['HTTP_X_CLUSTER_CLIENT_IP']; $ip_address = $_SERVER['HTTP_X_CLUSTER_CLIENT_IP'];
}
} }
} }