Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2971012 by Wim Leers, borisson_: ContentTypeHeaderMatcher should not run for DELETE requests

merge-requests/1654/head
Alex Pott 2018-05-07 17:16:26 +01:00
parent aeb5733c8a
commit 246a31c42f
No known key found for this signature in database
GPG Key ID: 31905460D4A69276
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/lib/Drupal/Core/Routing/ContentTypeHeaderMatcher.php
View File

@ -15,10 +15,10 @@ class ContentTypeHeaderMatcher implements FilterInterface {
* {@inheritdoc}
*/
public function filter(RouteCollection $collection, Request $request) {
// The Content-type header does not make sense on GET requests, because GET
// requests do not carry any content. Nothing to filter in this case. Same
// for all other safe methods.
if ($request->isMethodSafe(FALSE)) {
// The Content-type header does not make sense on GET or DELETE requests,
// because they do not carry any content. Nothing to filter in this case.
// Same for all other safe methods.
if ($request->isMethodSafe(FALSE) || $request->isMethod('DELETE')) {
return $collection;
}

1
core/tests/Drupal/Tests/Core/Routing/ContentTypeHeaderMatcherTest.php
View File

@ -61,6 +61,7 @@ class ContentTypeHeaderMatcherTest extends UnitTestCase {
['HEAD'],
['OPTIONS'],
['TRACE'],
['DELETE'],
];
}