Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2337897 by damiankloip: Fixed ManyToOne filter should not display ManyToOneHelper valueForm when exposed.

8.0.x
Alex Pott 2014-09-15 14:26:17 +01:00
parent f070288cce
commit 22c1362cb4
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/modules/user/src/Tests/UserAdminTest.php
View File

@ -55,6 +55,14 @@ class UserAdminTest extends WebTestBase {
$link = l(t('Edit'), "user/" . $user_a->id() . "/edit", array('query' => array('destination' => 'admin/people'))); $link = l(t('Edit'), "user/" . $user_a->id() . "/edit", array('query' => array('destination' => 'admin/people')));
$this->assertRaw($link, 'Found user A edit link on admin users page'); $this->assertRaw($link, 'Found user A edit link on admin users page');
// Test exposed filter elements.
foreach (array('user', 'role', 'permission', 'status') as $field) {
$this->assertField("edit-$field", "$field exposed filter found.");
}
// Make sure the reduce duplicates element from the ManyToOneHelper is not
// displayed.
$this->assertNoField('edit-reduce-duplicates', 'Reduce duplicates form element not found in exposed filters.');
// Filter the users by name/email. // Filter the users by name/email.
$this->drupalGet('admin/people', array('query' => array('user' => $user_a->getUsername()))); $this->drupalGet('admin/people', array('query' => array('user' => $user_a->getUsername())));
$result = $this->xpath('//table/tbody/tr'); $result = $this->xpath('//table/tbody/tr');

2
core/modules/views/src/Plugin/views/filter/ManyToOne.php
View File

@ -111,7 +111,7 @@ class ManyToOne extends InOperator {
protected function valueForm(&$form, FormStateInterface $form_state) { protected function valueForm(&$form, FormStateInterface $form_state) {
parent::valueForm($form, $form_state); parent::valueForm($form, $form_state);
if ($form_state->get('exposed')) { if (!$form_state->get('exposed')) {
$this->helper->buildOptionsForm($form, $form_state); $this->helper->buildOptionsForm($form, $form_state);
} }
} }