diff --git a/core/modules/basic_auth/src/Authentication/Provider/BasicAuth.php b/core/modules/basic_auth/src/Authentication/Provider/BasicAuth.php index 0e306a5b359..d67801cd4f3 100644 --- a/core/modules/basic_auth/src/Authentication/Provider/BasicAuth.php +++ b/core/modules/basic_auth/src/Authentication/Provider/BasicAuth.php @@ -10,6 +10,7 @@ use Drupal\Core\Config\ConfigFactoryInterface; use Drupal\Core\Entity\EntityTypeManagerInterface; use Drupal\Core\Flood\FloodInterface; use Drupal\Core\Http\Exception\CacheableUnauthorizedHttpException; +use Drupal\user\UserAuthenticationInterface; use Drupal\user\UserAuthInterface; use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException; @@ -29,7 +30,7 @@ class BasicAuth implements AuthenticationProviderInterface, AuthenticationProvid /** * The user auth service. * - * @var \Drupal\user\UserAuthInterface + * @var \Drupal\user\UserAuthInterface|\Drupal\user\UserAuthenticationInterface */ protected $userAuth; @@ -52,15 +53,18 @@ class BasicAuth implements AuthenticationProviderInterface, AuthenticationProvid * * @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory * The config factory. - * @param \Drupal\user\UserAuthInterface $user_auth + * @param \Drupal\user\UserAuthInterface|\Drupal\user\UserAuthenticationInterface $user_auth * The user authentication service. * @param \Drupal\Core\Flood\FloodInterface $flood * The flood service. * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager * The entity type manager service. */ - public function __construct(ConfigFactoryInterface $config_factory, UserAuthInterface $user_auth, FloodInterface $flood, EntityTypeManagerInterface $entity_type_manager) { + public function __construct(ConfigFactoryInterface $config_factory, UserAuthInterface|UserAuthenticationInterface $user_auth, FloodInterface $flood, EntityTypeManagerInterface $entity_type_manager) { $this->configFactory = $config_factory; + if (!$user_auth instanceof UserAuthenticationInterface) { + @trigger_error('The $user_auth parameter implementing UserAuthInterface is deprecated in drupal:10.3.0 and will be removed in drupal:12.0.0. Implement UserAuthenticationInterface instead. See https://www.drupal.org/node/3411040'); + } $this->userAuth = $user_auth; $this->flood = $flood; $this->entityTypeManager = $entity_type_manager; @@ -90,8 +94,17 @@ class BasicAuth implements AuthenticationProviderInterface, AuthenticationProvid // in to many different user accounts. We have a reasonably high limit // since there may be only one apparent IP for all users at an institution. if ($this->flood->isAllowed('basic_auth.failed_login_ip', $flood_config->get('ip_limit'), $flood_config->get('ip_window'))) { - $accounts = $this->entityTypeManager->getStorage('user')->loadByProperties(['name' => $username, 'status' => 1]); - $account = reset($accounts); + $account = FALSE; + if ($this->userAuth instanceof UserAuthenticationInterface) { + $lookup = $this->userAuth->lookupAccount($username); + if ($lookup && !$lookup->isBlocked()) { + $account = $lookup; + } + } + else { + $accounts = $this->entityTypeManager->getStorage('user')->loadByProperties(['name' => $username, 'status' => 1]); + $account = reset($accounts); + } if ($account) { if ($flood_config->get('uid_only')) { // Register flood events based on the uid only, so they apply for any @@ -107,10 +120,16 @@ class BasicAuth implements AuthenticationProviderInterface, AuthenticationProvid // Don't allow login if the limit for this user has been reached. // Default is to allow 5 failed attempts every 6 hours. if ($this->flood->isAllowed('basic_auth.failed_login_user', $flood_config->get('user_limit'), $flood_config->get('user_window'), $identifier)) { - $uid = $this->userAuth->authenticate($username, $password); + $uid = FALSE; + if ($this->userAuth instanceof UserAuthenticationInterface) { + $uid = $this->userAuth->authenticateAccount($account, $password) ? $account->id() : FALSE; + } + else { + $uid = $this->userAuth->authenticate($username, $password); + } if ($uid) { $this->flood->clear('basic_auth.failed_login_user', $identifier); - return $this->entityTypeManager->getStorage('user')->load($uid); + return $account; } else { // Register a per-user failed login event. diff --git a/core/modules/user/src/Controller/UserAuthenticationController.php b/core/modules/user/src/Controller/UserAuthenticationController.php index abab9a58566..7758b0d96d2 100644 --- a/core/modules/user/src/Controller/UserAuthenticationController.php +++ b/core/modules/user/src/Controller/UserAuthenticationController.php @@ -6,6 +6,7 @@ use Drupal\Core\Access\CsrfTokenGenerator; use Drupal\Core\Controller\ControllerBase; use Drupal\Core\DependencyInjection\ContainerInjectionInterface; use Drupal\Core\Routing\RouteProviderInterface; +use Drupal\user\UserAuthenticationInterface; use Drupal\user\UserAuthInterface; use Drupal\user\UserFloodControlInterface; use Drupal\user\UserInterface; @@ -61,8 +62,7 @@ class UserAuthenticationController extends ControllerBase implements ContainerIn /** * The user authentication. - * - * @var \Drupal\user\UserAuthInterface + * @var \Drupal\user\UserAuthInterface|\Drupal\user\UserAuthenticationInterface */ protected $userAuth; @@ -103,7 +103,7 @@ class UserAuthenticationController extends ControllerBase implements ContainerIn * The user storage. * @param \Drupal\Core\Access\CsrfTokenGenerator $csrf_token * The CSRF token generator. - * @param \Drupal\user\UserAuthInterface $user_auth + * @param \Drupal\user\UserAuthenticationInterface|\Drupal\user\UserAuthInterface $user_auth * The user authentication. * @param \Drupal\Core\Routing\RouteProviderInterface $route_provider * The route provider. @@ -114,10 +114,13 @@ class UserAuthenticationController extends ControllerBase implements ContainerIn * @param \Psr\Log\LoggerInterface $logger * A logger instance. */ - public function __construct(UserFloodControlInterface $user_flood_control, UserStorageInterface $user_storage, CsrfTokenGenerator $csrf_token, UserAuthInterface $user_auth, RouteProviderInterface $route_provider, Serializer $serializer, array $serializer_formats, LoggerInterface $logger) { + public function __construct(UserFloodControlInterface $user_flood_control, UserStorageInterface $user_storage, CsrfTokenGenerator $csrf_token, UserAuthenticationInterface|UserAuthInterface $user_auth, RouteProviderInterface $route_provider, Serializer $serializer, array $serializer_formats, LoggerInterface $logger) { $this->userFloodControl = $user_flood_control; $this->userStorage = $user_storage; $this->csrfToken = $csrf_token; + if (!$user_auth instanceof UserAuthenticationInterface) { + @trigger_error('The $user_auth parameter implementing UserAuthInterface is deprecated in drupal:10.3.0 and will be removed in drupal:12.0.0. Implement UserAuthenticationInterface instead. See https://www.drupal.org/node/3411040'); + } $this->userAuth = $user_auth; $this->serializer = $serializer; $this->serializerFormats = $serializer_formats; @@ -178,36 +181,53 @@ class UserAuthenticationController extends ControllerBase implements ContainerIn $this->floodControl($request, $credentials['name']); - if ($this->userIsBlocked($credentials['name'])) { - throw new BadRequestHttpException('The user has not been activated or is blocked.'); + $account = FALSE; + + if ($this->userAuth instanceof UserAuthenticationInterface) { + $account = $this->userAuth->lookupAccount($credentials['name']); + } + else { + $accounts = $this->userStorage->loadByProperties(['name' => $credentials['name']]); + if ($accounts) { + $account = reset($accounts); + } } - if ($uid = $this->userAuth->authenticate($credentials['name'], $credentials['pass'])) { - $this->userFloodControl->clear('user.http_login', $this->getLoginFloodIdentifier($request, $credentials['name'])); - /** @var \Drupal\user\UserInterface $user */ - $user = $this->userStorage->load($uid); - $this->userLoginFinalize($user); - - // Send basic metadata about the logged in user. - $response_data = []; - if ($user->get('uid')->access('view', $user)) { - $response_data['current_user']['uid'] = $user->id(); + if ($account) { + if ($account->isBlocked()) { + throw new BadRequestHttpException('The user has not been activated or is blocked.'); } - if ($user->get('roles')->access('view', $user)) { - $response_data['current_user']['roles'] = $user->getRoles(); + if ($this->userAuth instanceof UserAuthenticationInterface) { + $authenticated = $this->userAuth->authenticateAccount($account, $credentials['pass']) ? $account->id() : FALSE; } - if ($user->get('name')->access('view', $user)) { - $response_data['current_user']['name'] = $user->getAccountName(); + else { + $authenticated = $this->userAuth->authenticateAccount($credentials['name'], $credentials['pass']); } - $response_data['csrf_token'] = $this->csrfToken->get('rest'); + if ($authenticated) { + $this->userFloodControl->clear('user.http_login', $this->getLoginFloodIdentifier($request, $credentials['name'])); + $this->userLoginFinalize($account); - $logout_route = $this->routeProvider->getRouteByName('user.logout.http'); - // Trim '/' off path to match \Drupal\Core\Access\CsrfAccessCheck. - $logout_path = ltrim($logout_route->getPath(), '/'); - $response_data['logout_token'] = $this->csrfToken->get($logout_path); + // Send basic metadata about the logged in user. + $response_data = []; + if ($account->get('uid')->access('view', $account)) { + $response_data['current_user']['uid'] = $account->id(); + } + if ($account->get('roles')->access('view', $account)) { + $response_data['current_user']['roles'] = $account->getRoles(); + } + if ($account->get('name')->access('view', $account)) { + $response_data['current_user']['name'] = $account->getAccountName(); + } + $response_data['csrf_token'] = $this->csrfToken->get('rest'); - $encoded_response_data = $this->serializer->encode($response_data, $format); - return new Response($encoded_response_data); + $logout_route = $this->routeProvider->getRouteByName('user.logout.http'); + // Trim '/' off path to match \Drupal\Core\Access\CsrfAccessCheck. + $logout_path = ltrim($logout_route->getPath(), '/'); + $response_data['logout_token'] = $this->csrfToken->get($logout_path); + + $encoded_response_data = $this->serializer->encode($response_data, $format); + return new Response($encoded_response_data); + } } $flood_config = $this->config('user.flood'); @@ -250,10 +270,10 @@ class UserAuthenticationController extends ControllerBase implements ContainerIn $users = $this->userStorage->loadByProperties(['mail' => trim($identifier)]); } - /** @var \Drupal\Core\Session\AccountInterface $account */ + /** @var \Drupal\user\UserInterface $account */ $account = reset($users); if ($account && $account->id()) { - if ($this->userIsBlocked($account->getAccountName())) { + if ($account->isBlocked()) { $this->logger->error('Unable to send password reset email for blocked or not yet activated user %identifier.', [ '%identifier' => $identifier, ]); @@ -286,8 +306,13 @@ class UserAuthenticationController extends ControllerBase implements ContainerIn * * @return bool * TRUE if the user is blocked, otherwise FALSE. + * + * @deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. There + * is no replacement. + * @see https://www.drupal.org/node/3425340 */ protected function userIsBlocked($name) { + @trigger_error(__METHOD__ . ' is deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. There is no replacement. See https://www.drupal.org/node/3425340', E_USER_DEPRECATED); return user_is_blocked($name); } diff --git a/core/modules/user/src/Form/UserLoginForm.php b/core/modules/user/src/Form/UserLoginForm.php index 54a3d4280fa..e3df158e0f5 100644 --- a/core/modules/user/src/Form/UserLoginForm.php +++ b/core/modules/user/src/Form/UserLoginForm.php @@ -7,6 +7,7 @@ use Drupal\Core\Form\FormStateInterface; use Drupal\Core\Render\RendererInterface; use Drupal\Core\Render\BareHtmlPageRendererInterface; use Drupal\Core\Url; +use Drupal\user\UserAuthenticationInterface; use Drupal\user\UserAuthInterface; use Drupal\user\UserInterface; use Drupal\user\UserStorageInterface; @@ -37,7 +38,7 @@ class UserLoginForm extends FormBase { /** * The user authentication object. * - * @var \Drupal\user\UserAuthInterface + * @var \Drupal\user\UserAuthInterface|\Drupal\user\UserAuthenticationInterface */ protected $userAuth; @@ -62,16 +63,19 @@ class UserLoginForm extends FormBase { * The user flood control service. * @param \Drupal\user\UserStorageInterface $user_storage * The user storage. - * @param \Drupal\user\UserAuthInterface $user_auth + * @param \Drupal\user\UserAuthInterface|\Drupal\user\UserAuthenticationInterface $user_auth * The user authentication object. * @param \Drupal\Core\Render\RendererInterface $renderer * The renderer. * @param \Drupal\Core\Render\BareHtmlPageRendererInterface $bare_html_renderer * The renderer. */ - public function __construct(UserFloodControlInterface $user_flood_control, UserStorageInterface $user_storage, UserAuthInterface $user_auth, RendererInterface $renderer, BareHtmlPageRendererInterface $bare_html_renderer) { + public function __construct(UserFloodControlInterface $user_flood_control, UserStorageInterface $user_storage, UserAuthInterface|UserAuthenticationInterface $user_auth, RendererInterface $renderer, BareHtmlPageRendererInterface $bare_html_renderer) { $this->userFloodControl = $user_flood_control; $this->userStorage = $user_storage; + if (!$user_auth instanceof UserAuthenticationInterface) { + @trigger_error('The $user_auth parameter not implementing UserAuthenticationInterface is deprecated in drupal:10.3.0 and will be removed in drupal:12.0.0. See https://www.drupal.org/node/3411040'); + } $this->userAuth = $user_auth; $this->renderer = $renderer; $this->bareHtmlPageRenderer = $bare_html_renderer; @@ -132,7 +136,6 @@ class UserLoginForm extends FormBase { $form['actions'] = ['#type' => 'actions']; $form['actions']['submit'] = ['#type' => 'submit', '#value' => $this->t('Log in')]; - $form['#validate'][] = '::validateName'; $form['#validate'][] = '::validateAuthentication'; $form['#validate'][] = '::validateFinal'; @@ -145,7 +148,6 @@ class UserLoginForm extends FormBase { * {@inheritdoc} */ public function submitForm(array &$form, FormStateInterface $form_state) { - if (empty($uid = $form_state->get('uid'))) { return; } @@ -167,8 +169,12 @@ class UserLoginForm extends FormBase { /** * Sets an error if supplied username has been blocked. + * + * @deprecated in drupal:10.3.0 and is removed from drupal:11.0.0. There is no replacement. + * @see https://www.drupal.org/node/3410706 */ public function validateName(array &$form, FormStateInterface $form_state) { + @trigger_error(__METHOD__ . ' is deprecated in drupal:10.3.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/node/3410706', E_USER_DEPRECATED); if (!$form_state->isValueEmpty('name') && user_is_blocked($form_state->getValue('name'))) { // Blocked in user administration. $form_state->setErrorByName('name', $this->t('The username %name has not been activated or is blocked.', ['%name' => $form_state->getValue('name')])); @@ -183,6 +189,7 @@ class UserLoginForm extends FormBase { public function validateAuthentication(array &$form, FormStateInterface $form_state) { $password = trim($form_state->getValue('pass')); $flood_config = $this->config('user.flood'); + $account = FALSE; if (!$form_state->isValueEmpty('name') && strlen($password) > 0) { // Do not allow any login from the current user's IP if the limit has been // reached. Default is 50 failed attempts allowed in one hour. This is @@ -193,9 +200,17 @@ class UserLoginForm extends FormBase { $form_state->set('flood_control_triggered', 'ip'); return; } - $accounts = $this->userStorage->loadByProperties(['name' => $form_state->getValue('name'), 'status' => 1]); - $account = reset($accounts); - if ($account) { + if ($this->userAuth instanceof UserAuthenticationInterface) { + $account = $this->userAuth->lookupAccount($form_state->getValue('name')); + } + else { + $accounts = $this->userStorage->loadByProperties(['name' => $form_state->getValue('name')]); + $account = reset($accounts); + } + if ($account && $account->isBlocked()) { + $form_state->setErrorByName('name', $this->t('The username %name has not been activated or is blocked.', ['%name' => $form_state->getValue('name')])); + } + elseif ($account && $account->isActive()) { if ($flood_config->get('uid_only')) { // Register flood events based on the uid only, so they apply for any // IP address. This is the most secure option. @@ -226,11 +241,16 @@ class UserLoginForm extends FormBase { else { $form_state->set('flood_control_skip_clear', 'user'); } + // We are not limited by flood control, so try to authenticate. + // Store the user ID in form state as a flag for self::validateFinal(). + if ($this->userAuth instanceof UserAuthenticationInterface) { + $form_state->set('uid', $this->userAuth->authenticateAccount($account, $password) ? $account->id() : FALSE); + } + else { + $uid = $this->userAuth->authenticate($form_state->getValue('name'), $password); + $form_state->set('uid', $uid); + } } - // We are not limited by flood control, so try to authenticate. - // Store $uid in form state as a flag for self::validateFinal(). - $uid = $this->userAuth->authenticate($form_state->getValue('name'), $password); - $form_state->set('uid', $uid); } } diff --git a/core/modules/user/src/UserAuth.php b/core/modules/user/src/UserAuth.php index 03ad41af3c0..7d3b7885e81 100644 --- a/core/modules/user/src/UserAuth.php +++ b/core/modules/user/src/UserAuth.php @@ -8,7 +8,7 @@ use Drupal\Core\Password\PasswordInterface; /** * Validates user authentication credentials. */ -class UserAuth implements UserAuthInterface { +class UserAuth implements UserAuthInterface, UserAuthenticationInterface { /** * The entity type manager. @@ -41,26 +41,48 @@ class UserAuth implements UserAuthInterface { * {@inheritdoc} */ public function authenticate($username, #[\SensitiveParameter] $password) { + @trigger_error(__METHOD__ . ' is deprecated in drupal:10.3.0 and will be removed from drupal 12.0.0. Implement \Drupal\user\UserAuthenticationInterface instead. See https://www.drupal.org/node/3411040'); $uid = FALSE; if (!empty($username) && strlen($password) > 0) { $account_search = $this->entityTypeManager->getStorage('user')->loadByProperties(['name' => $username]); if ($account = reset($account_search)) { - if ($this->passwordChecker->check($password, $account->getPassword())) { - // Successful authentication. + if ($this->authenticateAccount($account, $password)) { $uid = $account->id(); - - // Update user to new password scheme if needed. - if ($this->passwordChecker->needsRehash($account->getPassword())) { - $account->setPassword($password); - $account->save(); - } } } } - return $uid; } + /** + * {@inheritdoc} + */ + public function lookupAccount($identifier): UserInterface|false { + if (!empty($identifier)) { + $account_search = $this->entityTypeManager->getStorage('user')->loadByProperties(['name' => $identifier]); + + if ($account = reset($account_search)) { + return $account; + } + } + return FALSE; + } + + /** + * {@inheritdoc} + */ + public function authenticateAccount(UserInterface $account, #[\SensitiveParameter] string $password): bool { + if ($this->passwordChecker->check($password, $account->getPassword())) { + // Update user to new password scheme if needed. + if ($this->passwordChecker->needsRehash($account->getPassword())) { + $account->setPassword($password); + $account->save(); + } + return TRUE; + } + return FALSE; + } + } diff --git a/core/modules/user/src/UserAuthenticationInterface.php b/core/modules/user/src/UserAuthenticationInterface.php new file mode 100644 index 00000000000..34f7fe9cb99 --- /dev/null +++ b/core/modules/user/src/UserAuthenticationInterface.php @@ -0,0 +1,37 @@ +accessCheck(FALSE) ->condition('name', $name) diff --git a/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php b/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php index 4ad67fee30b..c07f367006b 100644 --- a/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php +++ b/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php @@ -197,11 +197,9 @@ class StandardPerformanceTest extends PerformanceTestBase { $expected_queries = [ 'SELECT "name", "value" FROM "key_value" WHERE "name" IN ( "system.maintenance_mode" ) AND "collection" = "state"', - 'SELECT "base_table"."uid" AS "uid", "base_table"."uid" AS "base_table_uid" FROM "users" "base_table" INNER JOIN "users_field_data" "users_field_data" ON "users_field_data"."uid" = "base_table"."uid" WHERE ("users_field_data"."name" LIKE "ACCOUNT_NAME" ESCAPE ' . "'\\\\'" . ') AND ("users_field_data"."status" = 0)', 'SELECT COUNT(*) AS "expression" FROM (SELECT 1 AS "expression" FROM "flood" "f" WHERE ("event" = "user.failed_login_ip") AND ("identifier" = "CLIENT_IP") AND ("timestamp" > "TIMESTAMP")) "subquery"', - 'SELECT "base_table"."uid" AS "uid", "base_table"."uid" AS "base_table_uid" FROM "users" "base_table" INNER JOIN "users_field_data" "users_field_data" ON "users_field_data"."uid" = "base_table"."uid" WHERE ("users_field_data"."name" IN ("ACCOUNT_NAME")) AND ("users_field_data"."status" IN (1)) AND ("users_field_data"."default_langcode" IN (1))', - 'SELECT COUNT(*) AS "expression" FROM (SELECT 1 AS "expression" FROM "flood" "f" WHERE ("event" = "user.failed_login_user") AND ("identifier" = "CLIENT_IP") AND ("timestamp" > "TIMESTAMP")) "subquery"', 'SELECT "base_table"."uid" AS "uid", "base_table"."uid" AS "base_table_uid" FROM "users" "base_table" INNER JOIN "users_field_data" "users_field_data" ON "users_field_data"."uid" = "base_table"."uid" WHERE ("users_field_data"."name" IN ("ACCOUNT_NAME")) AND ("users_field_data"."default_langcode" IN (1))', + 'SELECT COUNT(*) AS "expression" FROM (SELECT 1 AS "expression" FROM "flood" "f" WHERE ("event" = "user.failed_login_user") AND ("identifier" = "CLIENT_IP") AND ("timestamp" > "TIMESTAMP")) "subquery"', 'INSERT INTO "watchdog" ("uid", "type", "message", "variables", "severity", "link", "location", "referer", "hostname", "timestamp") VALUES ("2", "user", "Session opened for %name.", "WATCHDOG_DATA", 6, "", "LOCATION", "REFERER", "CLIENT_IP", "TIMESTAMP")', 'UPDATE "users_field_data" SET "login"="TIMESTAMP" WHERE "uid" = "2"', 'SELECT "name", "value" FROM "key_value" WHERE "name" IN ( "drupal.test_wait_terminate" ) AND "collection" = "state"', @@ -225,7 +223,7 @@ class StandardPerformanceTest extends PerformanceTestBase { ]; $recorded_queries = $performance_data->getQueries(); $this->assertSame($expected_queries, $recorded_queries); - $this->assertSame(26, $performance_data->getQueryCount()); + $this->assertSame(24, $performance_data->getQueryCount()); $this->assertSame(63, $performance_data->getCacheGetCount()); $this->assertSame(1, $performance_data->getCacheSetCount()); $this->assertSame(1, $performance_data->getCacheDeleteCount()); @@ -266,15 +264,13 @@ class StandardPerformanceTest extends PerformanceTestBase { 'SELECT "name", "value" FROM "key_value" WHERE "name" IN ( "twig_extension_hash_prefix" ) AND "collection" = "state"', 'SELECT "name", "value" FROM "key_value" WHERE "name" IN ( "theme:stark" ) AND "collection" = "config.entity.key_store.block"', 'SELECT "config"."name" AS "name" FROM "config" "config" WHERE ("collection" = "") AND ("name" LIKE "search.page.%" ESCAPE ' . "'\\\\'" . ') ORDER BY "collection" ASC, "name" ASC', - 'SELECT "base_table"."uid" AS "uid", "base_table"."uid" AS "base_table_uid" FROM "users" "base_table" INNER JOIN "users_field_data" "users_field_data" ON "users_field_data"."uid" = "base_table"."uid" WHERE ("users_field_data"."name" LIKE "ACCOUNT_NAME" ESCAPE ' . "'\\\\'" . ') AND ("users_field_data"."status" = 0)', 'SELECT COUNT(*) AS "expression" FROM (SELECT 1 AS "expression" FROM "flood" "f" WHERE ("event" = "user.failed_login_ip") AND ("identifier" = "CLIENT_IP") AND ("timestamp" > "TIMESTAMP")) "subquery"', - 'SELECT "base_table"."uid" AS "uid", "base_table"."uid" AS "base_table_uid" FROM "users" "base_table" INNER JOIN "users_field_data" "users_field_data" ON "users_field_data"."uid" = "base_table"."uid" WHERE ("users_field_data"."name" IN ("ACCOUNT_NAME")) AND ("users_field_data"."status" IN (1)) AND ("users_field_data"."default_langcode" IN (1))', + 'SELECT "base_table"."uid" AS "uid", "base_table"."uid" AS "base_table_uid" FROM "users" "base_table" INNER JOIN "users_field_data" "users_field_data" ON "users_field_data"."uid" = "base_table"."uid" WHERE ("users_field_data"."name" IN ("ACCOUNT_NAME")) AND ("users_field_data"."default_langcode" IN (1))', 'SELECT "base"."uid" AS "uid", "base"."uuid" AS "uuid", "base"."langcode" AS "langcode" FROM "users" "base" WHERE "base"."uid" IN (2)', 'SELECT "data".* FROM "users_field_data" "data" WHERE "data"."uid" IN (2) ORDER BY "data"."uid" ASC', 'SELECT "t".* FROM "user__roles" "t" WHERE ("entity_id" IN (2)) AND ("deleted" = 0) AND ("langcode" IN ("en", "und", "zxx")) ORDER BY "delta" ASC', 'SELECT "t".* FROM "user__user_picture" "t" WHERE ("entity_id" IN (2)) AND ("deleted" = 0) AND ("langcode" IN ("en", "und", "zxx")) ORDER BY "delta" ASC', 'SELECT COUNT(*) AS "expression" FROM (SELECT 1 AS "expression" FROM "flood" "f" WHERE ("event" = "user.failed_login_user") AND ("identifier" = "CLIENT_IP") AND ("timestamp" > "TIMESTAMP")) "subquery"', - 'SELECT "base_table"."uid" AS "uid", "base_table"."uid" AS "base_table_uid" FROM "users" "base_table" INNER JOIN "users_field_data" "users_field_data" ON "users_field_data"."uid" = "base_table"."uid" WHERE ("users_field_data"."name" IN ("ACCOUNT_NAME")) AND ("users_field_data"."default_langcode" IN (1))', 'INSERT INTO "watchdog" ("uid", "type", "message", "variables", "severity", "link", "location", "referer", "hostname", "timestamp") VALUES ("2", "user", "Session opened for %name.", "WATCHDOG_DATA", 6, "", "LOCATION", "REFERER", "CLIENT_IP", "TIMESTAMP")', 'UPDATE "users_field_data" SET "login"="TIMESTAMP" WHERE "uid" = "2"', 'SELECT "name", "value" FROM "key_value" WHERE "name" IN ( "drupal.test_wait_terminate" ) AND "collection" = "state"', @@ -294,7 +290,7 @@ class StandardPerformanceTest extends PerformanceTestBase { ]; $recorded_queries = $performance_data->getQueries(); $this->assertSame($expected_queries, $recorded_queries); - $this->assertSame(31, $performance_data->getQueryCount()); + $this->assertSame(29, $performance_data->getQueryCount()); $this->assertSame(106, $performance_data->getCacheGetCount()); $this->assertSame(1, $performance_data->getCacheSetCount()); $this->assertSame(1, $performance_data->getCacheDeleteCount());