Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3255895 by jrb, murilohp, harshitthakore, xjm: HTML entities in Tour tip labels get double-escaped

merge-requests/2433/head
Lauri Eskola 2023-02-14 09:20:58 +02:00
parent 9411d5f6dc
commit 18c67bfffd
No known key found for this signature in database
GPG Key ID: 382FC0F5B0DF53F8
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/modules/tour/src/TourViewBuilder.php
View File

@ -43,7 +43,7 @@ class TourViewBuilder extends EntityViewBuilder {
$body = (string) \Drupal::service('renderer')->renderPlain($body_render_array); $body = (string) \Drupal::service('renderer')->renderPlain($body_render_array);
$output = [ $output = [
'body' => $body, 'body' => $body,
'title' => Html::escape($tip->getLabel()), 'title' => $tip->getLabel(),
]; ];
$selector = $tip->getSelector(); $selector = $tip->getSelector();

4
core/modules/tour/tests/src/Functional/TourTest.php
View File

@ -158,7 +158,7 @@ class TourTest extends TourTestBasic {
'tour-test-1' => [ 'tour-test-1' => [
'id' => 'tour-code-test-1', 'id' => 'tour-code-test-1',
'plugin' => 'text', 'plugin' => 'text',
'label' => 'The rain in spain', 'label' => 'The rain in spain is <strong>strong</strong>',
'body' => 'Falls mostly on the plain.', 'body' => 'Falls mostly on the plain.',
'weight' => '100', 'weight' => '100',
'selector' => '#tour-code-test-1', 'selector' => '#tour-code-test-1',
@ -194,7 +194,7 @@ class TourTest extends TourTestBasic {
$elements = $this->findTip([ $elements = $this->findTip([
'id' => 'tour-code-test-1', 'id' => 'tour-code-test-1',
'title' => 'The rain in spain', 'title' => 'The rain in spain is <strong>strong</strong>',
]); ]);
$this->assertCount(1, $elements, 'Found the required tip markup for tip 4'); $this->assertCount(1, $elements, 'Found the required tip markup for tip 4');