Issue #2857857 by vegantriathlete, Jo Fitzgerald, snehi, plach, xjm, Skabbkladden: Check use of "it's" in core to ensure proper use
Nathaniel Catchpole
parent
441ea0e22c
commit
1455cb13cf
|
|
@ -413,7 +413,7 @@ class Schema extends DatabaseSchema {
|
|||
|
||||
// Now add the fields.
|
||||
foreach ($mapping as $field_alias => $field_source) {
|
||||
// Just ignore this field (ie. use it's default value).
|
||||
// Just ignore this field (ie. use its default value).
|
||||
if (!isset($field_source)) {
|
||||
continue;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -174,7 +174,7 @@ class Merge extends Query implements ConditionInterface {
|
|||
* Specifies fields to be updated as an expression.
|
||||
*
|
||||
* Expression fields are cases such as counter = counter + 1. This method
|
||||
* takes precedence over MergeQuery::updateFields() and it's wrappers,
|
||||
* takes precedence over MergeQuery::updateFields() and its wrappers,
|
||||
* MergeQuery::key() and MergeQuery::fields().
|
||||
*
|
||||
* @param $field
|
||||
|
|
|
|||
|
|
@ -63,7 +63,7 @@ class EntityReferenceSelection extends Plugin {
|
|||
public $entity_types = [];
|
||||
|
||||
/**
|
||||
* The weight of the plugin in it's group.
|
||||
* The weight of the plugin in its group.
|
||||
*
|
||||
* @var int
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -39,7 +39,7 @@ class EntityAutocomplete extends Textfield {
|
|||
$info['#validate_reference'] = TRUE;
|
||||
// IMPORTANT! This should only be set to FALSE if the #default_value
|
||||
// property is processed at another level (e.g. by a Field API widget) and
|
||||
// it's value is properly checked for access.
|
||||
// its value is properly checked for access.
|
||||
$info['#process_default_value'] = TRUE;
|
||||
|
||||
$info['#element_validate'] = [[$class, 'validateEntityAutocomplete']];
|
||||
|
|
|
|||
|
|
@ -449,7 +449,7 @@ abstract class QueryBase implements QueryInterface {
|
|||
}
|
||||
|
||||
/**
|
||||
* Generates an alias for a field and it's aggregated function.
|
||||
* Generates an alias for a field and its aggregated function.
|
||||
*
|
||||
* @param string $field
|
||||
* The field name used in the alias.
|
||||
|
|
|
|||
|
|
@ -127,7 +127,7 @@ class FormErrorHandler implements FormErrorHandlerInterface {
|
|||
}
|
||||
|
||||
// Additionally store the errors of the direct child itself, keyed by
|
||||
// it's parent elements structure.
|
||||
// its parent elements structure.
|
||||
if (!empty($child['#errors'])) {
|
||||
$child_parents = implode('][', $child['#array_parents']);
|
||||
$children_errors[$child_parents] = $child['#errors'];
|
||||
|
|
|
|||
|
|
@ -218,7 +218,7 @@ class Renderer implements RendererInterface {
|
|||
|
||||
// Early-return nothing if user does not have access.
|
||||
if (isset($elements['#access'])) {
|
||||
// If #access is an AccessResultInterface object, we must apply it's
|
||||
// If #access is an AccessResultInterface object, we must apply its
|
||||
// cacheability metadata to the render array.
|
||||
if ($elements['#access'] instanceof AccessResultInterface) {
|
||||
$this->addCacheableDependency($elements, $elements['#access']);
|
||||
|
|
|
|||
|
|
@ -224,7 +224,7 @@
|
|||
background: transparent;
|
||||
}
|
||||
|
||||
/* Prevent list item from expanding it's container. */
|
||||
/* Prevent list item from expanding its container. */
|
||||
#drupal-off-canvas td ul.dropbutton li.edit {
|
||||
width: 2em;
|
||||
height: 2em;
|
||||
|
|
|
|||
|
|
@ -69,7 +69,7 @@ interface BookOutlineStorageInterface {
|
|||
public function delete($nid);
|
||||
|
||||
/**
|
||||
* Loads book's children using it's parent ID.
|
||||
* Loads book's children using its parent ID.
|
||||
*
|
||||
* @param int $pid
|
||||
* The book's parent ID.
|
||||
|
|
|
|||
|
|
@ -688,7 +688,7 @@ class ContentTranslationHandler implements ContentTranslationHandlerInterface, E
|
|||
// after the entity has been validated, so that it does not break the
|
||||
// EntityChanged constraint validator. The content translation metadata
|
||||
// field for the changed timestamp does not have such a constraint defined
|
||||
// at the moment, but it is correct to update it's value in a submission
|
||||
// at the moment, but it is correct to update its value in a submission
|
||||
// handler as well and have the same logic like in the Form API.
|
||||
if ($entity->hasField('content_translation_changed')) {
|
||||
$metadata = $this->manager->getTranslationMetadata($entity);
|
||||
|
|
|
|||
|
|
@ -86,7 +86,7 @@ class reEnableModuleFieldTest extends WebTestBase {
|
|||
$this->assertRaw('<a href="tel:123456789">');
|
||||
|
||||
// Test that the module can't be uninstalled from the UI while there is data
|
||||
// for it's fields.
|
||||
// for its fields.
|
||||
$admin_user = $this->drupalCreateUser(['access administration pages', 'administer modules']);
|
||||
$this->drupalLogin($admin_user);
|
||||
$this->drupalGet('admin/modules/uninstall');
|
||||
|
|
|
|||
|
|
@ -67,7 +67,7 @@ class EntityReferenceRelationshipTest extends ViewsKernelTestBase {
|
|||
// Create reference from entity_test_mul to entity_test.
|
||||
$this->createEntityReferenceField('entity_test_mul', 'entity_test_mul', 'field_data_test', 'field_data_test', 'entity_test');
|
||||
|
||||
// Create another field for testing with a long name. So it's storage name
|
||||
// Create another field for testing with a long name. So its storage name
|
||||
// will become hashed. Use entity_test_mul_changed, so the resulting field
|
||||
// tables created will be greater than 48 chars long.
|
||||
// @see \Drupal\Core\Entity\Sql\DefaultTableMapping::generateFieldTableName()
|
||||
|
|
|
|||
|
|
@ -227,7 +227,7 @@ class PrepareModulesEntityUninstallForm extends ConfirmFormBase {
|
|||
$storage->delete($entities);
|
||||
}
|
||||
// Sometimes deletes cause secondary deletes. For example, deleting a
|
||||
// taxonomy term can cause it's children to be be deleted too.
|
||||
// taxonomy term can cause its children to be be deleted too.
|
||||
$context['sandbox']['progress'] = $context['sandbox']['max'] - $storage->getQuery()->count()->execute();
|
||||
|
||||
// Inform the batch engine that we are not finished and provide an
|
||||
|
|
|
|||
|
|
@ -390,7 +390,7 @@ class ThemeTest extends WebTestBase {
|
|||
// Check that bartik can be uninstalled now.
|
||||
$this->assertRaw('Uninstall Bartik theme', 'A link to uninstall the Bartik theme does appear on the theme settings page.');
|
||||
|
||||
// Check that the classy theme still can't be uninstalled as neither of it's
|
||||
// Check that the classy theme still can't be uninstalled as neither of its
|
||||
// base themes have been.
|
||||
$this->assertNoRaw('Uninstall Classy theme', 'A link to uninstall the Classy theme does not appear on the theme settings page.');
|
||||
|
||||
|
|
|
|||
|
|
@ -387,7 +387,7 @@ class View extends ConfigEntityBase implements ViewEntityInterface {
|
|||
views_invalidate_cache();
|
||||
$this->invalidateCaches();
|
||||
|
||||
// Rebuild the router if this is a new view, or it's status changed.
|
||||
// Rebuild the router if this is a new view, or its status changed.
|
||||
if (!isset($this->original) || ($this->status() != $this->original->status())) {
|
||||
\Drupal::service('router.builder')->setRebuildNeeded();
|
||||
}
|
||||
|
|
|
|||
|
|
@ -118,7 +118,7 @@ interface ViewsPluginInterface extends PluginInspectionInterface, DerivativeInsp
|
|||
/**
|
||||
* Flattens the structure of form elements.
|
||||
*
|
||||
* If a form element has #flatten = TRUE, then all of it's children get moved
|
||||
* If a form element has #flatten = TRUE, then all of its children get moved
|
||||
* to the same level as the element itself. So $form['to_be_flattened'][$key]
|
||||
* becomes $form[$key], and $form['to_be_flattened'] gets unset.
|
||||
*
|
||||
|
|
|
|||
|
|
@ -23,7 +23,7 @@ use Drupal\Core\Form\FormStateInterface;
|
|||
class Fields extends RowPluginBase {
|
||||
|
||||
/**
|
||||
* Does the row plugin support to add fields to it's output.
|
||||
* Does the row plugin support to add fields to its output.
|
||||
*
|
||||
* @var bool
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -18,7 +18,7 @@ use Drupal\Core\Form\FormStateInterface;
|
|||
class OpmlFields extends RowPluginBase {
|
||||
|
||||
/**
|
||||
* Does the row plugin support to add fields to it's output.
|
||||
* Does the row plugin support to add fields to its output.
|
||||
*
|
||||
* @var bool
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -43,7 +43,7 @@ abstract class RowPluginBase extends PluginBase {
|
|||
protected $usesOptions = TRUE;
|
||||
|
||||
/**
|
||||
* Does the row plugin support to add fields to it's output.
|
||||
* Does the row plugin support to add fields to its output.
|
||||
*
|
||||
* @var bool
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -19,7 +19,7 @@ use Drupal\Core\Url;
|
|||
class RssFields extends RowPluginBase {
|
||||
|
||||
/**
|
||||
* Does the row plugin support to add fields to it's output.
|
||||
* Does the row plugin support to add fields to its output.
|
||||
*
|
||||
* @var bool
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -71,7 +71,7 @@ abstract class StylePluginBase extends PluginBase {
|
|||
protected $usesGrouping = TRUE;
|
||||
|
||||
/**
|
||||
* Does the style plugin for itself support to add fields to it's output.
|
||||
* Does the style plugin for itself support to add fields to its output.
|
||||
*
|
||||
* This option only makes sense on style plugins without row plugins, like
|
||||
* for example table.
|
||||
|
|
|
|||
|
|
@ -23,7 +23,7 @@ use Drupal\views\Plugin\views\wizard\WizardInterface;
|
|||
class Table extends StylePluginBase implements CacheableDependencyInterface {
|
||||
|
||||
/**
|
||||
* Does the style plugin for itself support to add fields to it's output.
|
||||
* Does the style plugin for itself support to add fields to its output.
|
||||
*
|
||||
* @var bool
|
||||
*/
|
||||
|
|
|
|||
|
|
@ -331,7 +331,7 @@ class ViewExecutable {
|
|||
protected $request;
|
||||
|
||||
/**
|
||||
* Does this view already have loaded it's handlers.
|
||||
* Does this view already have loaded its handlers.
|
||||
*
|
||||
* @todo Group with other static properties.
|
||||
*
|
||||
|
|
|
|||
|
|
@ -184,7 +184,7 @@ class DisplayTest extends UITestBase {
|
|||
$view = $this->randomView();
|
||||
$id = $view['id'];
|
||||
|
||||
// The view should initially have the enabled class on it's form wrapper.
|
||||
// The view should initially have the enabled class on its form wrapper.
|
||||
$this->drupalGet('admin/structure/views/view/' . $id);
|
||||
$elements = $this->xpath('//div[contains(@class, :edit) and contains(@class, :status)]', [':edit' => 'views-edit-view', ':status' => 'enabled']);
|
||||
$this->assertTrue($elements, 'The enabled class was found on the form wrapper');
|
||||
|
|
|
|||
|
|
@ -172,7 +172,7 @@ JS;
|
|||
}
|
||||
|
||||
/**
|
||||
* Test that a node, or it's specific corner, is visible in the viewport.
|
||||
* Test that a node, or its specific corner, is visible in the viewport.
|
||||
*
|
||||
* Note: Always set the viewport size. This can be done with a PhantomJS
|
||||
* startup parameter or in your test with \Behat\Mink\Session->resizeWindow().
|
||||
|
|
@ -255,7 +255,7 @@ JS;
|
|||
}
|
||||
|
||||
/**
|
||||
* Check the visibility of a node, or it's specific corner.
|
||||
* Check the visibility of a node, or its specific corner.
|
||||
*
|
||||
* @param \Behat\Mink\Element\NodeElement $node
|
||||
* A valid node.
|
||||
|
|
|
|||
|
|
@ -22,7 +22,7 @@ class UpdaterTest extends KernelTestBase {
|
|||
* @see https://drupal.org/node/2409515
|
||||
*/
|
||||
public function testGetProjectTitleWithChild() {
|
||||
// Get the project title from it's directory. If it can't find the title
|
||||
// Get the project title from its directory. If it can't find the title
|
||||
// it will choose the first project title in the directory.
|
||||
$directory = \Drupal::root() . '/core/modules/system/tests/modules/module_handler_test_multiple';
|
||||
$title = Updater::getProjectTitle($directory);
|
||||
|
|
|
|||
|
|
@ -224,7 +224,7 @@
|
|||
background: transparent;
|
||||
}
|
||||
|
||||
/* Prevent list item from expanding it's container. */
|
||||
/* Prevent list item from expanding its container. */
|
||||
#drupal-off-canvas td ul.dropbutton li.edit {
|
||||
width: 2em;
|
||||
height: 2em;
|
||||
|
|
|
|||
Loading…
Reference in New Issue