Issue #2612334 by NickWilde: Remove dead code in \Drupal\Core\Asset\[Css|Js]Collection[Grouper|Optimizer]

core/lib/Drupal/Core/Asset/CssCollectionGrouper.php

@@ -12,8 +12,8 @@ class CssCollectionGrouper implements AssetCollectionGrouperInterface {
    *
    * Puts multiple items into the same group if they are groupable and if they
    * are for the same 'media' and 'browsers'. Items of the 'file' type are
-   * groupable if their 'preprocess' flag is TRUE, items of the 'inline' type
-   * are always groupable, and items of the 'external' type are never groupable.
+   * groupable if their 'preprocess' flag is TRUE, and items of the 'external'
+   * type are never groupable.
    *
    * Also ensures that the process of grouping items does not change their
    * relative order. This requirement may result in multiple groups for the same
@@ -55,11 +55,6 @@ class CssCollectionGrouper implements AssetCollectionGrouperInterface {
           $group_keys = $item['preprocess'] ? array($item['type'], $item['group'], $item['media'], $item['browsers']) : FALSE;
           break;
 
-        case 'inline':
-          // Always group inline items.
-          $group_keys = array($item['type'], $item['media'], $item['browsers']);
-          break;
-
         case 'external':
           // Do not group external items.
           $group_keys = FALSE;

core/lib/Drupal/Core/Asset/CssCollectionOptimizer.php

@@ -133,16 +133,6 @@ class CssCollectionOptimizer implements AssetCollectionOptimizerInterface {
           }
           break;
 
-        case 'inline':
-          // We don't do any caching for inline CSS assets.
-          $data = '';
-          foreach ($css_group['items'] as $css_asset) {
-            $data .= $this->optimizer->optimize($css_asset);
-          }
-          unset($css_assets[$order]['data']['items']);
-          $css_assets[$order]['data'] = $data;
-          break;
-
         case 'external':
           // We don't do any aggregation and hence also no caching for external
           // CSS assets.

core/lib/Drupal/Core/Asset/CssOptimizer.php

@@ -20,19 +20,14 @@ class CssOptimizer implements AssetOptimizerInterface {
    * {@inheritdoc}
    */
   public function optimize(array $css_asset) {
-    if (!in_array($css_asset['type'], array('file', 'inline'))) {
-      throw new \Exception('Only file or inline CSS assets can be optimized.');
+    if ($css_asset['type'] != 'file') {
+      throw new \Exception('Only file CSS assets can be optimized.');
     }
-    if ($css_asset['type'] === 'file' && !$css_asset['preprocess']) {
+    if (!$css_asset['preprocess']) {
       throw new \Exception('Only file CSS assets with preprocessing enabled can be optimized.');
     }
 
-    if ($css_asset['type'] === 'file') {
-      return $this->processFile($css_asset);
-    }
-    else {
-      return $this->processCss($css_asset['data'], $css_asset['preprocess']);
-    }
+    return $this->processFile($css_asset);
   }
 
   /**

core/lib/Drupal/Core/Asset/JsCollectionGrouper.php

@@ -12,8 +12,7 @@ class JsCollectionGrouper implements AssetCollectionGrouperInterface {
    *
    * Puts multiple items into the same group if they are groupable and if they
    * are for the same browsers. Items of the 'file' type are groupable if their
-   * 'preprocess' flag is TRUE. Items of the 'inline', 'settings', or 'external'
-   * type are not groupable.
+   * 'preprocess' flag is TRUE. Items of the 'external' type are not groupable.
    *
    * Also ensures that the process of grouping items does not change their
    * relative order. This requirement may result in multiple groups for the same
@@ -43,9 +42,7 @@ class JsCollectionGrouper implements AssetCollectionGrouperInterface {
           break;
 
         case 'external':
-        case 'setting':
-        case 'inline':
-          // Do not group external, settings, and inline items.
+          // Do not group external items.
           $group_keys = FALSE;
           break;
       }

core/lib/Drupal/Core/Asset/JsCollectionOptimizer.php

@@ -138,10 +138,8 @@ class JsCollectionOptimizer implements AssetCollectionOptimizerInterface {
           break;
 
         case 'external':
-        case 'setting':
-        case 'inline':
-          // We don't do any aggregation and hence also no caching for external,
-          // setting or inline JS assets.
+          // We don't do any aggregation and hence also no caching for external
+          // JS assets.
           $uri = $js_group['items'][0]['data'];
           $js_assets[$order]['data'] = $uri;
           break;

core/lib/Drupal/Core/Asset/JsOptimizer.php

@@ -16,7 +16,7 @@ class JsOptimizer implements AssetOptimizerInterface {
     if ($js_asset['type'] !== 'file') {
       throw new \Exception('Only file JavaScript assets can be optimized.');
     }
-    if ($js_asset['type'] === 'file' && !$js_asset['preprocess']) {
+    if (!$js_asset['preprocess']) {
       throw new \Exception('Only file JavaScript assets with preprocessing enabled can be optimized.');
     }
 

core/tests/Drupal/Tests/Core/Asset/CssOptimizerUnitTest.php

@@ -276,7 +276,7 @@ class CssOptimizerUnitTest extends UnitTestCase {
    * Tests a CSS asset with 'type' => 'external'.
    */
   function testTypeExternal() {
-    $this->setExpectedException('Exception', 'Only file or inline CSS assets can be optimized.');
+    $this->setExpectedException('Exception', 'Only file CSS assets can be optimized.');
 
     $css_asset = array(
       'group' => -100,