Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3230547 by larowlan, karishmaamin, amjad1233: \Drupal\media\Controller\OEmbedIframeController::render doesn't set a content-type header

merge-requests/1270/head
Alex Pott 2021-09-28 09:24:01 +01:00
parent b6e74cf3fb
commit 0a5beb304b
No known key found for this signature in database
GPG Key ID: 31905460D4A69276
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/modules/media/src/Controller/OEmbedIframeController.php
View File

@ -134,7 +134,9 @@ class OEmbedIframeController implements ContainerInjectionInterface {
// Return a response instead of a render array so that the frame content // Return a response instead of a render array so that the frame content
// will not have all the blocks and page elements normally rendered by // will not have all the blocks and page elements normally rendered by
// Drupal. // Drupal.
$response = new HtmlResponse(); $response = new HtmlResponse('', HtmlResponse::HTTP_OK, [
'Content-Type' => 'text/html; charset=UTF-8',
]);
$response->addCacheableDependency(Url::createFromRequest($request)); $response->addCacheableDependency(Url::createFromRequest($request));
try { try {

1
core/modules/media/tests/src/Kernel/OEmbedIframeControllerTest.php
View File

@ -105,6 +105,7 @@ class OEmbedIframeControllerTest extends MediaKernelTestBase {
$this->assertStringContainsString('&pasta=rigatoni', $content); $this->assertStringContainsString('&pasta=rigatoni', $content);
$this->assertStringContainsString('test.css', $content); $this->assertStringContainsString('test.css', $content);
$this->assertContains('yo_there', $response->getCacheableMetadata()->getCacheTags()); $this->assertContains('yo_there', $response->getCacheableMetadata()->getCacheTags());
$this->assertStringContainsString('text/html', $response->headers->get('Content-Type'));
} }
} }