Issue #2442221 by devpreview: Recursion calculate dependencies in area plugin

core/modules/views/src/Plugin/views/area/View.php

@@ -158,7 +158,8 @@ class View extends AreaPluginBase {
     $dependencies = parent::calculateDependencies();
 
     list($view_id) = explode(':', $this->options['view_to_insert'], 2);
-    if ($view_id) {
+    // Don't call the current view, as it would result into an infinite recursion.
+    if ($view_id && $this->view->storage->id() != $view_id) {
       $view = $this->viewStorage->load($view_id);
       $dependencies[$view->getConfigDependencyKey()][] = $view->getConfigDependencyName();
     }

core/modules/views/tests/src/Unit/Plugin/area/ViewTest.php

@@ -0,0 +1,74 @@
+<?php
+
+/**
+ * @file
+ * Contains \Drupal\Tests\views\Unit\Plugin\area\ViewTest.
+ */
+
+namespace Drupal\Tests\views\Unit\Plugin\area;
+
+use Drupal\Tests\UnitTestCase;
+use Drupal\views\Plugin\views\area\View as ViewAreaPlugin;
+
+/**
+ * @coversDefaultClass \Drupal\views\Plugin\views\area\View
+ * @group views
+ */
+class ViewTest extends UnitTestCase {
+
+  /**
+   * The mocked entity storage.
+   *
+   * @var \Drupal\Core\Entity\EntityStorageInterface|\PHPUnit_Framework_MockObject_MockObject
+   */
+  protected $entityStorage;
+
+  /**
+   * The view handler.
+   *
+   * @var \Drupal\views\Plugin\views\area\View
+   */
+  protected $viewHandler;
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp() {
+    parent::setUp();
+    $this->entityStorage = $this->getMock('Drupal\Core\Entity\EntityStorageInterface');
+    $this->viewHandler = new ViewAreaPlugin(array(), 'view', array(), $this->entityStorage);
+    $this->viewHandler->view = $this->getMockBuilder('Drupal\views\ViewExecutable')
+      ->disableOriginalConstructor()
+      ->getMock();
+  }
+
+  /**
+   * @covers ::calculateDependencies
+   */
+  public function testCalculateDependencies() {
+    /* @var $view_this \Drupal\views\Entity\View */
+    /* @var $view_other \Drupal\views\Entity\View */
+    $view_this = $this->getMock('Drupal\views\ViewEntityInterface');
+    $view_this->expects($this->any())->method('getConfigDependencyKey')->willReturn('config');
+    $view_this->expects($this->any())->method('getConfigDependencyName')->willReturn('view.this');
+    $view_this->expects($this->any())->method('id')->willReturn('this');
+    $view_other = $this->getMock('Drupal\views\ViewEntityInterface');
+    $view_other->expects($this->any())->method('getConfigDependencyKey')->willReturn('config');
+    $view_other->expects($this->any())->method('getConfigDependencyName')->willReturn('view.other');
+    $this->entityStorage->expects($this->any())
+      ->method('load')
+      ->willReturnMap([
+        ['this', $view_this],
+        ['other', $view_other]
+    ]);
+    $this->viewHandler->view->storage = $view_this;
+
+
+    $this->viewHandler->options['view_to_insert'] = 'other:default';
+    $this->assertArrayEquals(array('config' => array('view.other')), $this->viewHandler->calculateDependencies());
+
+    $this->viewHandler->options['view_to_insert'] = 'this:default';
+    $this->assertArrayEquals(array(), $this->viewHandler->calculateDependencies());
+  }
+
+}