Issue #3273325 by Dom., Wim Leers, andregp, ifrik: CKE5 and contrib: better "next action" description on upgrade path messages
(cherry picked from commit dafde75531)
merge-requests/1809/merge
Alex Pott
parent
12e8b703f8
commit
0936710171
|
|
@ -18,6 +18,7 @@ use Drupal\Core\Form\FormStateInterface;
|
|||
use Drupal\Core\Form\SubformState;
|
||||
use Drupal\Core\Form\SubformStateInterface;
|
||||
use Drupal\Core\Language\LanguageManagerInterface;
|
||||
use Drupal\Core\Messenger\MessengerInterface;
|
||||
use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
|
||||
use Drupal\ckeditor5\SmartDefaultSettings;
|
||||
use Drupal\Core\Validation\Plugin\Validation\Constraint\PrimitiveTypeConstraint;
|
||||
|
|
@ -263,8 +264,15 @@ class CKEditor5 extends EditorBase implements ContainerFactoryPluginInterface {
|
|||
assert($editor->getSettings() === $this->getDefaultSettings());
|
||||
if (!$format->isNew()) {
|
||||
[$editor, $messages] = $this->smartDefaultSettings->computeSmartDefaultSettings($editor, $format);
|
||||
foreach ($messages as $message) {
|
||||
$this->messenger()->addMessage($message);
|
||||
foreach ($messages as $type => $messages_per_type) {
|
||||
foreach ($messages_per_type as $message) {
|
||||
$this->messenger()->addMessage($message, $type);
|
||||
}
|
||||
}
|
||||
if (isset($messages[MessengerInterface::TYPE_WARNING]) || isset($messages[MessengerInterface::TYPE_ERROR])) {
|
||||
$this->messenger()->addMessage($this->t('Check <a href=":handbook">this handbook page</a> for details about compatibility issues of contrib modules.', [
|
||||
':handbook' => 'https://www.drupal.org/node/3273985',
|
||||
]), MessengerInterface::TYPE_WARNING);
|
||||
}
|
||||
}
|
||||
$eventual_editor_and_format = $this->getEventualEditorWithPrimedFilterFormat($form_state, $editor);
|
||||
|
|
|
|||
|
|
@ -12,6 +12,7 @@ use Drupal\ckeditor5\Plugin\CKEditor5PluginElementsSubsetInterface;
|
|||
use Drupal\ckeditor5\Plugin\CKEditor5PluginManagerInterface;
|
||||
use Drupal\Component\Assertion\Inspector;
|
||||
use Drupal\Component\Plugin\PluginManagerInterface;
|
||||
use Drupal\Core\Messenger\MessengerInterface;
|
||||
use Drupal\Core\StringTranslation\StringTranslationTrait;
|
||||
use Drupal\editor\EditorInterface;
|
||||
use Drupal\editor\Entity\Editor;
|
||||
|
|
@ -141,27 +142,27 @@ final class SmartDefaultSettings {
|
|||
$unsupported = $missing->diff($missing_attributes);
|
||||
|
||||
if ($enabling_message_content) {
|
||||
$messages[] = $this->t('The following plugins were enabled to support tags that are allowed by this text format: %enabling_message_content.',
|
||||
$messages[MessengerInterface::TYPE_STATUS][] = $this->t('The following plugins were enabled to support tags that are allowed by this text format: %enabling_message_content.',
|
||||
['%enabling_message_content' => $enabling_message_content],
|
||||
);
|
||||
}
|
||||
// Warn user about unsupported tags.
|
||||
if (!$unsupported->isEmpty()) {
|
||||
$this->addTagsToSourceEditing($editor, $unsupported);
|
||||
$messages[] = $this->t("The following tags were permitted by this format's filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: @unsupported_string.", [
|
||||
$messages[MessengerInterface::TYPE_STATUS][] = $this->t("The following tags were permitted by this format's filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: @unsupported_string.", [
|
||||
'@unsupported_string' => $unsupported->toFilterHtmlAllowedTagsString(),
|
||||
]);
|
||||
}
|
||||
|
||||
if ($enabled_for_attributes_message_content) {
|
||||
$messages[] = $this->t('The following plugins were enabled to support specific attributes that are allowed by this text format: %enabled_for_attributes_message_content.',
|
||||
$messages[MessengerInterface::TYPE_STATUS][] = $this->t('The following plugins were enabled to support specific attributes that are allowed by this text format: %enabled_for_attributes_message_content.',
|
||||
['%enabled_for_attributes_message_content' => $enabled_for_attributes_message_content],
|
||||
);
|
||||
}
|
||||
// Warn user about supported tags but missing attributes.
|
||||
if (!$missing_attributes->isEmpty()) {
|
||||
$this->addTagsToSourceEditing($editor, $missing_attributes);
|
||||
$messages[] = $this->t("This format's HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: @missing_attributes.", [
|
||||
$messages[MessengerInterface::TYPE_STATUS][] = $this->t("This format's HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: @missing_attributes.", [
|
||||
'@missing_attributes' => $missing_attributes->toFilterHtmlAllowedTagsString(),
|
||||
]);
|
||||
}
|
||||
|
|
@ -181,7 +182,7 @@ final class SmartDefaultSettings {
|
|||
$messages = [];
|
||||
$settings = $editor->getSettings();
|
||||
if (!isset($settings['toolbar']['items']) || !in_array('sourceEditing', $settings['toolbar']['items'])) {
|
||||
$messages[] = $this->t('The <em>Source Editing</em> plugin was enabled to support tags and/or attributes that are not explicitly supported by any available CKEditor 5 plugins.');
|
||||
$messages[MessengerInterface::TYPE_STATUS][] = $this->t('The <em>Source Editing</em> plugin was enabled to support tags and/or attributes that are not explicitly supported by any available CKEditor 5 plugins.');
|
||||
$settings['toolbar']['items'][] = 'sourceEditing';
|
||||
}
|
||||
$allowed_tags_array = $settings['plugins']['ckeditor5_sourceEditing']['allowed_tags'] ?? [];
|
||||
|
|
@ -232,7 +233,7 @@ final class SmartDefaultSettings {
|
|||
$equivalent = $this->upgradePluginManager->mapCKEditor4ToolbarButtonToCKEditor5ToolbarItem($cke4_button, $text_format_html_restrictions);
|
||||
}
|
||||
catch (\OutOfBoundsException $e) {
|
||||
$messages[] = $this->t('The CKEditor 4 button %button does not have a known upgrade path. If it allowed editing markup, then you can do so now through the Source Editing functionality.', [
|
||||
$messages[MessengerInterface::TYPE_WARNING][] = $this->t('The CKEditor 4 button %button does not have a known upgrade path. If it allowed editing markup, then you can do so now through the Source Editing functionality.', [
|
||||
'%button' => $cke4_button,
|
||||
]);
|
||||
continue;
|
||||
|
|
@ -270,7 +271,7 @@ final class SmartDefaultSettings {
|
|||
$settings['plugins'] += $cke5_plugin_settings;
|
||||
}
|
||||
catch (\OutOfBoundsException $e) {
|
||||
$messages[] = $this->t('The %cke4_plugin_id plugin settings do not have a known upgrade path.', [
|
||||
$messages[MessengerInterface::TYPE_WARNING][] = $this->t('The %cke4_plugin_id plugin settings do not have a known upgrade path.', [
|
||||
'%cke4_plugin_id' => $cke4_plugin_id,
|
||||
]);
|
||||
continue;
|
||||
|
|
@ -762,7 +763,7 @@ final class SmartDefaultSettings {
|
|||
$subset_configuration = $this->upgradePluginManager->computeCKEditor5PluginSubsetConfiguration($plugin_name, $text_format);
|
||||
}
|
||||
catch (\OutOfBoundsException $e) {
|
||||
$messages[] = $this->t('The CKEditor 5 plugin %button has a configurable subset of elements, but does not have a known upgrade path to configure that subset to match your text format. Hence it is now using its default configuration.', [
|
||||
$messages[MessengerInterface::TYPE_WARNING][] = $this->t('The CKEditor 5 plugin %button has a configurable subset of elements, but does not have a known upgrade path to configure that subset to match your text format. Hence it is now using its default configuration.', [
|
||||
'%plugin' => $plugin_name,
|
||||
]);
|
||||
continue;
|
||||
|
|
|
|||
|
|
@ -404,9 +404,13 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
// The resulting pair should be valid.
|
||||
$this->assertSame([], $this->validatePairToViolationsArray($updated_text_editor, $updated_text_format, TRUE));
|
||||
|
||||
foreach ($messages as $key => $message) {
|
||||
$messages[$key] = (string) $message;
|
||||
// Transforms TranslatableMarkup objects to string.
|
||||
foreach ($messages as $type => $messages_per_type) {
|
||||
foreach ($messages_per_type as $key => $message) {
|
||||
$messages[$type][$key] = (string) $message;
|
||||
}
|
||||
}
|
||||
|
||||
$this->assertSame($expected_messages, $messages);
|
||||
}
|
||||
|
||||
|
|
@ -484,8 +488,10 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
'expected_superset' => '<span lang dir>',
|
||||
'expected_fundamental_compatibility_violations' => [],
|
||||
'expected_messages' => [
|
||||
'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Code (for tags: <code>) Language (for tags: <span>)</em>.',
|
||||
'The following tags were permitted by this format\'s filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <cite> <dl> <dt> <dd>.',
|
||||
'status' => [
|
||||
'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Code (for tags: <code>) Language (for tags: <span>)</em>.',
|
||||
'The following tags were permitted by this format\'s filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <cite> <dl> <dt> <dd>.',
|
||||
],
|
||||
],
|
||||
];
|
||||
|
||||
|
|
@ -493,7 +499,9 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
$basic_html_test_case,
|
||||
[
|
||||
'expected_messages' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
'status' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
],
|
||||
],
|
||||
]
|
||||
);
|
||||
|
|
@ -514,7 +522,9 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
],
|
||||
],
|
||||
'expected_messages' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id> <img data-caption>.',
|
||||
'status' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id> <img data-caption>.',
|
||||
],
|
||||
],
|
||||
]);
|
||||
|
||||
|
|
@ -534,7 +544,9 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
],
|
||||
],
|
||||
'expected_messages' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id> <img data-align>.',
|
||||
'status' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id> <img data-align>.',
|
||||
],
|
||||
],
|
||||
]);
|
||||
|
||||
|
|
@ -563,10 +575,11 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
],
|
||||
'expected_superset' => $basic_html_test_case['expected_superset'],
|
||||
'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],
|
||||
'expected_messages' => array_merge(
|
||||
$basic_html_test_case['expected_messages'],
|
||||
['This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h5 id>.'],
|
||||
),
|
||||
'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [
|
||||
'status' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h5 id>.',
|
||||
],
|
||||
]),
|
||||
];
|
||||
|
||||
yield "basic_html_with_h1 can be switched to CKEditor 5 without problems, heading configuration computed automatically" => [
|
||||
|
|
@ -594,10 +607,11 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
],
|
||||
'expected_superset' => $basic_html_test_case['expected_superset'],
|
||||
'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],
|
||||
'expected_messages' => array_merge(
|
||||
$basic_html_test_case['expected_messages'],
|
||||
['This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.'],
|
||||
),
|
||||
'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [
|
||||
'status' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
],
|
||||
]),
|
||||
];
|
||||
|
||||
yield "basic_html_without_headings can be switched to CKEditor 5 without problems, heading configuration computed automatically" => [
|
||||
|
|
@ -623,10 +637,11 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
],
|
||||
'expected_superset' => $basic_html_test_case['expected_superset'],
|
||||
'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],
|
||||
'expected_messages' => array_merge(
|
||||
$basic_html_test_case['expected_messages'],
|
||||
['This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type>.'],
|
||||
),
|
||||
'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [
|
||||
'status' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type>.',
|
||||
],
|
||||
]),
|
||||
];
|
||||
|
||||
yield "basic_html_with_pre can be switched to CKEditor 5 without problems, heading configuration computed automatically" => [
|
||||
|
|
@ -644,9 +659,11 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
'expected_superset' => '<code class="language-*"> ' . $basic_html_test_case['expected_superset'],
|
||||
'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],
|
||||
'expected_messages' => [
|
||||
'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Code (for tags: <code>) Language (for tags: <span>) Code Block (for tags: <pre>)</em>.',
|
||||
$basic_html_test_case['expected_messages'][1],
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
'status' => [
|
||||
'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Code (for tags: <code>) Language (for tags: <span>) Code Block (for tags: <pre>)</em>.',
|
||||
$basic_html_test_case['expected_messages']['status'][1],
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
],
|
||||
],
|
||||
];
|
||||
|
||||
|
|
@ -682,12 +699,12 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
$basic_html_test_case['expected_superset'],
|
||||
]),
|
||||
'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],
|
||||
'expected_messages' => array_merge($basic_html_test_case['expected_messages'],
|
||||
|
||||
[
|
||||
'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [
|
||||
'status' => [
|
||||
'The following plugins were enabled to support specific attributes that are allowed by this text format: <em class="placeholder">Align center ( for tag: <p> to support: class with value(s): text-align-center), Justify ( for tag: <p> to support: class with value(s): text-align-justify)</em>.',
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
]),
|
||||
],
|
||||
]),
|
||||
];
|
||||
|
||||
yield "basic_html with media_embed added => <drupal-media> needed => supported through sourceEditing (3 upgrade messages)" => [
|
||||
|
|
@ -706,8 +723,10 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
// @todo: Remove data-view-mode in https://www.drupal.org/project/drupal/issues/3269657.
|
||||
'expected_superset' => $basic_html_test_case['expected_superset'] . ' <drupal-media data-view-mode>',
|
||||
'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],
|
||||
'expected_messages' => array_merge($basic_html_test_case['expected_messages'], [
|
||||
"This format's HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.",
|
||||
'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [
|
||||
'status' => [
|
||||
"This format's HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.",
|
||||
],
|
||||
]),
|
||||
];
|
||||
|
||||
|
|
@ -727,10 +746,11 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
],
|
||||
'expected_superset' => $basic_html_test_case['expected_superset'],
|
||||
'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],
|
||||
'expected_messages' => array_merge($basic_html_test_case['expected_messages'],
|
||||
[
|
||||
'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [
|
||||
'status' => [
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id> <img data-*>.',
|
||||
]),
|
||||
],
|
||||
]),
|
||||
];
|
||||
|
||||
yield "restricted_html can be switched to CKEditor 5 after dropping the two markup-creating filters (3 upgrade messages)" => [
|
||||
|
|
@ -793,9 +813,14 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
'' => 'CKEditor 5 needs at least the <p> and <br> tags to be allowed to be able to function. They are not allowed by the "<em class="placeholder">Limit allowed HTML tags and correct faulty HTML</em>" (<em class="placeholder">filter_html</em>) filter.',
|
||||
],
|
||||
'expected_messages' => [
|
||||
'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Link (for tags: <a>) Block quote (for tags: <blockquote>) Code (for tags: <code>) List (for tags: <ul><ol><li>)</em>.',
|
||||
'The following tags were permitted by this format\'s filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <cite> <dl> <dt> <dd>.',
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
'status' => [
|
||||
'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Link (for tags: <a>) Block quote (for tags: <blockquote>) Code (for tags: <code>) List (for tags: <ul><ol><li>)</em>.',
|
||||
'The following tags were permitted by this format\'s filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <cite> <dl> <dt> <dd>.',
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
],
|
||||
],
|
||||
'expected_post_filter_drop_fundamental_compatibility_violations' => [
|
||||
'' => 'CKEditor 5 needs at least the <p> and <br> tags to be allowed to be able to function. They are not allowed by the "<em class="placeholder">Limit allowed HTML tags and correct faulty HTML</em>" (<em class="placeholder">filter_html</em>) filter.',
|
||||
],
|
||||
];
|
||||
|
||||
|
|
@ -905,9 +930,11 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
'' => 'CKEditor 5 needs at least the <p> and <br> tags to be allowed to be able to function. They are not allowed by the "<em class="placeholder">Limit allowed HTML tags and correct faulty HTML</em>" (<em class="placeholder">filter_html</em>) filter.',
|
||||
],
|
||||
'expected_messages' => [
|
||||
'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Link (for tags: <a>) Block quote (for tags: <blockquote>) Code (for tags: <code>) List (for tags: <ul><ol><li>)</em>.',
|
||||
'The following tags were permitted by this format\'s filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <cite> <dl> <dt> <dd>.',
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type="1 A I"> <h2 id="jump-*"> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
'status' => [
|
||||
'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Link (for tags: <a>) Block quote (for tags: <blockquote>) Code (for tags: <code>) List (for tags: <ul><ol><li>)</em>.',
|
||||
'The following tags were permitted by this format\'s filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <cite> <dl> <dt> <dd>.',
|
||||
'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: <a hreflang> <blockquote cite> <ul type> <ol start type="1 A I"> <h2 id="jump-*"> <h3 id> <h4 id> <h5 id> <h6 id>.',
|
||||
],
|
||||
],
|
||||
];
|
||||
|
||||
|
|
@ -929,8 +956,10 @@ class SmartDefaultSettingsTest extends KernelTestBase {
|
|||
'expected_superset' => '',
|
||||
'expected_fundamental_compatibility_violations' => [],
|
||||
'expected_messages' => [
|
||||
'The CKEditor 4 button <em class="placeholder">Llama</em> does not have a known upgrade path. If it allowed editing markup, then you can do so now through the Source Editing functionality.',
|
||||
'The <em class="placeholder">llama_contextual_and_button</em> plugin settings do not have a known upgrade path.',
|
||||
'warning' => [
|
||||
'The CKEditor 4 button <em class="placeholder">Llama</em> does not have a known upgrade path. If it allowed editing markup, then you can do so now through the Source Editing functionality.',
|
||||
'The <em class="placeholder">llama_contextual_and_button</em> plugin settings do not have a known upgrade path.',
|
||||
],
|
||||
],
|
||||
];
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue