Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3221933 by marcoscano, alexpott, owenbush: PHP Notice when using "left_formula" in views join

merge-requests/927/head
Alex Pott 2021-07-10 09:58:37 +01:00
parent 3e4b17a7c9
commit 0926b0cc7c
No known key found for this signature in database
GPG Key ID: 31905460D4A69276
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/modules/views/src/Plugin/views/join/JoinPluginBase.php
View File

@ -266,7 +266,11 @@ class JoinPluginBase extends PluginBase implements JoinPluginInterface {
}
$this->leftTable = $configuration['left_table'];
$this->leftField = $configuration['left_field'];
if (!empty($configuration['left_field'])) {
$this->leftField = $configuration['left_field'];
}
$this->field = $configuration['field'];
if (!empty($configuration['left_formula'])) {

2
core/modules/views/tests/src/Kernel/Plugin/JoinTest.php
View File

@ -205,6 +205,8 @@ class JoinTest extends RelationshipJoinTestBase {
// Test that joins using 'left_formula' are properly built.
$configuration['left_formula'] = 'MAX(views_test_data.uid)';
// When 'left_formula' is present, 'left_field' is no longer required.
unset($configuration['left_field']);
$join = $this->manager->createInstance('standard', $configuration);
$table = ['alias' => 'users6'];
$join->buildJoin($query, $table, $view->query);