Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2186115 by chakrapani, longwave, jhodgdon, benjy, chrischinchilla, swentel: Shortcuts are added with no link title (hence unusable).

8.0.x
webchick 2014-02-24 12:12:19 -08:00
parent 0a4239109b
commit 04c9a71dbe
2 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
core/modules/shortcut/lib/Drupal/shortcut/Tests/ShortcutLinksTest.php
View File

@ -68,18 +68,33 @@ class ShortcutLinksTest extends ShortcutTestBase {
} }
/** /**
* Tests that the "add to shortcut" link changes to "remove shortcut". * Tests that the "add to shortcut" and "remove from shortcut" links work.
*/ */
public function testShortcutQuickLink() { public function testShortcutQuickLink() {
theme_enable(array('seven')); theme_enable(array('seven'));
\Drupal::config('system.theme')->set('admin', 'seven')->save(); \Drupal::config('system.theme')->set('admin', 'seven')->save();
$this->container->get('config.factory')->get('node.settings')->set('use_admin_theme', '1')->save(); $this->container->get('config.factory')->get('node.settings')->set('use_admin_theme', '1')->save();
$shortcuts = $this->set->getShortcuts(); $this->drupalLogin($this->root_user);
$shortcut = reset($shortcuts); $this->drupalGet('admin/config/system/cron');
$this->drupalGet($shortcut->path->value); // Test the "Add to shortcuts" link.
$this->assertRaw(t('Remove from %title shortcuts', array('%title' => $this->set->label())), '"Add to shortcuts" link properly switched to "Remove from shortcuts".'); $this->clickLink('Add to Default shortcuts');
$this->assertText('Added a shortcut for Cron.');
$this->assertLink('Cron', 0, 'Shortcut link found on page');
$this->drupalGet('admin/structure');
$this->assertLink('Cron', 0, 'Shortcut link found on different page');
// Test the "Remove from shortcuts" link.
$this->clickLink('Cron');
$this->clickLink('Remove from Default shortcuts');
$this->drupalPostForm(NULL, array(), 'Delete');
$this->assertText('The shortcut Cron has been deleted.');
$this->assertNoLink('Cron', 'Shortcut link removed from page');
$this->drupalGet('admin/structure');
$this->assertNoLink('Cron', 'Shortcut link removed from different page');
} }
/** /**

4
core/modules/shortcut/shortcut.module
View File

@ -407,8 +407,8 @@ function shortcut_preprocess_page(&$variables) {
} }
$query = array( $query = array(
'link' => $link, 'link' => $link,
'name' => drupal_get_title(), 'name' => $variables['title'],
); );
$query += drupal_get_destination(); $query += drupal_get_destination();