From 02c2f2c1886a094a89cf4adf7f10eddd55a632d6 Mon Sep 17 00:00:00 2001 From: quietone Date: Wed, 14 Feb 2024 16:50:40 +1300 Subject: [PATCH] Issue #3404508 by mstrelan, smustgrave, larowlan, quietone: Fix strict type errors in Functional tests: Add casts and fix types where needed --- .../tests/src/Functional/BigPipeTest.php | 40 ++++----- .../src/Functional/BookBreadcrumbTest.php | 2 +- .../tests/src/Functional/BookTestTrait.php | 2 +- .../src/Functional/CommentThreadingTest.php | 10 +-- .../src/Functional/ConfigEntityListTest.php | 2 +- ...figInstallProfileUnmetDependenciesTest.php | 2 +- .../src/Functional/Number/NumberFieldTest.php | 2 +- .../src/Functional/ManageDisplayTest.php | 2 +- .../Functional/FileOnTranslatedEntityTest.php | 2 +- .../PrivateFileOnTranslatedEntityTest.php | 2 +- .../src/Functional/ImageDimensionsTest.php | 2 +- .../src/Functional/ImageFieldDisplayTest.php | 20 ++--- .../tests/src/Functional/BlockContentTest.php | 2 +- .../EntityTestComputedFieldTest.php | 2 +- .../src/Functional/EntityTestMapFieldTest.php | 2 +- .../tests/src/Functional/EntityTestTest.php | 2 +- .../JsonApiFunctionalDateFieldTest.php | 6 +- .../tests/src/Functional/MediaTest.php | 2 +- .../src/Functional/MenuLinkContentTest.php | 2 +- .../tests/src/Functional/ResourceTestBase.php | 4 +- .../jsonapi/tests/src/Functional/TermTest.php | 2 +- .../src/Functional/LocalePluralFormatTest.php | 2 +- .../ResponsiveImageFieldDisplayTest.php | 4 +- .../src/Functional/ShortcutLinksTest.php | 2 +- .../src/Functional/Form/CheckboxTest.php | 2 +- .../System/SitesDirectoryHardeningTest.php | 2 +- .../Functional/Theme/TwigDebugMarkupTest.php | 8 +- .../tests/src/Functional/TrackerTest.php | 14 ++-- .../src/Functional/UserLoginHttpTest.php | 22 ++--- .../Views/HandlerFieldUserNameTest.php | 8 +- .../tests/src/Functional/Handler/AreaTest.php | 2 +- .../src/Functional/Handler/FieldWebTest.php | 82 +++++++++---------- .../Functional/Plugin/DisplayPageWebTest.php | 8 +- .../src/Functional/Plugin/DisplayTest.php | 22 ++--- .../tests/src/Functional/Plugin/PagerTest.php | 2 +- 35 files changed, 146 insertions(+), 146 deletions(-) diff --git a/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php b/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php index 0a5899ba9194..86a4ec44753e 100644 --- a/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php +++ b/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php @@ -81,19 +81,19 @@ class BigPipeTest extends BrowserTestBase { // 1. No session (anonymous). $this->drupalGet(Url::fromRoute('')); - $this->assertSessionCookieExists(FALSE); - $this->assertBigPipeNoJsCookieExists(FALSE); + $this->assertSessionCookieExists('0'); + $this->assertBigPipeNoJsCookieExists('0'); $this->assertSession()->responseNotContains(''); $this->assertSession()->responseNotContains($no_js_to_js_markup); $this->assertBigPipeNoJsMetaRefreshRedirect(); - $this->assertBigPipeNoJsCookieExists(TRUE); + $this->assertBigPipeNoJsCookieExists('1'); $this->assertSession()->responseNotContains(''); $this->assertSession()->responseNotContains($no_js_to_js_markup); $this->assertBigPipeNoJsMetaRefreshRedirect(); - $this->assertBigPipeNoJsCookieExists(TRUE); + $this->assertBigPipeNoJsCookieExists('1'); $this->assertSession()->responseNotContains('