Issue #3333401 by nicxvan, bnjmnm: Pager h4 causes accessibility flag on many pages

merge-requests/3289/head
Lauri Eskola 2023-01-25 12:03:43 +02:00
parent 7347556c05
commit 01de0a8421
No known key found for this signature in database
GPG Key ID: 382FC0F5B0DF53F8
9 changed files with 9 additions and 18 deletions

View File

@ -33,8 +33,7 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}

View File

@ -13,8 +13,7 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="js-pager__items"> <ul class="js-pager__items">
{% if items.previous %} {% if items.previous %}
<li> <li>

View File

@ -11,8 +11,7 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="pager__heading visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{% if items.previous %} {% if items.previous %}
<li class="pager__item pager__item--previous"> <li class="pager__item pager__item--previous">

View File

@ -35,8 +35,7 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}

View File

@ -18,8 +18,7 @@
] ]
%} %}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav{{ attributes.addClass('pager').setAttribute('role', 'navigation').setAttribute('aria-labelledby', heading_id) }}> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4{{ title_attributes.addClass('visually-hidden').setAttribute('id', heading_id) }}>{{ 'Pagination'|t }}</h4>
<ul{{ content_attributes.addClass('pager__items', 'js-pager__items') }}> <ul{{ content_attributes.addClass('pager__items', 'js-pager__items') }}>
{% if items.previous %} {% if items.previous %}
{% apply spaceless %} {% apply spaceless %}

View File

@ -31,8 +31,7 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager layout--content-medium" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}

View File

@ -11,8 +11,7 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print previous item if we are not on the first page. #} {# Print previous item if we are not on the first page. #}
{% if items.previous %} {% if items.previous %}

View File

@ -31,8 +31,7 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}

View File

@ -11,8 +11,7 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}"> <nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}">
<h4 id="{{ heading_id }}" class="pager__heading visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{% if items.previous %} {% if items.previous %}
<li class="pager__item pager__item--previous"> <li class="pager__item pager__item--previous">