BusyBox
/
busybox
mirror of https://github.com/mirror/busybox.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

- use xregcomp. Untested. vda, isn't there a regfree missing here? 

text    data     bss     dec     hex filename
   2522       0       0    2522     9da expr.o.r18305
   2478       0       0    2478     9ae expr.o
1_6_stable
Bernhard Reutner-Fischer 2007-04-02 16:54:41 +00:00
parent 3c5929a53b
commit 8025afad8a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
coreutils/expr.c
View File

@ -226,8 +226,7 @@ of a basic regular expression is not portable; it is being ignored", pv->u.s);
memset(&re_buffer, 0, sizeof(re_buffer)); memset(&re_buffer, 0, sizeof(re_buffer));
memset(re_regs, 0, sizeof(*re_regs)); memset(re_regs, 0, sizeof(*re_regs));
if (regcomp(&re_buffer, pv->u.s, 0) != 0) xregcomp(&re_buffer, pv->u.s, 0);
bb_error_msg_and_die("invalid regular expression");
/* expr uses an anchored pattern match, so check that there was a /* expr uses an anchored pattern match, so check that there was a
* match and that the match starts at offset 0. */ * match and that the match starts at offset 0. */
@ -246,6 +245,7 @@ of a basic regular expression is not portable; it is being ignored", pv->u.s);
else else
v = int_value(0); v = int_value(0);
} }
//FIXME: sounds like here is a bit missing: regfree(&re_buffer);
return v; return v;
} }