chore(argocd-applicationset): Don't exclude chart anymore (#977)

* chore(argocd-applicationset): Don't exclude chart anymore

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

* Bump chart argocd-applicationset

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

* Bump minor chart version

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

.github/configs/ct-install.yaml

@@ -15,5 +15,4 @@ validate-chart-schema: false
 validate-maintainers: true
 validate-yaml: true
 exclude-deprecated: true
-excluded-charts: 
-  - "argocd-applicationset"
+excluded-charts: []

.github/workflows/lint-and-test.yml

@@ -40,6 +40,14 @@ jobs:
         uses: helm/kind-action@v1.2.0
         if: steps.list-changed.outputs.changed == 'true'
 
+      - name: Deploy latest ArgoCD CRDs when testing ArgoCD extensions
+        if: |
+          contains(steps.list-changed.outputs.changed_charts, 'argocd-applicationset') ||
+          contains(steps.list-changed.outputs.changed_charts, 'argocd-image-updater') ||
+          contains(steps.list-changed.outputs.changed_charts, 'argocd-notifications')
+        run: |
+          kubectl apply -f charts/argo-cd/crds
+
       - name: Run chart-testing (install)
         run: ct install --config ./.github/configs/ct-install.yaml
         if: steps.list-changed.outputs.changed == 'true'

charts/argocd-applicationset/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: argocd-applicationset
 description: A Helm chart for installing ArgoCD ApplicationSet
 type: application
-version: 1.5.1
+version: 1.6.0
 appVersion: "v0.2.0"
 home: https://github.com/argoproj/argo-helm
 icon: https://argocd-applicationset.readthedocs.io/en/stable/assets/logo.png
@@ -14,4 +14,5 @@ maintainers:
   - name: maruina
 annotations:
   artifacthub.io/changes: |
-    - "[Removed]: Duplicated default values during chart testing"
+    - "[Added]: Install the chart into a kind cluster during the chart testing process"
+    - "[Changed]: Parameter 'args.namespace' now defaults to the namespace where you install the chart to"

charts/argocd-applicationset/README.md

@@ -62,7 +62,7 @@ kubectl apply -k https://github.com/argoproj-labs/applicationset.git/manifests/c
 | args.dryRun | bool | `false` | Enable dry run mode |
 | args.enableLeaderElection | bool | `false` | The default leader election setting |
 | args.metricsAddr | string | `":8080"` | The default metric address |
-| args.namespace | string | `"argocd"` | The default Argo CD repo namespace |
+| args.namespace | string | `""` | Namespace where ArgoCD is deployed to (defaults to .Release.Namespace) |
 | args.policy | string | `"sync"` | How application is synced between the generator and the cluster |
 | args.probeBindAddr | string | `":8081"` | The default health check port |
 | extraArgs | list | `[]` | List of extra cli args to add |

charts/argocd-applicationset/ci/default-values.yaml

@@ -1 +1,6 @@
 # Test with default values
+
+# Disable mounts of ArgoCD related ConfigMaps as ArgoCD isn't installed during chart testing
+mountSSHKnownHostsVolume: false
+mountTLSCertsVolume: false
+mountGPGKeysVolume: false

charts/argocd-applicationset/ci/leader-election-values.yaml

@@ -2,3 +2,8 @@ args:
   enableLeaderElection: true
 
 replicaCount: 3
+
+# Disable mounts of ArgoCD related ConfigMaps as ArgoCD isn't installed during chart testing
+mountSSHKnownHostsVolume: false
+mountTLSCertsVolume: false
+mountGPGKeysVolume: false

charts/argocd-applicationset/templates/deployment.yaml

@@ -39,7 +39,7 @@ spec:
             {{- if or (gt ( .Values.replicaCount | int64) 1) .Values.args.enableLeaderElection }}
             - --enable-leader-election=true
             {{- end }}
-            - --namespace={{ .Values.args.namespace }}
+            - --namespace={{ .Values.args.namespace | default .Release.Namespace }}
             - --argocd-repo-server={{ .Values.args.argocdRepoServer }}
             - --policy={{ .Values.args.policy }}
             - --debug={{ .Values.args.debug }}

charts/argocd-applicationset/values.yaml

@@ -20,8 +20,8 @@ args:
   probeBindAddr: :8081
   # -- The default leader election setting
   enableLeaderElection: false
-  # -- The default Argo CD repo namespace
-  namespace: argocd
+  # -- Namespace where ArgoCD is deployed to (defaults to .Release.Namespace)
+  namespace: ""
   # -- The default Argo CD repo server address
   argocdRepoServer: argocd-repo-server:8081
   # -- How application is synced between the generator and the cluster