fix(argo-cd): Use global imagePullPolicy for Dex (#1250)

* fix(argo-cd): Use global imagePullPolicy for Dex

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* fix(argo-cd): Fix imagePullPolicy for ApplicationSet

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Use default image pull policy for applicationset

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Bump chart version

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Update documentatioj

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Update changelog

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Update changelog

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Remove default comments

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Bump chart version

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

charts/argo-cd/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: v2.3.3
 description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
 name: argo-cd
-version: 4.5.9
+version: 4.5.10
 home: https://github.com/argoproj/argo-helm
 icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
 keywords:
@@ -21,4 +21,6 @@ dependencies:
     condition: redis-ha.enabled
 annotations:
   artifacthub.io/changes: |
-    - "[Fix]: Remove version dependencies in README for CRD paths"
+    - "[Fixed]: Use global imagePullPolicy for Dex by default"
+    - "[Fixed]: ApplicationSet imagePullPolicy variable in values.yaml"
+    - "[Fixed]: Use global imagePullPolicy for ApplicationSet by default"

charts/argo-cd/README.md

@@ -548,7 +548,7 @@ NAME: my-release
 | dex.extraContainers | list | `[]` | Additional containers to be added to the dex pod |
 | dex.extraVolumeMounts | list | `[]` | Extra volumeMounts to the dex pod |
 | dex.extraVolumes | list | `[]` | Extra volumes to the dex pod |
-| dex.image.imagePullPolicy | string | `"IfNotPresent"` | Dex imagePullPolicy |
+| dex.image.imagePullPolicy | string | `""` (defaults to global.image.imagePullPolicy) | Dex imagePullPolicy |
 | dex.image.repository | string | `"ghcr.io/dexidp/dex"` | Dex image repository |
 | dex.image.tag | string | `"v2.30.2"` | Dex image tag |
 | dex.initContainers | list | `[]` | Init containers to add to the dex pod |
@@ -688,7 +688,7 @@ NAME: my-release
 | applicationSet.extraEnvFrom | list | `[]` (See [values.yaml]) | envFrom to pass to the controller |
 | applicationSet.extraVolumeMounts | list | `[]` | List of extra mounts to add (normally used with extraVolumes) |
 | applicationSet.extraVolumes | list | `[]` | List of extra volumes to add |
-| applicationSet.image.pullPolicy | string | `"IfNotPresent"` | Image pull policy for the application set controller |
+| applicationSet.image.imagePullPolicy | string | `""` (defaults to global.image.imagePullPolicy) | Image pull policy for the application set controller |
 | applicationSet.image.repository | string | `"quay.io/argoproj/argocd-applicationset"` | Repository to use for the application set controller |
 | applicationSet.image.tag | string | `"v0.4.1"` | Tag to use for the application set controller |
 | applicationSet.imagePullSecrets | list | `[]` | If defined, uses a Secret to pull an image from a private Docker registry or repository. |

charts/argo-cd/templates/dex/deployment.yaml

@@ -52,7 +52,7 @@ spec:
       containers:
       - name: {{ .Values.dex.name }}
         image: {{ .Values.dex.image.repository }}:{{ .Values.dex.image.tag }}
-        imagePullPolicy: {{ .Values.dex.image.imagePullPolicy }}
+        imagePullPolicy: {{ default .Values.global.image.imagePullPolicy .Values.dex.image.imagePullPolicy }}
         command:
         - /shared/argocd-dex
         - rundex

charts/argo-cd/values.yaml

@@ -397,7 +397,8 @@ dex:
     # -- Dex image tag
     tag: v2.30.2
     # -- Dex imagePullPolicy
-    imagePullPolicy: IfNotPresent
+    # @default -- `""` (defaults to global.image.imagePullPolicy)
+    imagePullPolicy: ""
   initImage:
     # -- Argo CD init image repository
     # @default -- `""` (defaults to global.image.repository)
@@ -1890,10 +1891,11 @@ applicationSet:
   image:
     # -- Repository to use for the application set controller
     repository: quay.io/argoproj/argocd-applicationset
-    # -- Image pull policy for the application set controller
-    pullPolicy: IfNotPresent
     # -- Tag to use for the application set controller
     tag: "v0.4.1"
+    # -- Image pull policy for the application set controller
+    # @default -- `""` (defaults to global.image.imagePullPolicy)
+    imagePullPolicy: ""
 
   args:
     # -- The default metric address