feat(argo-rollouts): Default to keeping CRD's on helm uninstall (#922)

Signed-off-by: Artem <code@temik.me>

charts/argo-rollouts/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: "v1.0.2"
 description: A Helm chart for Argo Rollouts
 name: argo-rollouts
-version: 2.0.2
+version: 2.1.0
 icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
 home: https://github.com/argoproj/argo-helm
 maintainers:
@@ -11,4 +11,4 @@ maintainers:
   - name: jessesuen
 annotations:
   artifacthub.io/changes: |
-    - "[Fixed]: use image.tag in app labels if provided"
+    - "[Added]: Keep CRDs on Helm uninstall by default, add corresponding option"

charts/argo-rollouts/README.md

@@ -48,6 +48,7 @@ If dashboard is installed by `--set dashboard.enabled=true`, checkout the argo-r
 | controller.metrics.serviceMonitor.additionalLabels | object | `{}` | Labels to be added to the ServiceMonitor |
 | imagePullSecrets | list | `[]` | Registry secret names as an array |
 | installCRDs | bool | `true` | Install and upgrade CRDs |
+| keepCRDs | bool | `true` | Keep CRD's on helm uninstall |
 | crdAnnotations | object | `{}` | Annotations to be added to all CRDs |
 | podAnnotations | object | `{}` | Annotations to be added to the Rollout pods |
 | podLabels | object | `{}` | Labels to be added to the Rollout pods |

charts/argo-rollouts/templates/crds/analysis-run-crd.yaml

@@ -4,6 +4,9 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.5.0
+    {{- if .Values.keepCRDs }}
+    "helm.sh/resource-policy": keep
+    {{- end }}
     {{- if .Values.crdAnnotations }}
     {{- toYaml .Values.crdAnnotations | nindent 4 }}
     {{- end }}

charts/argo-rollouts/templates/crds/analysis-template-crd.yaml

@@ -4,6 +4,9 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.5.0
+    {{- if .Values.keepCRDs }}
+    "helm.sh/resource-policy": keep
+    {{- end }}
     {{- if .Values.crdAnnotations }}
     {{- toYaml .Values.crdAnnotations | nindent 4 }}
     {{- end }}

charts/argo-rollouts/templates/crds/cluster-analysis-template-crd.yaml

@@ -4,6 +4,9 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.5.0
+    {{- if .Values.keepCRDs }}
+    "helm.sh/resource-policy": keep
+    {{- end }}
     {{- if .Values.crdAnnotations }}
     {{- toYaml .Values.crdAnnotations | nindent 4 }}
     {{- end }}

charts/argo-rollouts/templates/crds/experiment-crd.yaml

@@ -4,6 +4,9 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.5.0
+    {{- if .Values.keepCRDs }}
+    "helm.sh/resource-policy": keep
+    {{- end }}
     {{- if .Values.crdAnnotations }}
     {{- toYaml .Values.crdAnnotations | nindent 4 }}
     {{- end }}

charts/argo-rollouts/templates/crds/rollout-crd.yaml

@@ -4,6 +4,9 @@ kind: CustomResourceDefinition
 metadata:
   annotations:
     controller-gen.kubebuilder.io/version: v0.5.0
+    {{- if .Values.keepCRDs }}
+    "helm.sh/resource-policy": keep
+    {{- end }}
     {{- if .Values.crdAnnotations }}
     {{- toYaml .Values.crdAnnotations | nindent 4 }}
     {{- end }}

charts/argo-rollouts/values.yaml

@@ -1,4 +1,5 @@
 installCRDs: true
+keepCRDs: true
 
 clusterInstall: true