ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
mbed-os/libraries/mbed/targets/hal/TARGET_NXP/TARGET_LPC11UXX
History
Adam Green 5d27f98c7b serial_putc() can cause rx bytes to be dropped 
While fixing this issue in the various LPC* ports, I noticed a comment
pointing to this mbed forum post which summarizes this bug quite well:
  https://mbed.org/forum/bugs-suggestions/topic/4473/

This bug was introduced in the following commit:
2662e105c4

The following code was added to serial_putc() as part of this commit:
    uint32_t lsr = obj->uart->LSR;
    lsr = lsr;
    uint32_t thr = obj->uart->THR;
    thr = thr;

As the forum post indicates, this causes the serial_putc() routine to
actually eat an inbound received byte if it exists since reading THR is
really reading the RBR, the Receiver Buffer Register.  This code looks
like code that was probably added so that the developer could take a
snapshot of these registers and look at them in the debugger.  It
probably got committed in error.
 		2013-09-07 00:44:44 -07:00
..
PeripheralNames.h Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
PinNames.h Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
PortNames.h Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
analogin_api.c Cast to matching enumeration type instead of uint32_t 2013-08-13 01:47:19 -07:00
device.h Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
gpio_api.c Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
gpio_irq_api.c Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
gpio_object.h Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
i2c_api.c Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
objects.h Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
pinmap.c Cast to matching enumeration type instead of uint32_t 2013-08-13 01:47:19 -07:00
port_api.c Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
pwmout_api.c Cast to matching enumeration type instead of uint32_t 2013-08-13 01:47:19 -07:00
serial_api.c serial_putc() can cause rx bytes to be dropped 2013-09-07 00:44:44 -07:00
sleep.c Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
spi_api.c Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00
us_ticker.c Add the vendor name as a proper target label 2013-07-03 17:14:43 +01:00