mirror of https://github.com/ARMmbed/mbed-os.git
48cf1c9c80
When a Thread object's stack memory is not provided, its `start()` member function dynamically allocates its stack from the heap. If allocation fails, there is no way to catch it because * `std::nothrow` is missing after the `new` keyword. As Mbed OS is built with `-fno-exceptions` (C++ exceptions disabled), failed allocation results in an unrecoverable fault. * The attempted `nullptr` check, which doesn't work anyway due to the first point, is an assertion instead of error returning. Assertions should be used as a development tool to ensure code behaves correctly. But out-of-memory is a completely valid runtime situation. This commit adds the missing `std::nothrow`, and makes `Thread::start()` return `osErrorNoMemory` if allocation fails so the caller can handle it. Note: A case when a thread should never fail due to lack of memory is the main thread. But the main thread's stack is a pre-allocated array in the static memory, passed to the `Thread()` constructor during thread creation, so it's not impacted by this change. |
||
|---|---|---|
| .. | ||
| ConditionVariable.cpp | ||
| EventFlags.cpp | ||
| Kernel.cpp | ||
| Mutex.cpp | ||
| Semaphore.cpp | ||
| ThisThread.cpp | ||
| Thread.cpp | ||
| rtos_handlers.h | ||
| rtos_idle.h | ||