Janne Kiiskila
04767f3022
AT_CellularDevice.cpp - unused variable err warning
...
We get this compiler warning;
Compile [ 7.9%]: AT_CellularDevice.cpp
[Warning] AT_CellularDevice.cpp@206,18: variable 'err' set but not used [-Wunused-but-set-variable]
Due to the fact, that the code that would actually use this variable
is behind trace flags. Based on review feedback from Antti Kauppila and
Kimmo Väisänen, adding same flagging also for that.
- Reason being - the operation needs to be within the locks.
2019-10-16 11:53:52 +01:00
Ari Parkkila
aea8d824cb
Cellular: Fix BG96 power on and connect
2019-10-16 11:53:52 +01:00
Martin Kojtal
b849bc1e3d
Merge pull request #11201 from mirelachirica/bug_virtual_in_constructor
...
Cellular: Fixed improper AT handler setup through virtual calls in co…
2019-08-20 09:52:28 +02:00
Mirela Chirica
75c823c1a3
Cellular: Fixed improper AT handler setup through virtual calls in constructor
...
Added AT handler setup method to be used for initialisation routines
that are virtual and therefore cannot be called from constructor.
2019-08-16 10:57:37 +03:00
Anna Bridge
797e58a2b3
Merge pull request #11148 from AriParkkila/cell-sim-pin
...
Cellular: Fix SIM pin enter command
2019-08-15 12:49:24 +01:00
Ari Parkkila
ed3562e764
Cellular: Fix shutdown to stop statemachine
2019-08-02 02:26:12 -07:00
Ari Parkkila
cbe2b50a32
Cellular: Fix SIM pin enter command
2019-08-01 03:46:33 -07:00
Antti Kauppila
1ed338ef28
Valgrind & unittest fixes
2019-06-13 15:15:53 +03:00
Antti Kauppila
77e8374058
Cellular: Removed boiler plate code
2019-05-29 16:17:08 +03:00
Ari Parkkila
830b4234e9
Cellular: Fix setting of statemachine timeout
2019-05-09 04:42:30 -07:00
Teppo Järvelin
9d67a8b61c
Cellular: send disconnect to correct ctx
...
Disconnect was sent to all CellularContext classes even it concerned
one specific context. Some disconnect events are still sent to all
context classes. These event are coming from network and ment for all
context classes or event did not specify cid.
2019-04-17 13:53:40 +03:00
Ari Parkkila
e0f8b2116a
Cellular: Fix CellularStateMachine timeout configurations
2019-04-09 22:02:38 -07:00
Teppo Järvelin
fe5f97895b
Cellular: Fix deleting of state machine to correct class
2019-04-08 12:50:29 +03:00
Ari Parkkila
903a6f2e7e
Cellular: Remove compile dependency of UARTSerial
2019-03-12 23:57:43 -07:00
Jari Poyhonen
b6a0892e86
Cellular: clean sensitive information from trace
...
Information removed from the cellular subsystem trace log:
* SIM pin
* APN username and password
Added get_debug() to ATHandler.h to get the current trace state in order
to support suspend/resume of trace output.
2019-02-14 09:22:54 +02:00
Neil MacMullen
f29c5b22a1
Keep style linter happy
2019-02-12 14:37:07 +00:00
Neil MacMullen
a7f4cbcdce
Make a few trivial syntactic changes to better support cross-compilation
2019-02-12 12:01:05 +00:00
Ari Parkkila
c4de2f2f0e
Cellular: Power API updated to match onboard_modem_api
2019-01-22 02:24:45 -08:00
Ari Parkkila
139d506a24
Cellular: Move power on/off to device and remove CellularPower
2019-01-22 02:24:45 -08:00
Mirela Chirica
ba3727b4e8
Cellular: Unit tests for Non-IP socket
2019-01-22 02:24:45 -08:00
Mirela Chirica
d301e13610
Cellular: Non-IP socket and PDP context for EPS control plane data delivery
2019-01-22 02:24:44 -08:00
Teppo Järvelin
84e5013a2d
Cellular: added setting of data carrier support for UART.
2019-01-22 02:23:04 -08:00
Teppo Järvelin
b0d37ebec4
Cellular: Removed unnecessary checks after new
...
After this change we were able to change methods
ATHandler::set_urc_handler and CellularDevice::set_ready_cb to void
and simplify error handling.
2019-01-22 02:23:04 -08:00
Ari Parkkila
c7486b2a0d
Cellular: Added shutdown()
2019-01-22 02:23:04 -08:00
Ari Parkkila
bdddb445a6
Cellular: Moved reset from power to device
2019-01-22 02:23:03 -08:00
Ari Parkkila
0813b969f7
Cellular: Unify set_at_mode and init_module into init()
2019-01-22 02:23:03 -08:00
Ari Parkkila
2dde5a4376
Cellular: Move ready_cb from power to device
2019-01-22 02:23:03 -08:00
Ari Parkkila
e49f90fb0b
Cellular: Move device_ready from power to device
2019-01-22 02:23:03 -08:00
Ari Parkkila
38f79a9b65
Cellular: Move PSM setting from power to device
2019-01-22 02:23:03 -08:00
Teppo Järvelin
22d9105318
Removed CellularSIM interface.
...
Moved methods to classes CellularDevice and CellularInformation.
SIM interface was removed to simplify cellular usage and
methods better suite new classes.
Updated greentea and unit tests.
2019-01-22 02:23:03 -08:00
Teemu Kultala
b87b52a45c
cellular: AT Handler API changes after review
2018-12-14 13:19:03 +02:00
Teemu Kultala
dbdbae3632
cellular: AT Handler API
2018-12-14 13:19:03 +02:00
Ari Parkkila
9bdeb68e74
Cellular: Updated debug prints, and network registration return value
...
Updated cellular debug trace prints:
- Removed unnecessary prints.
- Tracing more in DEBUG level.
- Read/write bytes not printed on big packets.
- Signal quality (RSSI) traced to log network problems.
- Dismissed AT data is traced.
- Modem type and firmware version are traced.
Network registration returns NotRegistered instead of StatusNotAvailable,
because that's not in 3GPP TS 27.007.
2018-11-19 02:55:43 -08:00
Martin Kojtal
a2ae34b0e6
cellular: fix coding style
2018-11-15 07:23:37 +00:00
Teppo Järvelin
14f3740c13
Cellular: fixed cellular greentea tests after major refactoring.
2018-11-13 18:33:55 +02:00
Teppo Järvelin
9fb83024ea
Changed CellularContext to inherit from CellularBase instead of NetworkInterface. \n Changed Device constructor to take Filehandle instead of eventqueue.
2018-11-11 14:13:05 +02:00
Teppo Järvelin
dbbe2ddc59
Cellular: fixed to compile even if CELLULAR_DEVICE and rx/tx are not defined.
2018-11-11 14:13:05 +02:00
Teppo Järvelin
43e08a0adf
Cellular: fixing unit test after refactor.
2018-11-11 14:12:49 +02:00
Teppo Järvelin
ad2abbe887
Cellular: major refactoring while introducing new CellularContext class.
2018-11-11 14:12:49 +02:00
Teppo Järvelin
8880538eba
Cellular: Introduced new state machine to replace old CellularConnectionFSM
...
CellularDevice class own new state machine. Now we don't have to expose state machine
which may change and so we don't have to make API changes if that happens.
EasyCellularConnection uses now CellularDevice instead of old state machine.
2018-11-11 14:11:21 +02:00
Teppo Järvelin
ed7606bf0c
Cellular: fixed crash when closing CellularNetwork via CellularDevice.
2018-09-18 14:45:07 +03:00
Teppo Järvelin
8f4acc14ca
Cellular: CellularDevice:get_default_instance() implemented
...
Removed copy-paste code from targets by creating implementation methods to override.
2018-09-07 14:49:18 +03:00
Ari Parkkila
c6ab45b6e1
Cellular: Added CellularDevice::init_module API to be called at startup
2018-08-01 04:52:10 -07:00
Ari Parkkila
6a3dce839e
Cellular: Updated coding guidelines
2018-05-17 09:02:54 +03:00
Ari Parkkila
a146e0e7ff
Cellular: AT debugging improved
2018-05-16 12:39:30 +03:00
Teppo Järvelin
af0de8ece0
Fixed coverity warnings for class AT_CellularDevice.
2018-04-11 09:31:44 +03:00
Teppo Järvelin
f0026e4c48
review fixed and some minor improvements.
2018-04-11 09:31:44 +03:00
Teppo Järvelin
702efc1de5
Temp commit, not compiling...
2018-04-11 09:31:44 +03:00
Teemu Kultala
d7960620b6
cellular: ATHandler send delay
2018-04-09 13:46:40 +03:00
Teppo Järvelin
9e2da6af7d
Removed mux comments from code.
2018-03-02 14:38:08 +02:00