ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
21,754 Commits
52 Branches
336 Tags
624 MiB
Commit Graph

4631 Commits (97486a697cf210a4eb60ad0f58aaa930e4b19b51)

Author SHA1 Message Date
Amanda Butler 31a73fc007
Edit AdvertisitngDataSimpleBuilder.h 
Edit file, mostly for consistent tense and typos.
 2018-11-26 18:17:22 -06:00
Donatien Garnier 5347a8ae4a
Update Duration.h in consistent casing 2018-11-27 00:16:33 +00:00
Amanda Butler 7df90ba3bc
Edit AdvertisingDataBuilder.h 
Edit file, mostly to fix typos and standardize hyphen use.
 2018-11-26 18:12:56 -06:00
Amanda Butler 451f9aad12
Edit Bounded.h 
Edit file, mostly for consistent capitalization and active voice.
 2018-11-26 18:01:30 -06:00
Amanda Butler ecf8c7320f
Edit Gap.h 
Edit file for capitalization and active voice.
 2018-11-26 17:58:50 -06:00
Vincent Coubard a65296e9ee BLE: removed resolved TODO. 2018-11-26 23:44:23 +00:00
Vincent Coubard 7b1e225012 BLE: Fix address name in NRF targets. 2018-11-26 23:36:43 +00:00
Vincent Coubard 66a9e635bd BLE: report correct event type for legacy advertising report. 2018-11-26 23:28:30 +00:00
Vincent Coubard 0c9ce24638 BLE: remove unwanted trace. 2018-11-26 23:16:31 +00:00
paul-szczepanek-arm b552f8c3f0 fix return code for implemented func 2018-11-26 23:06:06 +00:00
Vincent Coubard ef1552a8f5 BLE: report legacy connection event in new event handler. 2018-11-26 23:03:21 +00:00
paul-szczepanek-arm a14f143c85 set active set to false when stoping advertising 2018-11-26 23:00:29 +00:00
paul-szczepanek-arm 4d986bf376 fix is feature enabled condition and made in consistent 2018-11-26 21:11:34 +00:00
Vincent Coubard 56185582aa BLE: Report legacy advertising with new API. 2018-11-26 21:01:14 +00:00
Vincent Coubard 0ef7a40475 BLE: Fix set advertising paylaod dispatch. 2018-11-26 21:00:46 +00:00
deepikabhavnani da69da972f Add BlockDevice and Filesystem classes inside mbed namespace. 
Adding new modules inside the namespace could be breaking change for existing code base
hence add `using namespace::class` for classes newly added to mbed namespace to maintian
backwards compatibility.

MBED_NO_GLOBAL_USING_DIRECTIVE is added to remove auto-addition of namespace
Macro guard `MBED_NO_GLOBAL_USING_DIRECTIVE` is added around namespace, to avoid
polluting users namespace.
 2018-11-26 13:35:40 -06:00
Vincent Coubard daf0f429c8 BLE: Fix advertising set issues on legacy controllers. 2018-11-26 19:14:48 +00:00
paul-szczepanek-arm 3ae38ac1e8 always set existing set for legacy handle 2018-11-26 18:53:49 +00:00
Cruz Monrreal 1c1638342d
Merge pull request #8708 from SeeedJP/wio_bg96_hal 
[Wio BG96] Adding platform HAL
 2018-11-26 11:22:29 -06:00
Vincent Coubard 7f33145760 BLE: Fix extended advertising check. 2018-11-26 17:12:50 +00:00
Vincent Coubard ac47736259 BLE: Enable cordio extended modules if available. 2018-11-26 16:57:47 +00:00
paul-szczepanek-arm bf535af159 check feature support before calling extended functnions 2018-11-26 16:57:07 +00:00
paul-szczepanek-arm bed7677c81 stop advertising before reseting 2018-11-26 16:51:28 +00:00
paul-szczepanek-arm 6f3a9ca107 legacy handle starts off present in _existing_sets 2018-11-26 16:29:33 +00:00
paul-szczepanek-arm f4a560dace reset advertising sets on reset 2018-11-26 16:25:33 +00:00
deepikabhavnani c272377a81 Make sure no memory overhead if statistics are disabled 2018-11-26 09:42:45 -06:00
deepikabhavnani fa6b3d2783 Corrected TCPServer reporting as per review comments 2018-11-26 09:42:45 -06:00
deepikabhavnani 068f2d14c0 Resolve IAR build issue 
IAR not able to assign default zero value in array and complaints of
internal error as below:

[ERROR] Internal error: [Front end]: assertion failed at:
"..\..\Translator\compiler_core\src\parser\edg\decl_inits.c", line 2031
 2018-11-26 09:42:45 -06:00
Amanda Butler 81fc940a8e Edit SocketStats.h 
Edit file.
 2018-11-26 09:42:45 -06:00
deepikabhavnani 117eb0bc87 Add socketstats stub functions for unittest and addressed reviews 2018-11-26 09:42:50 -06:00
Deepika f6c1a40b29 Add config options for socket statistics 
1. MBED_CONF_NSAPI_SOCKET_STATS_ENABLE to enable the statistics
2. MBED_CONF_NSAPI_SOCKET_STATS_MAX_COUNT max sockets statistics cached
 2018-11-26 09:42:45 -06:00
Deepika a851df66e3 Code/bug after testing 
1. Fixing astyle and docs
2. Extra mutex lock was removed
3. Bytes are updated when send/recv > 0 and not in case of -ve error
4. Review comments
5. Guard statistics implementation in test with MBED_NW_STATS_ENABLED
 2018-11-26 09:42:45 -06:00
Deepika 09b4bc07ce This is the initial version of stats implementation in network layer. 
SocketStats Class is added to collect and provide the statistics information.
In this phase only socket information is collected and max sockets that can
be recorded at any time are configurable through 'MBED_CONF_NSAPI_SOCKET_STATS_MAX_COUNT'

Network statistics can be enabled through a macro MBED_NW_STATS_ENABLED

More information on design is captured in #8743
 2018-11-26 09:42:39 -06:00
paul-szczepanek-arm 2b94b66fd2 deprecate services that are not useless 2018-11-26 15:42:12 +00:00
paul-szczepanek-arm e54e3eaee0 cast no longer needed 2018-11-26 15:42:12 +00:00
deepikabhavnani d5da9eb636 Resolved warning "call_in inherits implicit virtual" 2018-11-26 09:41:15 -06:00
Martin Kojtal 3c0d6f0b0c
Merge pull request #8790 from AriParkkila/cell-urc-cb 
Cellular: Fix ATHandler URC processing
 2018-11-26 16:36:54 +01:00
Vincent Coubard f71e08ccf1 BLE: tag API uses in GenericGap. 2018-11-26 15:26:24 +00:00
Vincent Coubard 2d63714f2e BLE: Implement connection parameter management in GAP. 2018-11-26 15:25:46 +00:00
Vincent Coubard 89355b9fb0 BLE: Check supervision timeout value in connect. 2018-11-26 15:24:42 +00:00
Vincent Coubard d1b5c8cbb5 BLE: Mark LEGACY_ADVERTISING_HANDLE as active in initialization. 2018-11-26 15:23:53 +00:00
Vincent Coubard 93b6ecfa7e BLE: initialize properly deprecated and non deprecated flags. 2018-11-26 15:23:24 +00:00
Vincent Coubard 3aa91ecbba BLE: return phy_set_t in ConnectionParameters::getPhySet 2018-11-26 15:22:50 +00:00
Vincent Coubard a915748cbe BLE: Fallback to legacy connect when required. 2018-11-26 14:13:07 +00:00
Vincent Coubard 190b9bc125 BLE: Fix address type in ::ble::Gap::connect 2018-11-26 14:13:07 +00:00
Ron Eldor 5e0223f78f Add the platform generic errors 
Replace the module specific errors with the `MBEDTLS_ERR_PLATFORM_XXX`
errors.
 2018-11-26 15:33:17 +02:00
Ron Eldor 5ed3a64527 Return MBEDTLS_ERR_CCM_BAD_INPUT on invalid key 
Return `MBEDTLS_ERR_AES_FEATURE_UNAVAILABLE` only for valid key lengths,
that are not supported by Cryptocell 310. For other key sizes, return
`MBEDTLS_ERR_CCM_BAD_INPUT`
 2018-11-26 15:33:16 +02:00
Ron Eldor 1b34927e83 Style fixes 
1. Change camelcase variables to Mbed OS style.
2. Remove functions declarations from the `_alt` header, since they
are now added from the module header regardless whether an alternative
implementation exists.
3. Remove the `extern "c"` declaration from the `_alt` headers.
4. Remove whitespaces before opening parenthesis.
5. Fix alignment of function parameters.
6. Fix indentations.
7. Limit lines to 80 characters.
 2018-11-26 15:32:46 +02:00
Michal Paszta e101943cce Fix compilation warnings (apart from nanostack) 2018-11-26 14:27:48 +01:00
Ron Eldor c948eaad21 Fix issues in CC310 cc_internal discovered by OTT 
Return `MBEDTLS_ERR_ECP_INVALID_KEY` when Cryptocell returns
`CRYS_ECPKI_BUILD_KEY_INVALID_PRIV_KEY_SIZE_ERROR`
or `CRYS_ECPKI_BUILD_KEY_INVALID_PUBL_KEY_SIZE_ERROR`,
When the key size is invalid. Found by the "ECDSA zero private parameter"
tests.
 2018-11-26 15:09:00 +02:00
Ron Eldor d487c80d76 Additional fix for ccm_alt from On Target Testings 
An additional fix for ccm_alt, when the message length is too big.
Check for specific error returned from CC310, and return
`MBEDTLS_ERR_CCM_BAD_INPUT`.
 2018-11-26 15:02:19 +02:00
Ron Eldor 53c02d7457 Zeroize output buffer, upon authentication faliure. 
Clear output buffer upon failure.
 2018-11-26 15:01:02 +02:00
Ron Eldor 1aaff0e389 Return `MBEDTLS_ERR_CCM_AUTH_FAILED` where needed. 
On authentication decryption, when the driver returns the relevant error,
return `MBEDTLS_ERR_CCM_AUTH_FAILED`.
 2018-11-26 15:01:01 +02:00
Ron Eldor 4e7e0548d5 Fix memory overflow 
Fix memory overflow, by adding a local buffer of type
`CRYS_AESCCM_Mac_Res_t `for the tag result, and copy to the input
parameter `tag`.
 2018-11-26 14:59:59 +02:00
Ron Eldor 93e0f6493d Use mbedtls_platform_zeroize 
Rplace calls to `mbedtls_zeroize()` to `mbedtls_platform_zeroize()`.
 2018-11-26 14:57:43 +02:00
Ron Eldor 8cc8481a71 Add unsupported functions for CCM*. 
Implement the CCM* functions, by returning `MBEDTLS_ERR_AES_FEATURE_UNAVAILABLE`
 2018-11-26 14:57:43 +02:00
Mikhail Maltsev 5c351dc6ae Fix C++11 build with Arm Compiler 6 
Currently there are two issues which prevent building Mbed OS with
-std=gnu++11 when using Arm Compiler 6:
* NanostackRfPhys2lp.cpp contains a narrowing conversion in a braced
  initializer list
* ns_types.h includes <stdalign.h> which Arm Compiler 6 currently
  does not provide

This patch fixes both issues. The first one is fixed by changing the
underlying type of the corresponding enumeration when the code is
compiled as C++11. The second issue is worked around by avoiding the
use of <stdalign.h> header for Arm Compiler versions prior to 6.12.
 2018-11-26 12:54:51 +00:00
paul-szczepanek-arm c9e8501b22 make PHY case consistent 2018-11-26 12:30:57 +00:00
Vincent Coubard d3d93e1ef9 BLE: Improve ble::Gap documentation. 2018-11-26 11:51:00 +00:00
paul-szczepanek-arm bee115c39e replace magic numbers 2018-11-26 11:31:03 +00:00
paul-szczepanek-arm f3a64feaf1 replace magic numbers 2018-11-26 11:26:26 +00:00
paul-szczepanek-arm a03aaa2342 simplify and explain swapping 2018-11-26 11:26:13 +00:00
paul-szczepanek-arm e0e186c831 replace consts with a private enum 2018-11-26 11:21:37 +00:00
paul-szczepanek-arm 528deb168f fix wrong variable being swapped 2018-11-26 11:16:23 +00:00
paul-szczepanek-arm 208b1bd3e9 fix size calculation for UUID data payload 2018-11-26 11:10:39 +00:00
Martin Kojtal fdca1e3578
Merge pull request #8730 from kfnta/its_kvstore_single_core 
Add a new PSA Internal Trusted Storage APIs
 2018-11-26 11:54:08 +01:00
Vincent Coubard 8cbc53617f BLE: Add a simple builder for AdvertisingData. 2018-11-26 10:24:35 +00:00
Vincent Coubard d4a66ae034 BLE: Add an AdvertisingDataParser 2018-11-26 10:24:35 +00:00
Vincent Coubard 09ba26ce4b BLE: Move advertising data types in their own file. 2018-11-26 10:24:35 +00:00
Vincent Coubard be7cc41da4 BLE: doxygen fixes. 2018-11-26 10:24:35 +00:00
Vincent Coubard 0407ee8c81 BLE: move privacy configuration type in ble namespace. 2018-11-26 10:24:35 +00:00
Vincent Coubard dff8f25d49 BLE: Improve Duration documentation. 2018-11-26 10:24:35 +00:00
Vincent Coubard 78d4a9b6c8 BLE: Cleanup enum duplicates in gap/Types.h 2018-11-26 10:24:35 +00:00
Vincent Coubard 884d870b68 BLE: Improve gap/Types.h documentation. 2018-11-26 10:24:35 +00:00
Vincent Coubard 9621b26cab BLE: Reorganize ble::gap documentation group. 2018-11-26 10:24:35 +00:00
Vincent Coubard 27011fd954 BLE: Document ble::ScanParameters. 2018-11-26 10:24:35 +00:00
Vincent Coubard 11b1e91592 BLE: Rework ScanParameters construction. 2018-11-26 10:24:35 +00:00
Vincent Coubard 3119f9488c BLE: Construct a phy_set_t from a phy_t. 2018-11-26 10:24:35 +00:00
Vincent Coubard e130bec6a0 BLE: rework ScanParameters::phy_configuration_t 2018-11-26 10:24:35 +00:00
Vincent Coubard 4db8ddfb90 BLE: fix name of functions in ble::ScanParameters. 2018-11-26 10:24:35 +00:00
Vincent Coubard 936f1c550a BLE: Update ble::Gap documentation. 2018-11-26 10:24:35 +00:00
Vincent Coubard 6b8b1d0b7a BLE: remove minimize fragmentation parameter in Gap. 2018-11-26 10:24:35 +00:00
Vincent Coubard 4058f0908a BLE: Extract computation of minimumSupervisionTimeout. 2018-11-26 10:24:35 +00:00
Vincent Coubard 6cb7645846 BLE: Improve NULL check in ble::AdvertisingDataBuilder implementation. 2018-11-26 10:24:35 +00:00
Vincent Coubard 643fad0162 BLE: Improve code by explaining or textually defining constants 2018-11-26 10:24:35 +00:00
Vincent Coubard 6c09b6c465 BLE: Expose representation type in ble::Duration. 2018-11-26 10:24:35 +00:00
Vincent Coubard ce2460a92a BLE: expose representation type and pointer to the inner storage in SafeEnum. 2018-11-26 10:24:35 +00:00
Vincent Coubard eda3bfb0e3 BLE: Explain magic constant in ble::Gap implementation. 2018-11-26 10:24:35 +00:00
Vincent Coubard 30c6432b5d BLE: Address code formating issue in CordioPalGap implementation. 2018-11-26 10:24:35 +00:00
Vincent Coubard 76416b2f47 BLE: Improve implementation readability of ble::advertising_event_t 2018-11-26 10:24:35 +00:00
Vincent Coubard 27dd08431e BLE: remove ble::pal::extended_advertising_report_event_type_t as it is not used. 2018-11-26 10:24:35 +00:00
Vincent Coubard d32354a7a6 BLE: Fix compiler warning about unused variable. 2018-11-26 10:24:35 +00:00
Vincent Coubard 2a08549b8d BLE: rename ble::Forever into ble::Value. 2018-11-26 10:24:35 +00:00
Vincent Coubard e9637c419a BLE: Remove ble::clamp as it is not used anywhere. 2018-11-26 10:24:35 +00:00
Vincent Coubard b49870d8ae BLE: Fix code formating issues in Gap subsystem. 2018-11-26 10:24:35 +00:00
Vincent Coubard f64b37ba0d BLE: Fix function braces opening in header files. 2018-11-26 10:24:35 +00:00
Vincent Coubard 1b734a46d2 BLE: Improve ble::Gap::EventHandler documentation. 2018-11-26 10:24:35 +00:00
Vincent Coubard 70ec1cf641 BLE: Improve naming consistency of Gap event types. 2018-11-26 10:24:35 +00:00
Vincent Coubard dea2ae9c1f BLE: Exclude Gap Event constructors from documentation. 2018-11-26 10:24:35 +00:00
Vincent Coubard 430777e20b BLE: Update documentation of Gap::Events. 2018-11-26 10:24:35 +00:00
Vincent Coubard 8fc62efbd8 BLE: Improve naming consistency of ble::Gap::EventHandler functions. 2018-11-26 10:24:35 +00:00
Vincent Coubard 6e4e733c1c BLE: Add code example for ble::ConnectionParameters. 2018-11-26 10:24:35 +00:00
Vincent Coubard 49455dcc87 BLE: set the phy as first parameter in ble::ConnectionParameters. 2018-11-26 10:24:35 +00:00
Vincent Coubard 1841f4e75e BLE: Document ble::ConnectionParameters. 2018-11-26 10:24:35 +00:00
Vincent Coubard 8d03d67ae8 BLE: Improve ble::AdvertisingParameters documentation. 2018-11-26 10:24:35 +00:00
Vincent Coubard 52318e464d BLE: rename AdvertisingParameters::*PolicyMode into AdvertisingParameters::*Filter. 2018-11-26 10:24:35 +00:00
paul-szczepanek-arm 2eaec287fb simple scan paramater constructor 2018-11-26 10:24:35 +00:00
paul-szczepanek-arm cd5dabf464 duration added valueInMs 2018-11-26 10:24:35 +00:00
paul-szczepanek-arm c9dcef17dd return func made const 2018-11-26 10:24:35 +00:00
Vincent Coubard 9f39dba429 BLE: Fix constant declaration of ble::AdvertisingParameters. 2018-11-26 10:24:35 +00:00
Vincent Coubard fea3ac87de BLE: Add forever information to ble::adv_duration_t and ble::scan_duration_t 2018-11-26 10:24:35 +00:00
paul-szczepanek-arm 02cf9ea94d moved some funcs to cpp, moved cpp to source folder 2018-11-26 10:24:35 +00:00
Vincent Coubard ba931f1d4c BLE: Document ble::Duration and satelite classes. 2018-11-26 10:24:34 +00:00
Vincent Coubard e602a5f06c BLE: Improve static constant of Range and Duration. 2018-11-26 10:24:34 +00:00
Vincent Coubard 62674e58e6 BLE: Handle forever value in ble::Duration operators. 2018-11-26 10:24:34 +00:00
Vincent Coubard 49f5c7f833 BLE: Fix Bounded constant declaration. 2018-11-26 10:24:34 +00:00
Vincent Coubard 07c05917e0 BLE: Add Duration::forever() function. 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 7b0cb27427 added type conversion for connection params 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 7fb863eeb4 missing virtual 2018-11-26 10:24:34 +00:00
Vincent Coubard 80db38c60a BLE: Cleanup bounded and document it. 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm e9c0f587af fix constness to match recent const changes 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm b293426a81 missing overloads 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm ed10543093 missing virtual 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 1bf5826cdc pull in more inherited overloads 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm e49b5230cc fix missing index 2018-11-26 10:24:34 +00:00
Vincent Coubard 87f36450f5 BLE: return immutable buffer from AdvertisingDataBuilder::getAdvertisingData 2018-11-26 10:24:34 +00:00
Vincent Coubard dfa7749d8a BLE: Split ble/gap/AdvertisingDataBuilder.h into declaration and implementation file. 2018-11-26 10:24:34 +00:00
Vincent Coubard 86dc6d71ee BLE: Fix includes of ble/gap/AdvertisingDataBuilder.h , 2018-11-26 10:24:34 +00:00
Vincent Coubard 0c2efc4dd9 BLE: Fix return value of GenericGap::manageConnectionParametersUpdateRequest. 2018-11-26 10:24:34 +00:00
Vincent Coubard 586aea553b BLE: Move privacy subsystem to ::ble::Gap. 2018-11-26 10:24:34 +00:00
Vincent Coubard c54e0d9862 BLE: Move Gap::StopScan into ::ble::Gap::stopScan . 2018-11-26 10:24:34 +00:00
Vincent Coubard dd2c85d063 BLE: Fix signeness warning in AdvertisingDataBuilder. 2018-11-26 10:24:34 +00:00
Vincent Coubard bc6078eb77 BLE: prevent warning from deprecated API implementation in GenericGap. 2018-11-26 10:24:34 +00:00
Vincent Coubard 4fdb9c7e67 BLE: provide default implementation ::ble::Gap::isFeatureSupported 2018-11-26 10:24:34 +00:00
Vincent Coubard a9fd003803 BLE: Move uses of deprecated Gap functions into isolated and warning free block. 2018-11-26 10:24:34 +00:00
Vincent Coubard 1802909272 BLE: Move Gap deprecated implementation in source/Gap.cpp . 
The implementation has been moved to a block that do not issue deprecation warning as this is an implementation detail.
 2018-11-26 10:24:34 +00:00
Vincent Coubard 0b746a78c8 BLE: prefix inclusion of Gap header with "ble/" 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 2e6fefa289 missing defaults 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 376cbd25fa fixed index and default constructor in conn params 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm b0b6346050 added extra constructor 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 75e6128776 solve link problems 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm e5e7f3edef pull in inherited overloads 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 935444d128 use correct type for service data based on uuid length 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 79518ca089 service data allows both types of UUIDs 2018-11-26 10:24:34 +00:00
Vincent Coubard 02d61cfe24 BLE: Move new version of ::GAP in a new class ::ble::Gap . 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 84dd169d14 allow long uuids in service data 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 181ce00902 fix size checks 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 062c301a96 check min size for custom data 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm e54c0ed1de simplify UUID funcs 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm acd7ec3572 check sizes, use memcpy 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 92cbec3e41 requested services 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 91fa548953 verify parameters 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm aefd92a838 docs 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 656aa4fa4c CONNECTION INTERVAL HELPER 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 7ab45e4c09 individual operations 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 0b1b07f9f1 service data 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 4a850207fa remove redundant calulations 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 4b6eede76b UUID handling 2018-11-26 10:24:34 +00:00
Vincent Coubard 869bb308c5 BLE: Add API to manage GAP connection parameter updates. 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm b6a0c8aea5 helper functinos 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 0d95ccb4ba fix enum values 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 838de80fbf flags no longer a safenum 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 6ef90b5ca7 remove data instead of replace data 2018-11-26 10:24:34 +00:00
paul-szczepanek-arm 862775d3df extra data builder funcs 2018-11-26 10:24:33 +00:00
Vincent Coubard da7d4a0c12 BLE: Introduce new disconnection API. 2018-11-26 10:24:33 +00:00
Vincent Coubard 7d7ccea827 BLE: clean separation between GAP v1 and GAP v2 API. 2018-11-26 10:24:33 +00:00
Vincent Coubard c165bd98b7 BLE: Add explicit constructor for Duration that accepts millisecond in input. 2018-11-26 10:24:33 +00:00
Vincent Coubard fa4aa8f068 BLE: remove inner V2 typedef in Gap class. 2018-11-26 10:24:33 +00:00
Vincent Coubard d3c26f4283 BLE: rename functions that trap concurrent use of incorect GAP APIs 2018-11-26 10:24:33 +00:00
Vincent Coubard 6de585f7bf BLE: rename Gap::IsFeatureSupported into Gap::isFeatureSupported 2018-11-26 10:24:33 +00:00
Vincent Coubard 5f435debd0 BLE: remove ble:: prefixes in ble::AdvertisingParameters. 2018-11-26 10:24:33 +00:00
Vincent Coubard 46815cc371 BLE: remove ble:: prefixes in ble::ScanParameters. 2018-11-26 10:24:33 +00:00
Vincent Coubard 6c75c53127 BLE: Move gap events into ble namespace. 2018-11-26 10:24:33 +00:00
Vincent Coubard 7123364674 BLE: remove not required prefixes in ble::ConnectionParameters. 2018-11-26 10:24:33 +00:00
Vincent Coubard c1cd5ede84 BLE: Cleanup ble::connection_role_t. 2018-11-26 10:24:33 +00:00
Vincent Coubard 493c8580cc BLE: cleanup of clock_accuracy_t 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm 3e72570c52 move values out of GAP 2018-11-26 10:24:33 +00:00
Vincent Coubard 7aa1e95193 BLE: merge ble::target_peer_address_type_t and advertising_peer_address_type_t 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm d8eb9de459 fix names 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm 7ea560a955 size clarification 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm 33ab365d2c advertising data 2018-11-26 10:24:33 +00:00
Vincent Coubard ad127d76af BLE: merge ble::own_address_t and pal::own_address_type_t. 2018-11-26 10:24:33 +00:00
Vincent Coubard d1cb1e1a39 BLE: merge ble::scanning_filter_duplicates_t and pal::duplicate_filter_t 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm cc8b43f3ab update gap overview 2018-11-26 10:24:33 +00:00
Vincent Coubard 07d73d5e20 BLE: merge ble::scanning_policy_mode_t and gap::scanning_filter_policy_t 
This change set also introduce ble::initiator_filter_policy_t and fix a type issue ble::ConnectionParameters.
 2018-11-26 10:24:33 +00:00
Vincent Coubard 3b334b814d BLE: Revert space change in ble/GapAdvertisingParams.h 2018-11-26 10:24:33 +00:00
Vincent Coubard c6cdfd0b7e BLE: Merve ble::advertising_policy_mode and pal::advertising_filter_policy . 2018-11-26 10:24:33 +00:00
Vincent Coubard db55540952 BLE: merge ble::advertising_type_t and pal::advertising_type_t. 2018-11-26 10:24:33 +00:00
Vincent Coubard b4c704c807 BLE: Move leftover target_peer_address_type_t in ble/gap/Types.h 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm b59b29ba9f reject conenct request if exteneded not enabled but required 2018-11-26 10:24:33 +00:00
Vincent Coubard b8db58fe57 BLE: Move new gap types in ble/gap/Types.h 2018-11-26 10:24:33 +00:00
Vincent Coubard b4fe04addd BLE: Improve readability of AdvertisingDataBuilder::appendField 2018-11-26 10:24:33 +00:00
Vincent Coubard 823825ee24 BLE: Fix ternary expression return type. 2018-11-26 10:24:33 +00:00
Vincent Coubard 2477d0e385 BLE: Fix missing initialization in ble::phy_set_t. 2018-11-26 10:24:33 +00:00
Vincent Coubard 47c4784e31 BLE: Rework ble::AdvertisingParameters 
* Reorganize functions in logical order.
* Add separation between legacy and extended advertising.
* Update setter to return a reference to this. This allows chain of calls.
* Remove getter that can fail due to bad user inputs.
 2018-11-26 10:24:33 +00:00
Vincent Coubard a255a790a6 BLE: Improve ble::AdvertisingParameters field declaration. 2018-11-26 10:24:33 +00:00
Vincent Coubard b34d09c47e BLE: Fix AdvertisingParameters::getChannelXX functions. 2018-11-26 10:24:33 +00:00
Vincent Coubard 184533ab3e BLE: Fix second time base. 2018-11-26 10:24:33 +00:00
Vincent Coubard d659bc6561 BLE: unwrap own_address_type value in GenericGap. 2018-11-26 10:24:33 +00:00
Vincent Coubard a043f49e7c BLE: Use common ble::own_address_type_t in ble::ScanParameters. 2018-11-26 10:24:33 +00:00
Vincent Coubard 812b86a197 BLE: cleanup ble::AdvertisingParameters 
* Use constrained types where relevant.
* Remove fields N/A fields
 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm 65d84e4227 fix case 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm 09f71d278d move feature support into user api 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm 05fb66a987 docs 2018-11-26 10:24:33 +00:00
paul-szczepanek-arm f3c47f135b docs 2018-11-26 10:24:33 +00:00
Vincent Coubard 5dc6c1d670 BLE: move ScanParameters into ble namespace. 2018-11-26 10:24:33 +00:00
Vincent Coubard 07cf0f5b91 BLE: Move ConnectionParameters into ble namespace. 2018-11-26 10:24:33 +00:00
Vincent Coubard f0cbd9f434 BLE: move GapAdvertisingParameters to ble::AdvertisingParameters 2018-11-26 10:24:33 +00:00
Vincent Coubard 1324116377 BLE: rename duration type and extract them out of Gap. 2018-11-26 10:24:33 +00:00
Vincent Coubard a1d464f2c0 move ble::Bounded in its own file. 2018-11-26 10:24:33 +00:00
Vincent Coubard 20d5de70bd BLE: Move ble::Duration in its own file. 2018-11-26 10:24:33 +00:00
Vincent Coubard 68703495f6 BLE: Extract types from GapAdvertisingConstant and add them into ble namespace. 2018-11-26 10:24:33 +00:00
Vincent Coubard 6f21326b6a BLE: Move Gap event types in dedicated file. 2018-11-26 10:24:33 +00:00
Vincent Coubard 3737e385af BLE: Expose ble::pal::connection_role_t in ble namespace. 2018-11-26 10:24:33 +00:00
Vincent Coubard 4d3354077e BLE: rename GapExtendedConnectParameters_t into ConnectionParameters 2018-11-26 10:24:32 +00:00
Vincent Coubard 2d1362c2c4 BLE: Move GapScanParameters header into ble/gap/ScanParameters 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm cf69013bb6 docs 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm f7310a07e9 docs 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 0f4ac44bc5 docs 2018-11-26 10:24:32 +00:00
Vincent Coubard 6eee528b79 Update mbed-os/features/FEATURE_BLE/ble/Gap.h 
Co-Authored-By: paul-szczepanek-arm <paul.szczepanek@arm.com>
 2018-11-26 10:24:32 +00:00
Vincent Coubard 472e9ff997 Update mbed-os/features/FEATURE_BLE/ble/Gap.h 
Co-Authored-By: paul-szczepanek-arm <paul.szczepanek@arm.com>
 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm e9177fa233 docs 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm da22df74bc docs and synchronise connection result with other events 2018-11-26 10:24:32 +00:00
Vincent Coubard 4de9a613c8 BLE: Add strict Duration type 
* Construction from representation type is explicit
* Conversion between unit is only allowed if there is no precision loss
* Range is built inside the type
* More operators!
* min and max values exposed as part of the interface
 2018-11-26 10:24:32 +00:00
Vincent Coubard 5ad50a20f8 BLE: Add PHY precondition check in setScanParameters. 2018-11-26 10:24:32 +00:00
Vincent Coubard 3e884a382e BLE: Initialisation of legacy advertising set. 2018-11-26 10:24:32 +00:00
Vincent Coubard 6fccb11006 BLE: Deal with random address rotation where appropriate. 2018-11-26 10:24:32 +00:00
Vincent Coubard 09d22a329c BLE: Address special case when advertising payload size is 0. 2018-11-26 10:24:32 +00:00
Vincent Coubard ff9b380c44 BLE: Use secure types in GapScanParameters. 2018-11-26 10:24:32 +00:00
Vincent Coubard 9604c0187a BLE: Introduce Duration and Bounded classes. 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm fa3869cf82 docs 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 8fe07b47be docs 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 360336c89c docs 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 9fc577d6e6 docs 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 642602c925 merge cleanup 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 4f769df976 merge fail 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm bb8892a956 more docs 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm cfde4ed019 disallow removing the legacy handle 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm d01b4a53ee docs 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 57e4cdd732 new units 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 7b4439567d comparison operator 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 8e18e191fb new units 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm e04fd876f5 units 2018-11-26 10:24:32 +00:00
Vincent Coubard f136b0cb00 BLE: Rework Gap event handler. 
Every user facing event handler accept a single parameter type; event that contains all the event fields.
That strategy allows us to extend the type later if required while we do not disrupt existing code.
 2018-11-26 10:24:32 +00:00
Vincent Coubard 6a63948a7d BLE: Add phy in sync exstablished event. 2018-11-26 10:24:32 +00:00
Vincent Coubard 194e2cb4f8 BLE: Move common type from pal to ble namespace. 2018-11-26 10:24:32 +00:00
Vincent Coubard 74c2def5ef BLE: Fix mutability in ble::advertising_event_t 2018-11-26 10:24:32 +00:00
Vincent Coubard b6c7bd7960 Merge pull request #1 from paul-szczepanek-arm/vincent 
connections
 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 00da0e571a fix review comments 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 8733d52da9 event types fixed 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 9b77f9dcba default values and func names 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 68b5aad2ce ppm case 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 8cc580d986 only one connection event needed 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 2cdff44f2a cancel connection 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 365a6c8c4d set random address 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm c0f4b864ca clamp values 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 216dd6dcc7 we need clamping while we wait for c++17 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm a3820c89c5 removed impossible case 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 02d9b35bad assert added 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 32c303d7f3 missing return 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 87887cc9dd rename phy to index 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 565f1e0131 fix first element of array selection 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm fd880d1e6b fix swapping 2018-11-26 10:24:32 +00:00
paul-szczepanek-arm 62b38cfbc8 connection complete event 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm 519f75587a ppm conversion 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm b98326150d fix names 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm bd8b7fa87f use set value on return 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm 5e6c0c92f6 compilation errors 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm 6fa7a8ffce fix type 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm 9529974572 type already defined in ble types 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm 4fe7d5ed90 small cleanup 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm 8801ef570a fix types 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm b489e0957e pal call 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm a2f461c38e reference instead of pointer 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm 32d3fa9aad shorten min max 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm edb645b492 handle creating contiguous arrays for the pal call 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm 713b5c7e10 add ability to disable phy 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm d00a92d10f init param to false until user changes it 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm 4c4743db7b extended connection API 2018-11-26 10:24:31 +00:00
paul-szczepanek-arm afadc1d8c0 convert to correct time units 2018-11-26 10:24:31 +00:00
Vincent Coubard 2f8e336635 BLE: tag missing documentation block. 2018-11-26 10:24:31 +00:00
Vincent Coubard 651bf321db BLE: Use typedef in signature. 2018-11-26 10:24:31 +00:00
Vincent Coubard 5661bf6bbb BLE: remove dead code. 2018-11-26 10:24:31 +00:00
Vincent Coubard 31e028f22f BLE: fix integer overflow in setPeriodicAdvertisingParameters 2018-11-26 10:24:31 +00:00
Vincent Coubard 3eebcc49ad BLE: Add more precondition check to GenericGap. 2018-11-26 10:24:31 +00:00
Vincent Coubard d23bd2f268 BLE: Fix compilation error. 2018-11-26 10:24:31 +00:00
Vincent Coubard 297ad78452 BLE: check for periodic advertising enabled in GenericGap::destroyAdvertisingSet 2018-11-26 10:24:31 +00:00
Vincent Coubard 24e6b89ade BLE: use uint32_t to describe ms interval in Gap::setPeriodicAdvertisingParameters 2018-11-26 10:24:31 +00:00
Vincent Coubard 01b0de2175 BLE: rename Gap:setPeriodicAdvertisingData into setPeriodicAdvertisingPayload. 2018-11-26 10:24:31 +00:00
Paul Szczepanek eefdc638f7 BLE: fix condition in advertising set allocation. 
Co-Authored-By: pan- <vincent.coubard@arm.com>
 2018-11-26 10:24:31 +00:00
Vincent Coubard b1c6914e34 BLE: Add periodic sync advertisement management. 2018-11-26 10:24:31 +00:00
Vincent Coubard 5236a70618 BLE: Add default minimiseFragmentationValue for Gap::setAdvertisingScanresponse. 2018-11-26 10:24:31 +00:00
Vincent Coubard 06b3ccd322 BLE: refactor parameters order of Gap::startAdvertising 2018-11-26 10:24:31 +00:00
Vincent Coubard d6d1ea5c2a BLE: rework GenericGap::stopAdvertising(AdvHandle) 2018-11-26 10:24:31 +00:00
Vincent Coubard 74356aa7f0 BLE: Rework GenericGap::startAdvertising 2018-11-26 10:24:31 +00:00
Vincent Coubard b825ffc1f6 BLE: Handle setAdvertisingParameters on legacy controllers. 2018-11-26 10:24:31 +00:00
Vincent Coubard d2773e9731 BLE: Reduce complexity of GenericGap::setAdvertisingData 2018-11-26 10:24:31 +00:00
Vincent Coubard 0d90671842 BLE: Fix release of advertising sets. 2018-11-26 10:24:31 +00:00
Vincent Coubard 413908d594 BLE: Renaming 
GenericGap::is_extended_advertising_enabled become GenericGap::is_extended_advertising_available
 2018-11-26 10:24:31 +00:00
Vincent Coubard df5e01bf45 BLE: wrap bitstream manipulation into a BitArray class. 2018-11-26 10:24:31 +00:00
Vincent Coubard 2e8389d4fd BLE: Create and destroy advertising sets in the controller. 2018-11-26 10:24:31 +00:00
Vincent Coubard ed012adab3 BLE: Fix create and destroy advertising set. 2018-11-26 10:24:31 +00:00
Vincent Coubard 7882bb3016 BLE: Fix bit access to mapped advertising set. 2018-11-26 10:24:31 +00:00
Vincent Coubard f6ceafa3e9 BLE: use helper function where appropriate. 2018-11-26 10:24:31 +00:00
Vincent Coubard d63c7bc948 BLE: use std::min where appropriate. 2018-11-26 10:24:31 +00:00
Vincent Coubard a628eba212 BLE: cosmetic fixes. 2018-11-26 10:24:31 +00:00
Vincent Coubard ad3f3c86a5 BLE: Move implementation to cpp file. 2018-11-26 10:24:31 +00:00
Vincent Coubard 87014b71b6 BLE: reorder declaration. 2018-11-26 10:24:31 +00:00
Vincent Coubard 6a55d65660 BLE: Create advertising payload builder. 
This change set use a data buffer to set data and scan responses.
 2018-11-26 10:24:31 +00:00
Vincent Coubard e24fcdd12a BLE: move extended advertising parameter in ble/gap folder 2018-11-26 10:24:31 +00:00
Vincent Coubard 7f9be995a2 BLE: Revert GapAdvertisingdata and create new type for extened Advertising data. 2018-11-26 10:24:31 +00:00
Vincent Coubard e4c27e5071 BLE: Introduce new type for extended advertising parameters. 2018-11-26 10:24:31 +00:00
Vincent Coubard 2c7cf2bbd9 BLE: revert GapScanningParams 2018-11-26 10:24:31 +00:00
Vincent Coubard 61536c3f64 BLE: revert non backward compatible changes. 
This changeset includes order of function declaration in headers.
 2018-11-26 10:24:31 +00:00
Vincent Coubard dc07e44290 BLE: makes GenericGap::stopGap aware of extended scan. 2018-11-26 10:24:31 +00:00
Vincent Coubard 24460de86f BLE: Implement new scan API in GenericGap 2018-11-26 10:24:30 +00:00
Vincent Coubard 4835a1afdc BLE: Add non legacy scan API. 2018-11-26 10:24:30 +00:00
Vincent Coubard 28ead51401 BLE: Add GapScanParameters type. 
The new type covers what is required by extended and legacy scan parameters.
 2018-11-26 10:24:30 +00:00
Vincent Coubard 27ea248863 BLE: Fix GapScanningParams includes. 2018-11-26 10:24:30 +00:00
Vincent Coubard 1a14453da1 BLE: Add mechanism to track use of non compatible scan API. 2018-11-26 10:24:30 +00:00
Vincent Coubard 962b5c34d4 BLE: Tag scanning filter policy mode with FIXME 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 2b00903a30 missing param 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm a1582bd3ac pointer to ref 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 6663171607 docs 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 2f6d861818 fix packetisation in adv set data 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 23dc808968 handle legacy adv calls 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 587eb9845e call the right func for set scan response 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm b276e6edaf fix high duty cycle setting (reversed) 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 238f15b031 doc fixes 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm ca72f5a289 merged adv param types 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 8c253a3dfe proposed scan type changes 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 60fb78795b fix adv and scan types 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 5d077e6dbc new addr types for ext adv 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm c58099f0ee new scan call 2018-11-26 10:21:32 +00:00
Vincent Coubard 75c0b0ed90 BLE: Fix advertising_channel_map_t constructor. 2018-11-26 10:21:32 +00:00
Vincent Coubard 0c1e01952b Compilation fixes 2018-11-26 10:21:32 +00:00
Vincent Coubard fb804bf85a BLE: Fix GapExtendedAdvertisingParams visibility and constness. 2018-11-26 10:21:32 +00:00
Vincent Coubard e951fa15ff BLE: Fix GapExtendedAdvertisingParams::getPeerAddress return type. 2018-11-26 10:21:32 +00:00
Vincent Coubard 426de4a2d9 BLE: Fix GapAdvertisingData copy constructor. 2018-11-26 10:21:32 +00:00
Vincent Coubard 2f53ee896c BLE: Add setters to advertising_event_t and use it in GapExtendedAdvertisingParams. 2018-11-26 10:21:32 +00:00
Vincent Coubard d1e3800e79 BLE: Refactor AdvReportOptionalInformation and onAdvertisingReport 2018-11-26 10:21:32 +00:00
Vincent Coubard 5e707731f2 BLE: Wrap advertising data in a span. 2018-11-26 10:21:32 +00:00
Vincent Coubard dee48e71e3 BLE: Typedef ble::advertising_event_t into Gap::AdvertisingEventType_t 2018-11-26 10:21:32 +00:00
Vincent Coubard f930905947 BLE: Regactor Gap::EventHandler::onScanRequest signature. 2018-11-26 10:21:32 +00:00
Vincent Coubard 14b24d324c BLE: Move advertising_handle_t into ble namespace. 2018-11-26 10:21:32 +00:00
Vincent Coubard f83f32948a BLE: Fix typo in arguments name. 2018-11-26 10:21:32 +00:00
Vincent Coubard 44d8545dc8 BLE: Add ANONYMOUS in peer_advertising_type_t 2018-11-26 10:21:32 +00:00
Vincent Coubard e58928def1 Move advertising event and advertising event data status to ble. 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 78a4bdda8a type translation 2018-11-26 10:21:32 +00:00
paul-szczepanek-arm 8794c0b43b make packetisation common 2018-11-26 10:21:32 +00:00