Commit Graph

452 Commits (77218f04e05a9539530d99ffedc844f28ee6b718)

Author SHA1 Message Date
Martin Kojtal d847f9f164
Merge pull request #12305 from kivaisan/remove_multi_athandler_support_v2
Cellular: Remove support for multiple ATHandlers
2020-02-07 11:00:41 +00:00
Martin Kojtal 8dc15ee6e1
Merge pull request #12293 from mirelachirica/remove_empty_api
Cellular: Remove API's empty default implemetations
2020-02-06 09:05:40 +00:00
jeromecoutant a1fb286c06 AT_CellularStack: crash during TCP test
function tries to access _socket[1] whch is not opened
2020-01-28 13:10:41 +01:00
Kimmo Vaisanen bd0f939277 Cellular: Remove support for multiple ATHandlers
Major changes:
- Dependency to FileHandle removed from base classes
- AT_CellularDevice owns the default FileHandle and shares it with AT -classes
- Hang-up -detection moved as CellularContext::configure_hup(). Cannot be configured via CellularDevice any more.

Result on NRF52840_DK + BG96:
GCC:
Total Static RAM memory (data + bss): 29360(+296) bytes
Total Flash memory (text + data): 130660(-832) bytes

ARM:
Total Static RAM memory (data + bss): 261554(+8) bytes
Total Flash memory (text + data): 127573(-1193) bytes

IAR:
Total Static RAM memory (data + bss): 25479(+296) bytes
Total Flash memory (text + data): 102418(-527) bytes

RAM increase is because now ATHandler is no longer created with new -operator but is now member of AT_CellularDevice,
so image tool is able to count it. Actually total RAM consumption has decreased due to removed variables.
2020-01-23 09:27:44 +02:00
Anna Bridge 80fe861f1d
Merge pull request #12035 from kjbracey-arm/callback_prep
Preparation for Callback changes
2020-01-21 11:50:43 +00:00
Mirela Chirica e2048b06b2 Cellular: Remove API's empty default implemetations 2020-01-21 10:45:09 +02:00
Ari Parkkila 2871721e08 Cellular: Refactor socket_stack_init() from generic to modem specific 2020-01-20 00:56:09 -08:00
Martin Kojtal ecf4d62dc5
Merge pull request #12265 from AriParkkila/cell-fea-refactor
Refactor unnecessary functions from cellular driver
2020-01-17 13:57:06 +00:00
Martin Kojtal 4924264769
Merge pull request #12211 from hugueskamba/hk-replace-uartserial-cellular
Cellular: Replace UARTSerial references with BufferedSerial
2020-01-17 13:30:12 +00:00
Ari Parkkila 031d90a3ce Fix UDP socket test cases
Fix UDP socket test cases to check more strictly on failure,
and lower trace levels to not print errors on successful cases.
2020-01-17 01:24:51 -08:00
Ari Parkkila f9eef97ead Cellular Refactor get_send_delay() into CellularProperty 2020-01-17 00:28:41 -08:00
Hugues Kamba 9e11e5b43d Cellular: Replace UARTSerial references with BufferedSerial
`BufferedSerial` is `UARTSerial` renamed to convey the original purpose
of the class. It is the recommended buffered I/O serial class.
2020-01-16 16:22:07 +00:00
Ari Parkkila ceea992b40 Cellular: Refactor is_protocol_supported() into CellularProperty 2020-01-15 23:04:00 -08:00
Ari Parkkila e2cb18061e Cellular: Refactor get_max_socket_count() into CellularProperty 2020-01-15 23:04:00 -08:00
Kimmo Vaisanen 2c4194bbe3 Cellular: Fix compilation fail with APN lookup enabled
Compilation failed if cellular APN lookup was enabled as stop command has been
removed.
2020-01-15 14:42:04 +02:00
Kevin Bracey d6a48b5124 Turn NULLs into nullptr
Avoids overload problems with Callback(nullptr) versus Callback(fnptr).
2020-01-09 14:52:54 +02:00
Antti Kauppila 36ca4d6516 ATHandler relocated
ATHandler is part of our API so header file was moved under API folder and .cpp file was moved under device/ folder
ATHandler is used in both AT and PPP mode so it has been in slightly wrong place at the beginning.
2020-01-07 17:15:27 +02:00
Ari Parkkila 7899fead59 Cellular: Refactor CellularBase from AT_ControlPlane_netif 2020-01-07 04:03:33 -08:00
Ari Parkkila 4b3ef73333 Cellular: Fix astyle 2020-01-06 22:35:53 -08:00
Ari Parkkila f4158ca00e Cellular: Change ATHandler debug print levels 2020-01-06 22:35:18 -08:00
Ari Parkkila 913cbd96a6 Cellular: Change 3GPP TS 27.007 NIDD to async
Add a missing license header.
Remove semaphores and add +CRTDCP to support async operation.
Fix delete context and disconnect to execute just once.
Add support for NONIP PPD type.
Change CellularNetwork::clear() to virtual so it can be overridden.
2020-01-06 22:35:18 -08:00
Ari Parkkila feee2a234e Cellular: Fix Non-IP of Quectel/BG96 modem driver
Add missing license headers.
Remove semaphores to allow async operation.
Change hex format to allow binary payload.
Limit payload size to 100 bytes.
Fix missing plus char at +QCFGEXT.
2020-01-06 22:33:49 -08:00
Martin Kojtal 0dbf34bf06
Merge pull request #12123 from kivaisan/refactor_variable_visibilities
Cellular: Refactor cellular variable visibilities
2020-01-03 12:11:52 +00:00
Martin Kojtal 6baa5e479d
Merge pull request #12020 from linlingao/fix_rat
Fix issues in setting radio access technology
2020-01-02 10:08:11 +00:00
Kimmo Vaisanen f7cc3db70b Cellular: Refactor cellular variable visibilities
- Earlier some variables were public even though used only internally
- Also refactored variables to the end of class definitions
- Removed duplicate _property_array from CellularDevice
- Changed _impl methods as protected
2019-12-30 10:00:24 +02:00
Ari Parkkila d5abab8843 Cellular: Add check for network congestion in BC95 driver 2019-12-20 04:25:26 -08:00
Lin Gao 0bc8f4f726 Revert BUFF_SIZE fix, to be fixed in another PR. Add missing property entries 2019-12-19 13:45:30 -06:00
Lin Gao c8524c25be add config option and property to choose automatic fallback for PLMN manual operator selection 2019-12-19 11:26:13 -06:00
Lin Gao a5a9683348 Change AT+COPS mode to manual first then fall back to auto to improve reliability. Fix a syntax error when RAT is set 2019-12-19 11:23:30 -06:00
Lin Gao 9e17653723 Increase BUFF_SIZE to avoid error in AT response when debug is turned on 2019-12-19 11:21:14 -06:00
Kimmo Vaisanen f5ef066055 Cellular: Suppress long AT traces
When AT traces are enabled and very long AT commands are traced,
system can easily go to unwanted state. Therefore the length of the AT
traces is limited to DEBUG_MAXLEN (currently 60 characters).

This commit fixes read_hex_string, read_bytes and write to use this
limitter.
2019-12-19 09:54:23 +02:00
Anna Bridge eac7d30ca5
Merge pull request #12114 from AriParkkila/cell-dns-zero
Cellular: Fix to not use all zero address for DNS
2019-12-17 16:41:39 +00:00
Anna Bridge e28daf7c84
Merge pull request #12110 from AnttiKauppila/cp_recv_len
Moved CP Max recv len into mbed_lib.json
2019-12-17 16:28:37 +00:00
Anna Bridge 298f3f22b7
Merge pull request #12088 from AriParkkila/cell-cops
Cellular: Fix AT command for COPS manual network selection
2019-12-17 16:24:28 +00:00
Antti Kauppila 6d0b2fae9b Moved CP Max recv len into mbed_lib.json
According to [3GPP-TS_24.008] the maximum size for Non-IP link MTU is 1358 octets to prevent fragmentation in the backbone network.
Therefore reduced the maximum size to follow the standard.
2019-12-16 15:48:46 +02:00
Ari Parkkila 50ab644380 Cellular: Fix to not use all zero address for DNS 2019-12-16 04:56:45 -08:00
Ari Parkkila 483c557f9b Cellular: Fix AT command for COPS manual network selection 2019-12-12 00:31:43 -08:00
Antti Kauppila 35c2b60800 Coverity fix for ATHAndler
Unneeded NULL check removed
2019-12-11 09:25:29 +02:00
Antti Kauppila e221ba9bb9 initialisation added for _property_array 2019-12-09 15:25:22 +02:00
Antti Kauppila 30ea858f51 Disable APN lookup by default 2019-12-09 15:25:22 +02:00
Antti Kauppila 90d3dc1f13 CellularStack fixed 2019-12-09 15:25:22 +02:00
Antti Kauppila e51230c5e4 Remove CellularBase and AT_CellularBase
Removed CellularBase and AT_CellularBase from cellular stack and updated both code and unittests accordingly.

Moved property handling into AT_CellularDevice
2019-12-09 15:25:22 +02:00
Martin Kojtal e4e6ac5bd6
Merge pull request #12008 from AriParkkila/cell-at-string-fix
Cellular: Fix ATHandler string handling
2019-12-03 15:52:39 +01:00
Ari Parkkila c22dd77f42 Cellular: Fix ATHandler string handling 2019-12-03 03:21:13 -08:00
Martin Kojtal ffdd54315f
Merge pull request #11941 from michalpasztamobica/remove_internal_string_apis
Remove string-based API usage within mbed-os
2019-11-28 14:26:03 +01:00
Michal Paszta ea04c4f85e Remove internal usage of deprecated APIs in IPCore
Updated:
* netsocket classes,
* unittests, stubs and mocks,
* greentea tests
2019-11-27 20:02:20 +02:00
Martin Kojtal 9974d831fe
Merge pull request #11949 from ARMmbed/acabarbaye-patch-1
Fix for ARMC5 compilation errors for some targets
2019-11-27 13:12:14 +01:00
Martin Kojtal 58d6f5f39f
Merge pull request #11873 from AnttiKauppila/disable_sms
Make SMS configurable in Cellular stack
2019-11-27 09:03:55 +01:00
Adrien CABARBAYE de57ba8b50
Fix for ARMC5 compilation errors for some targets
the following compilation error is seen for a number of targets when compiling using ARMC5
`tools.utils.ToolException: "./mbed-os/features/cellular/framework/AT/AT_CellularContext.cpp", line 247: Error:  #20: identifier "sprintf" is undefined`

Failing command:
> 5.06u6/bin/armcc -c --gnu -Ospace --split_sections --apcs=interwork --brief_diagnostics --restrict --multibyte_chars -O3 -DMBED_TRAP_ERRORS_ENABLED=1 --cpu=Cortex-M4.fp.sp --md --no_depend_system_headers --c99 -D__ASSERT_MSG --cpp11 --no_rtti --no_vla -DDEVICE_SERIAL_ASYNCH=1 -D__MBED__=1 -D__CORTEX_M4 -DTOOLCHAIN_ARM -DMBED_BUILD_TIMESTAMP=1574735332.2275832 -DTARGET_RELEASE -DTARGET_GigaDevice -DDEVICE_SERIAL_FC=1 -DARM_MATH_CM4 -DTARGET_LIKE_MBED -DTARGET_GD32E10X -D__FPU_PRESENT=1 -DTARGET_GD32_Target -DTARGET_M4 -DDEVICE_RTC=1 -DDEVICE_INTERRUPTIN=1 -DCOMPONENT_PSA_SRV_EMUL=1 -D__CMSIS_RTOS -DTOOLCHAIN_ARMC5 -DDEVICE_SPISLAVE=1 -DTARGET_GD32_E103VB -DTARGET_CORTEX -DDEVICE_PORTIN=1 -DDEVICE_ANALOGOUT=1 -DDEVICE_I2C=1 -DDEVICE_ANALOGIN=1 -DDEVICE_FLASH=1 -DDEVICE_SLEEP=1 -DCOMPONENT_NSPE=1 -DDEVICE_SERIAL=1 -DDEVICE_PORTOUT=1 -DTARGET_GD32E103VB -DDEVICE_CAN=1 -DTARGET_NAME=GD32_E103VB -DTARGET_CORTEX_M -D__MBED_CMSIS_RTOS_CM -DDEVICE_PWMOUT=1 -DTARGET_FF_ARDUINO -DGD32E10X -DDEVICE_USTICKER=1 -DTARGET_RTOS_M4_M7 -DDEVICE_PORTINOUT=1 -DTOOLCHAIN_ARM_STD -DCOMPONENT_PSA_SRV_IMPL=1 -DDEVICE_SPI=1 -DTARGET_LIKE_CORTEX_M4 -DDEVICE_I2CSLAVE=1 --preinclude=./BUILD/GD32_E103VB/ARMC5/mbed_config.h --via ./BUILD/GD32_E103VB/ARMC5/.includes_022feb5c2e44b9896df9a82c69438bc9.txt --depend BUILD/GD32_E103VB/ARMC5/mbed-os/features/cellular/framework/AT/AT_CellularContext.d -o BUILD/GD32_E103VB/ARMC5/mbed-os/features/cellular/framework/AT/AT_CellularContext.o ./mbed-os/features/cellular/framework/AT/AT_CellularContext.cpp
[Error] AT_CellularContext.cpp@247,0:  #20: identifier "sprintf" is undefined
2019-11-26 15:05:52 +00:00
Ari Parkkila adba109de6 Cellular: Replace CellularSocket.rx_avail with pending_bytes
CellularSocket::rx_avail can be refactored away as
it is a duplicate to CellularSocket::pending_bytes.
2019-11-25 21:49:17 -08:00