Commit Graph

84 Commits (mbed-os-5.12)

Author SHA1 Message Date
Hasnain Virk 9b90f52e46 Using new rather than malloc in debug_print
Using malloc will require us to add stdlib.h somewhere in the path for
the application. Maybe the CI apps are adding stdlib.h and that's why
the code would have worked. In a custom app, it can happen that the
header is not included. Using new avoids the need to add stdlib.h
anywhere and it is more in line with C++.
2019-04-24 13:37:42 +01:00
Mirela Chirica 1680d07442 Cellular: Check for URC during AT response stop 2019-04-24 13:37:42 +01:00
Kimmo Vaisanen a2857bac97 Cellular: Improve ATHandler AT traces
Original AT traces had several issue:
- Can be overwritten by other traces (printf/mbed-trace)
- No way to know which direction message was going (TX or RX)
- <cr> and <ln> characters were not visible in trace
etc.

This commit addresses those issues using mbed-trace and showing separately
each filehandle write and read.
2019-04-05 12:27:00 +01:00
Teppo Järvelin a12f8cd5db Cellular: don't allow ATHandler read/write if filehandle not usable
For example after going to ppp mode we must block at write and
read as filehandle is not usable.
2019-04-05 12:26:18 +01:00
Mirela Chirica 6cbe74f794 Cellular: AT information response to return false on empty prefix 2019-04-05 12:26:15 +01:00
Teppo Järvelin ec73c8a9c7 Cellular: fix connect-disconnect sequence called many times
Fix syncing back to at mode after ppp disconnect.
Fix AT_CellularContext flags and states to allow new connect after disconnect.
Fix that state machine is not reseted in disconnect is it's running (might be
running because of another context or new connect already started).
2019-03-01 14:47:41 +02:00
Cruz Monrreal 2234dac127
Merge pull request #9751 from AriParkkila/athandler-set_at_timeout
Cellular: Fix ATHandler set/restore_at_timeout with mutex lock
2019-02-19 15:29:38 -06:00
Ari Parkkila d48adcce2c Cellular: Fix ATHandler set/restore_at_timeout with mutex lock 2019-02-19 00:16:45 -08:00
Ari Parkkila 5aaf42c418 Cellular: ATHandler debugging relieved 2019-02-17 23:49:01 -08:00
Cruz Monrreal fdd2a9402a
Merge pull request #9728 from AriParkkila/at-handler-clear-sigio
Cellular: Fix sigio to be released in ATHandler destructor
2019-02-15 12:41:44 -06:00
Ari Parkkila 0c697f4421 Cellular: Fix sigio to be released in ATHandler destructor 2019-02-15 05:07:36 -08:00
Jari Poyhonen b6a0892e86 Cellular: clean sensitive information from trace
Information removed from the cellular subsystem trace log:
* SIM pin
* APN username and password

Added get_debug() to ATHandler.h to get the current trace state in order
to support suspend/resume of trace output.
2019-02-14 09:22:54 +02:00
Jari Poyhonen 84536bd09e cellular ATHandler update due valgrind run 2019-01-23 09:43:03 +02:00
Teppo Järvelin 84e5013a2d Cellular: added setting of data carrier support for UART. 2019-01-22 02:23:04 -08:00
Teppo Järvelin b0d37ebec4 Cellular: Removed unnecessary checks after new
After this change we were able to change methods
ATHandler::set_urc_handler and CellularDevice::set_ready_cb to void
and simplify error handling.
2019-01-22 02:23:04 -08:00
Ari Parkkila 19b24946df Cellular: AT remove_urc_handler changed to set_urc_handler(prefix, 0) 2019-01-22 02:23:03 -08:00
Teemu Kultala b87b52a45c cellular: AT Handler API changes after review 2018-12-14 13:19:03 +02:00
Teemu Kultala dbdbae3632 cellular: AT Handler API 2018-12-14 13:19:03 +02:00
Mirela Chirica 806e95cf67 Cellular: Rewrite AT handler consume to tag
If sequence from buffer contains tag but symbol before tag is same as
first symbol of the tag, then the tag wasn't detected.

For example, "\r\n" tag was not found from "\r\r\nOK" sequence.
2018-12-11 15:36:33 +02:00
Martin Kojtal bf36ff77c1
Merge pull request #8855 from michalpasztamobica/warnings_fix
Fix compilation warnings (apart from nanostack)
2018-12-03 13:31:55 +01:00
Michal Paszta e101943cce Fix compilation warnings (apart from nanostack) 2018-11-26 14:27:48 +01:00
Ari Parkkila 3d79b50dfb Cellular: Fix ATHandler URC processing 2018-11-25 23:47:23 -08:00
Martin Kojtal 5ad7c3ee6e Merge branch 'gracefully_disconnect' of https://github.com/jarvte/mbed-os into dev_rollup 2018-11-24 21:15:38 +00:00
Teppo Järvelin a655a538b0 Cellular: more gracefully disconnect. 2018-11-19 16:02:30 +02:00
Ari Parkkila 9bdeb68e74 Cellular: Updated debug prints, and network registration return value
Updated cellular debug trace prints:
 - Removed unnecessary prints.
 - Tracing more in DEBUG level.
 - Read/write bytes not printed on big packets.
 - Signal quality (RSSI) traced to log network problems.
 - Dismissed AT data is traced.
 - Modem type and firmware version are traced.

Network registration returns NotRegistered instead of StatusNotAvailable,
because that's not in 3GPP TS 27.007.
2018-11-19 02:55:43 -08:00
Martin Kojtal 71d35749f9 cellular: fix coding style 2018-11-07 08:56:32 +00:00
Mirela Chirica c8f2ed3d30 Cellular: ATHandler to reset match URC generated errors and continue response handling 2018-10-29 13:33:11 +02:00
Mirela Chirica 4e6cbb8f5f Cellular: ATHandler's mem_str fixed to work on matching strings 2018-10-29 13:33:10 +02:00
Mirela Chirica 273590f615 Cellular: Added ATHandler option to write parameters without delimiters 2018-10-29 13:33:09 +02:00
Mirela Chirica f016d1126f Cellular: AT handler to support only one callback per URC/prefix 2018-10-29 13:32:15 +02:00
Cruz Monrreal 69904ea43e
Merge pull request #8313 from kivaisan/reduce_memory_footprint
Reduce cellular memory footprint
2018-10-23 09:05:39 -05:00
Cruz Monrreal ba23fef90b
Merge pull request #8350 from mirelachirica/at_consume_to_tag_fix
Cellular: Fix for AT handler consume to tag
2018-10-22 19:45:24 -05:00
Kimmo Vaisanen 963bf8146d Cellular: Refactor basic AT command stop and response reading into own method
This reduces ROM usage by few hundred bytes.
2018-10-22 09:44:12 +03:00
Mirela Chirica 31f153af7d Cellular: Fix for AT handler consume to tag
If sequence from buffer contains tag but symbol before tag is same as
first symbol of the tag, then the tag wasn't detected.

For example, "\r\n" tag was not found from "\r\r\nOK" sequence.
2018-10-19 15:21:02 +03:00
Kevin Bracey 1ef213ec89 Clean up Thread deprecation warnings
Static Thread methods and signal methods have been deprecated. Remove
all references in the main code, and most of the tests. Some tests of
the deprecated APIs themselves remain.
2018-10-12 14:57:13 +03:00
Mirela Chirica 723e913bcc Cellular: AT handler read string up to delimiter or stop tag 2018-10-09 10:47:25 +03:00
Antti Kauppila a6b4938844 Small improvements for test cases 2018-09-17 12:07:43 +03:00
Martin Kojtal cde18aa0bc cellular: astyle fix 2018-07-27 13:33:20 +01:00
Mirela Chirica aff55462f5 Cellular: Fix for ATHandler's read string and hexstring NULL termination 2018-07-10 15:09:09 +03:00
Teppo Järvelin d9a99b0a45 Cellular: release resources in state machine. Made sure that athandler does not try process urc's after switch to data mode. 2018-06-12 09:01:03 +03:00
Ari Parkkila 7482032989 Cellular: Enable AT debug also when mbed-trace is disabled 2018-06-01 14:07:27 +03:00
Cruz Monrreal 0f41831afd
Merge pull request #7033 from AriParkkila/cellular-at-fix
Cellular: Fix AT URC handler not to dismiss incoming chars
2018-05-29 10:44:00 -05:00
Cruz Monrreal 206cab97ac
Merge pull request #6965 from mirelachirica/fix_unittests
Cellular: Unit tests fixes
2018-05-29 10:37:35 -05:00
Ari Parkkila c8287e5470 Cellular: Fix AT URC handler not to dismiss incoming chars 2018-05-28 10:32:14 +03:00
Mirela Chirica b59ef26930 Cellular: Unit tests fixes 2018-05-23 12:11:02 +03:00
Ari Parkkila 6a3dce839e Cellular: Updated coding guidelines 2018-05-17 09:02:54 +03:00
Ari Parkkila a146e0e7ff Cellular: AT debugging improved 2018-05-16 12:39:30 +03:00
Ari Parkkila 287a1a86d0 Cellular: AT handler review fixes 2018-05-14 10:25:00 +03:00
Ari Parkkila 3bdb6d1737 Cellular: Fixed ATHandler write poll timeout 2018-05-14 10:25:00 +03:00
Ari Parkkila 9b896a16bb Cellular: ATHandler yield to wait review fixes 2018-05-14 10:25:00 +03:00