Commit Graph

39 Commits (feature-wisun)

Author SHA1 Message Date
Antti Kauppila 353782bf63 Disable SMS by default from Cellular stack
Put SMS behind configuration flag to save some memory (4,5kB) for Cellular users not needing SMS features.
UBlox N2XX target is also updated
2019-11-25 11:38:06 +02:00
George Psimenos 93cebc189c Avoid potential overflow 2019-09-02 15:48:30 +01:00
George Psimenos 4df70449fe Replace difftime and float literals 2019-09-02 14:56:56 +01:00
Martin Kojtal a1540c5f77
Merge pull request #11245 from dextero/8bit-sms
AT_CellularSMS: allow configuring SMS encoding (7-bit/8-bit) at initialization
2019-08-23 13:51:59 +02:00
Martin Kojtal 0b49952b9e
Merge pull request #11249 from dextero/get-sms-zero
Make AT_CellularSMS::list_messages support index 0 in SMS inbox
2019-08-20 10:27:57 +02:00
Martin Kojtal 9ccfe49d12
Merge pull request #11247 from dextero/international-numbers
AT_CellularSMS: set "international" flag in PDU when applicable
2019-08-20 10:27:13 +02:00
Marcin Radomski 17f6f1c0e3 Make AT_CellularSMS support index 0 in SMS inbox
When AT+CGML is used to retrieve list of SMS stored in modem inbox,
every message has an associated index. ETSI TS 127 005 v7.0.0 does not
specify what is the allowed range of such indices - all it says is
"integer type; value in the range of location numbers supported by the
associated memory".

Usually, AT modems use positive indexes (starting at 1). Quectel BG96
modem takes a different approach, indexing messages starting at 0.

Current implementation of `AT_CellularSMS::list_messages()` considers
index 0 invalid and ignores such message, effectively making it
impossible to access using mbed-os API.

This commit changes the behavior so that value of 0 is handled as any
other positive message index.
2019-08-16 14:19:29 +02:00
Marcin Radomski 2bfa4e9b8d AT_CellularSMS: set "international" flag in PDU when applicable
Currently, create_pdu receives a destination address without '+' prefix,
and always sets the "type of address" to "unknown". That means, the
number needs to contain appropriate international number prefix (00/011)
if necessary - which is not the case if the leading + is simply
stripped.

This changes send_sms behavior so that when a SMS is sent to an
international number (indicated by leading +):

- AT+CMGS command receives the number with + prefix,
- created PDU has the "international" flag set.
2019-08-16 13:30:59 +02:00
Marcin Radomski f3e9501ac6 Increase PDU buffer size to fit 8-bit-encoded hex string 2019-08-16 13:20:37 +02:00
Marcin Radomski 14f8d15242 Add option to set up SMS encoding 2019-08-16 12:24:54 +02:00
Antti Kauppila 84063bf222 Coverity issues fixed 2019-08-14 16:22:05 +03:00
Kevin Bracey a522dcfa0a Replace deprecated wait calls 2019-07-15 10:13:50 +03:00
Kevin Bracey 607856ee9a Set unit tests to C++14
Adjust some non-C++11-compatible code that failed as a result.
2019-07-09 19:08:57 +03:00
Antti Kauppila 83d62fbb9c astyle fixes 2019-05-29 20:13:22 +03:00
Antti Kauppila 77e8374058 Cellular: Removed boiler plate code 2019-05-29 16:17:08 +03:00
mudassar-ublox 6c347eafe5 C030_N211 cellular api refactoring 2019-02-26 17:28:01 +05:00
mudassar-ublox da797ef946 C030_N211 cellular api 2019-02-21 14:44:20 +05:00
Neil MacMullen f29c5b22a1 Keep style linter happy 2019-02-12 14:37:07 +00:00
Neil MacMullen a7f4cbcdce Make a few trivial syntactic changes to better support cross-compilation 2019-02-12 12:01:05 +00:00
Teppo Järvelin b0d37ebec4 Cellular: Removed unnecessary checks after new
After this change we were able to change methods
ATHandler::set_urc_handler and CellularDevice::set_ready_cb to void
and simplify error handling.
2019-01-22 02:23:04 -08:00
Teppo Järvelin 9fb83024ea Changed CellularContext to inherit from CellularBase instead of NetworkInterface. \n Changed Device constructor to take Filehandle instead of eventqueue. 2018-11-11 14:13:05 +02:00
Martin Kojtal 71d35749f9 cellular: fix coding style 2018-11-07 08:56:32 +00:00
Kimmo Vaisanen 963bf8146d Cellular: Refactor basic AT command stop and response reading into own method
This reduces ROM usage by few hundred bytes.
2018-10-22 09:44:12 +03:00
Kimmo Vaisanen 553718ba5b Cellular: Optimize memory usage for gsm_to_ascii table
gsm_to_ascii table contains ASCII codes, so it can be a char table instead of int table.

This reduces ROM usage by 384 bytes.
2018-10-22 08:35:33 +03:00
Antti Kauppila a6b4938844 Small improvements for test cases 2018-09-17 12:07:43 +03:00
Teemu Kultala df8252539b sms gt tests: rebase and astyle fix 2018-08-07 16:34:46 +03:00
Teemu Kultala 2b82746ae2 sms gt tests: changes after review 2018-08-07 14:10:57 +03:00
Teemu Kultala f9a90d82b0 sms gt tests 2018-08-07 14:10:57 +03:00
Martin Kojtal cde18aa0bc cellular: astyle fix 2018-07-27 13:33:20 +01:00
Mirela Chirica b59ef26930 Cellular: Unit tests fixes 2018-05-23 12:11:02 +03:00
Teppo Järvelin f6be35c0f2 Fixed coverity warnings for AT_CellularSMS.cpp 2018-04-11 09:31:44 +03:00
Teppo Järvelin d1f2e91e93 Working version of async registration. 2018-04-11 09:31:44 +03:00
Teppo Järvelin e99c18c233 Fixed SMS receive in PDU: certain length sms last char was missing. 2018-03-02 14:38:07 +02:00
Teppo Järvelin 7a8da2244d Fixed SMS send in pdu mode could give wrong size as return value. 2018-03-02 14:38:07 +02:00
Ari Parkkila f2613a6154 Cellular logging to use mbed_trace 2018-03-02 14:38:06 +02:00
Mirela Chirica a35e1f8d6c - Removed extra whitespaces from AT prefix definitions. The format is modem specific and AT handler is handling whitespaces in case they are present
- Reverted the "smaller thread stack size for dispatcher thread". 1KB is not enough, was causing CMSIS-RTOS error: Stack underflow.
2018-03-02 14:38:05 +02:00
Teppo Järvelin 4a6bcc4a0a Fixed doxygen warning. 2018-03-02 14:38:05 +02:00
Antti Kauppila bfbd3e42af more unittests added 2018-03-02 14:38:05 +02:00
Ari Parkkila 863ec3c3cc Initial cellular feature 2018-03-02 14:38:02 +02:00