From 1826978e8cc71e351ec902931221a64dea74ec52 Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Tue, 23 Aug 2016 14:47:43 -0500 Subject: [PATCH 1/2] Fixed recvfrom address in ipv4 nist tests Previous behaviours overwrote server address on failures --- .../TESTS/mbedmicro-net/nist_internet_time_service/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/net/FEATURE_IPV4/TESTS/mbedmicro-net/nist_internet_time_service/main.cpp b/features/net/FEATURE_IPV4/TESTS/mbedmicro-net/nist_internet_time_service/main.cpp index 717b60180d..20a1bb2830 100644 --- a/features/net/FEATURE_IPV4/TESTS/mbedmicro-net/nist_internet_time_service/main.cpp +++ b/features/net/FEATURE_IPV4/TESTS/mbedmicro-net/nist_internet_time_service/main.cpp @@ -42,7 +42,7 @@ int main() { int ret_send = sock.sendto(nist, (void*)ntp_send_values, sizeof(ntp_send_values)); printf("UDP: Sent %d Bytes to NTP server \n", ret_send); - const int n = sock.recvfrom(&nist, (void*)ntp_recv_values, sizeof(ntp_recv_values)); + const int n = sock.recvfrom(NULL, (void*)ntp_recv_values, sizeof(ntp_recv_values)); printf("UDP: Recved from NTP server %d Bytes \n", n); From 47018fe1acb2feb25a87777217d0dc58dc6421fc Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Tue, 23 Aug 2016 15:09:58 -0500 Subject: [PATCH 2/2] Added check for packet address in ipv4 nist test --- .../TESTS/mbedmicro-net/nist_internet_time_service/main.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/features/net/FEATURE_IPV4/TESTS/mbedmicro-net/nist_internet_time_service/main.cpp b/features/net/FEATURE_IPV4/TESTS/mbedmicro-net/nist_internet_time_service/main.cpp index 20a1bb2830..0349dfe8b8 100644 --- a/features/net/FEATURE_IPV4/TESTS/mbedmicro-net/nist_internet_time_service/main.cpp +++ b/features/net/FEATURE_IPV4/TESTS/mbedmicro-net/nist_internet_time_service/main.cpp @@ -42,11 +42,12 @@ int main() { int ret_send = sock.sendto(nist, (void*)ntp_send_values, sizeof(ntp_send_values)); printf("UDP: Sent %d Bytes to NTP server \n", ret_send); - const int n = sock.recvfrom(NULL, (void*)ntp_recv_values, sizeof(ntp_recv_values)); + SocketAddress source; + const int n = sock.recvfrom(&source, (void*)ntp_recv_values, sizeof(ntp_recv_values)); printf("UDP: Recved from NTP server %d Bytes \n", n); - if (n > 0) { + if (n > 0 && strcmp(source.get_ip_address(), nist.get_ip_address()) == 0) { result = true; printf("UDP: Values returned by NTP server: \n");