ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

BLE: correctness improvments 

Remove unused variable, improve header inclusion, fix initialization list order,
pull/13475/head
Vincent Coubard 2020-09-04 13:26:29 +01:00
parent 702c1b9756
commit f116604024
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
connectivity/FEATURE_BLE/include/ble/gap/AdvertisingDataSimpleBuilder.h
View File

@ -68,7 +68,7 @@ public:
/** /**
* Construct a AdvertisingDataSimpleBuilder * Construct a AdvertisingDataSimpleBuilder
*/ */
AdvertisingDataSimpleBuilder() : _builder(_buffer), _buffer() AdvertisingDataSimpleBuilder() : _buffer(), _builder(_buffer)
{ {
} }

2
connectivity/FEATURE_BLE/source/cordio/source/GattServerImpl.cpp
View File

@ -991,8 +991,6 @@ uint8_t GattServer::atts_write_cb(
attsAttr_t *pAttr attsAttr_t *pAttr
) )
{ {
uint8_t err;
GattCharacteristic* auth_char = getInstance().get_auth_char(handle); GattCharacteristic* auth_char = getInstance().get_auth_char(handle);
if (auth_char && auth_char->isWriteAuthorizationEnabled()) { if (auth_char && auth_char->isWriteAuthorizationEnabled()) {
GattWriteAuthCallbackParams write_auth_params = { GattWriteAuthCallbackParams write_auth_params = {

6
connectivity/FEATURE_BLE/source/generic/GapImpl.h
View File

@ -37,11 +37,7 @@
#include "ble/gap/Events.h" #include "ble/gap/Events.h"
#include "source/pal/PalGap.h" #include "source/pal/PalGap.h"
#include "source/pal/GapEvents.h"
#include "source/pal/GapTypes.h"
#include "source/pal/PalEventQueue.h"
#include "source/pal/PalConnectionMonitor.h" #include "source/pal/PalConnectionMonitor.h"
#include "source/pal/PalEventQueue.h"
#include "ble/Gap.h" #include "ble/Gap.h"
@ -53,6 +49,8 @@ class PalSecurityManager;
class PalGap; class PalGap;
class PalEventQueue;
namespace impl { namespace impl {
class BLEInstanceBase; class BLEInstanceBase;