From ec8ac75e8849ee73a762863ce9760018241ab0f7 Mon Sep 17 00:00:00 2001 From: bsilvereagle Date: Wed, 15 Apr 2015 09:11:39 -0400 Subject: [PATCH 1/2] Replaced SPI pin definitions for K64F in SD tests The old pin definitions were all for Port D pins, which are incorrect. These improper pin mappings caused all tests to fail. Pin definitions were replaced with the definitions as stated here - http://developer.mbed.org/media/uploads/sam_grove/xk64f_sensors.jpg.pagespeed.ic.RCpM8talCK.webp Tests now pass on the K64F Sch Rev D1 --- libraries/tests/mbed/sd/main.cpp | 2 +- libraries/tests/mbed/sd_perf_fatfs/main.cpp | 2 +- libraries/tests/mbed/sd_perf_fhandle/main.cpp | 2 +- libraries/tests/mbed/sd_perf_stdio/main.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libraries/tests/mbed/sd/main.cpp b/libraries/tests/mbed/sd/main.cpp index eb23347c99..2d1b5a19cf 100644 --- a/libraries/tests/mbed/sd/main.cpp +++ b/libraries/tests/mbed/sd/main.cpp @@ -9,7 +9,7 @@ SDFileSystem sd(PTD2, PTD3, PTD1, PTD0, "sd"); SDFileSystem sd(PTD6, PTD7, PTD5, PTD4, "sd"); #elif defined(TARGET_K64F) -SDFileSystem sd(PTD2, PTD3, PTD1, PTD0, "sd"); +SDFileSystem sd(PTE3, PTE1, PTE2, PTE4, "sd"); #elif defined(TARGET_K22F) SDFileSystem sd(PTD6, PTD7, PTD5, PTD4, "sd"); diff --git a/libraries/tests/mbed/sd_perf_fatfs/main.cpp b/libraries/tests/mbed/sd_perf_fatfs/main.cpp index 5b5e83b953..6e95fec97a 100644 --- a/libraries/tests/mbed/sd_perf_fatfs/main.cpp +++ b/libraries/tests/mbed/sd_perf_fatfs/main.cpp @@ -11,7 +11,7 @@ SDFileSystem sd(PTD2, PTD3, PTD1, PTD0, "sd"); SDFileSystem sd(PTD6, PTD7, PTD5, PTD4, "sd"); #elif defined(TARGET_K64F) -SDFileSystem sd(PTD2, PTD3, PTD1, PTD0, "sd"); +SDFileSystem sd(PTE3, PTE1, PTE2, PTE4, "sd"); #elif defined(TARGET_K22F) SDFileSystem sd(PTD6, PTD7, PTD5, PTD4, "sd"); diff --git a/libraries/tests/mbed/sd_perf_fhandle/main.cpp b/libraries/tests/mbed/sd_perf_fhandle/main.cpp index 5d16b71b4d..209c948145 100644 --- a/libraries/tests/mbed/sd_perf_fhandle/main.cpp +++ b/libraries/tests/mbed/sd_perf_fhandle/main.cpp @@ -11,7 +11,7 @@ SDFileSystem sd(PTD2, PTD3, PTD1, PTD0, "sd"); SDFileSystem sd(PTD6, PTD7, PTD5, PTD4, "sd"); #elif defined(TARGET_K64F) -SDFileSystem sd(PTD2, PTD3, PTD1, PTD0, "sd"); +SDFileSystem sd(PTE3, PTE1, PTE2, PTE4, "sd"); #elif defined(TARGET_K22F) SDFileSystem sd(PTD6, PTD7, PTD5, PTD4, "sd"); diff --git a/libraries/tests/mbed/sd_perf_stdio/main.cpp b/libraries/tests/mbed/sd_perf_stdio/main.cpp index c7ee9f35a0..46c14bcb66 100644 --- a/libraries/tests/mbed/sd_perf_stdio/main.cpp +++ b/libraries/tests/mbed/sd_perf_stdio/main.cpp @@ -11,7 +11,7 @@ SDFileSystem sd(PTD2, PTD3, PTD1, PTD0, "sd"); SDFileSystem sd(PTD6, PTD7, PTD5, PTD4, "sd"); #elif defined(TARGET_K64F) -SDFileSystem sd(PTD2, PTD3, PTD1, PTD0, "sd"); +SDFileSystem sd(PTE3, PTE1, PTE2, PTE4, "sd"); #elif defined(TARGET_K22F) SDFileSystem sd(PTD6, PTD7, PTD5, PTD4, "sd"); From 72d62f783b162d69d116c001a9ca9750dbaa6d61 Mon Sep 17 00:00:00 2001 From: bsilvereagle Date: Thu, 16 Apr 2015 11:47:51 -0400 Subject: [PATCH 2/2] Mentioned the Contributor Agreement in Contributing.md --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5a588ed021..353cd58c0f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,6 +10,8 @@ You can for example read more in our ```docs``` section in [mbedmicro/mbed/doc]( # How to contribute We really appreciate your contributions! We are Open Source project and we need your help. We want to keep it as easy as possible to contribute changes that get things working in your environment. There are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things. +Before a pull request will be merged, the [mbed Contributor Agreement](http://developer.mbed.org/contributor_agreement/) must be signed. + You can pick up existing [mbed GitHub Issue](https://github.com/mbedmicro/mbed/issues) and solve it or implement new feature you find important, attractive or just necessary. We will review your proposal via pull request mechanism, give you comments and merge your changes if we decide your contribution satisfy criteria such as quality. # Enhancements vs Bugs