diff --git a/storage/kvstore/include/kvstore/TDBStore.h b/storage/kvstore/include/kvstore/TDBStore.h index 8a823a1c66..5115d12675 100644 --- a/storage/kvstore/include/kvstore/TDBStore.h +++ b/storage/kvstore/include/kvstore/TDBStore.h @@ -308,6 +308,7 @@ private: tdbstore_area_data_t _area_params[_num_areas]; uint32_t _prog_size; uint8_t *_work_buf; + size_t _work_buf_size; char *_key_buf; void *_inc_set_handle; void *_iterator_table[_max_open_iterators]; diff --git a/storage/kvstore/source/TDBStore.cpp b/storage/kvstore/source/TDBStore.cpp index b0be309ee8..787e7349c4 100644 --- a/storage/kvstore/source/TDBStore.cpp +++ b/storage/kvstore/source/TDBStore.cpp @@ -77,7 +77,7 @@ typedef struct { uint32_t crc; } reserved_trailer_t; -static const uint32_t work_buf_size = 64; +static const size_t min_work_buf_size = 64; static const uint32_t initial_crc = 0xFFFFFFFF; static const uint32_t initial_max_keys = 16; @@ -130,7 +130,7 @@ static uint32_t calc_crc(uint32_t init_crc, uint32_t data_size, const void *data TDBStore::TDBStore(BlockDevice *bd) : _ram_table(0), _max_keys(0), _num_keys(0), _bd(bd), _buff_bd(0), _free_space_offset(0), _master_record_offset(0), _master_record_size(0), _is_initialized(false), _active_area(0), _active_area_version(0), _size(0), - _area_params{}, _prog_size(0), _work_buf(0), _key_buf(0), _inc_set_handle(0) + _area_params{}, _prog_size(0), _work_buf(0), _work_buf_size(0), _key_buf(0), _inc_set_handle(0) { for (int i = 0; i < _num_areas; i++) { _area_params[i] = { 0 }; @@ -327,7 +327,7 @@ int TDBStore::read_record(uint8_t area, uint32_t offset, char *key, user_key_ptr[key_size] = '\0'; } else { dest_buf = _work_buf; - chunk_size = std::min(key_size, work_buf_size); + chunk_size = std::min(key_size, _work_buf_size); } } else { // This means that we're on the data part @@ -337,13 +337,13 @@ int TDBStore::read_record(uint8_t area, uint32_t offset, char *key, // 3. After actual part is finished - read to work buffer // 4. Copy data flag not set - read to work buffer if (curr_data_offset < data_offset) { - chunk_size = std::min((size_t)work_buf_size, (size_t)(data_offset - curr_data_offset)); + chunk_size = std::min(_work_buf_size, (data_offset - curr_data_offset)); dest_buf = _work_buf; } else if (copy_data && (curr_data_offset < data_offset + actual_data_size)) { chunk_size = actual_data_size; dest_buf = static_cast(data_buf); } else { - chunk_size = std::min(work_buf_size, total_size); + chunk_size = std::min(_work_buf_size, total_size); dest_buf = _work_buf; } } @@ -860,7 +860,7 @@ int TDBStore::copy_record(uint8_t from_area, uint32_t from_offset, uint32_t to_o total_size -= chunk_size; while (total_size) { - chunk_size = std::min(total_size, work_buf_size); + chunk_size = std::min(total_size, _work_buf_size); ret = read_area(from_area, from_offset, chunk_size, _work_buf); if (ret) { return ret; @@ -1044,7 +1044,8 @@ int TDBStore::init() } _prog_size = _bd->get_program_size(); - _work_buf = new uint8_t[work_buf_size]; + _work_buf_size = std::max(_prog_size, min_work_buf_size); + _work_buf = new uint8_t[_work_buf_size]; _key_buf = new char[MAX_KEY_SIZE]; _inc_set_handle = new inc_set_handle_t; memset(_inc_set_handle, 0, sizeof(inc_set_handle_t));