ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Removed dead code from athandler.

pull/6082/head
Teppo Järvelin 2018-02-12 15:56:31 +02:00 committed by Ari Parkkila
parent 30a3ec8e0d
commit bf3d587571
2 changed files with 3 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
features/cellular/framework/AT/ATHandler.cpp
View File

@ -262,15 +262,6 @@ void ATHandler::process_oob()
unlock();
}
// oob match settings
//DEAD CODE?
void ATHandler::set_oobs_matching_param(bool is_it_a_match_or_not)
{
for (struct oob_t *oob = _oobs; oob; oob = oob->next) {
oob->matching_to_received = is_it_a_match_or_not;
}
}
void ATHandler::set_filehandle_sigio()
{
if (_fh_sigio_set) {
@ -515,7 +506,7 @@ void ATHandler::set_stop_tag(const char *stop_tag_seq)
set_tag(_stop_tag, stop_tag_seq);
}
void ATHandler::set_scope(ScopeType scope_type, const char* stop_tag)
void ATHandler::set_scope(ScopeType scope_type)
{
log_debug("%s: %d", __func__, scope_type);
if (_current_scope != scope_type) {
@ -541,11 +532,6 @@ void ATHandler::set_scope(ScopeType scope_type, const char* stop_tag)
break;
}
}
//CURRENTLY DEAD CODE
if (stop_tag) {
set_stop_tag(stop_tag);
}
}
// should match from recv_pos?
@ -577,7 +563,7 @@ bool ATHandler::match_urc()
if (match(oob->prefix, prefix_len)) {
log_debug("URC!");
set_scope(InfoType);
if(oob->cb){
if (oob->cb) {
oob->cb();
}
information_response_stop();
@ -986,10 +972,6 @@ void ATHandler::write_int(int32_t param)
break;
}
}
} else {
//This is DEAD CODE: longest value is "-2147483648" which is 11 characters long and passing int64 is not possible!
// must have been 64-bit integer, not supported
set_error(NSAPI_ERROR_PARAMETER);
}
}

3
features/cellular/framework/AT/ATHandler.h
View File

@ -176,7 +176,6 @@ protected:
private:
void set_error(nsapi_error_t err);
void set_oobs_matching_param(bool);
events::EventQueue &_queue;
nsapi_error_t _last_err;
@ -361,7 +360,7 @@ private:
// information response contains parameters or subsets of parameters(elements), both separated by comma
// elem_type: subsets of parameters that are part of information response, its parameters are separated by comma
enum ScopeType {RespType, InfoType, ElemType, NotSet};
void set_scope(ScopeType scope_type, const char* stop_tag = NULL);
void set_scope(ScopeType scope_type);
ScopeType _current_scope;
struct tag_t {