Explicitly return None

pull/10326/head
Jimmy Brisson 2019-03-12 11:12:39 -05:00 committed by Martin Kojtal
parent d025435d2a
commit bc1fbe3432
1 changed files with 5 additions and 3 deletions

View File

@ -364,13 +364,15 @@ class Target(namedtuple("Target", "name json_data resolution_order resolution_or
Positional Arguments: Positional Arguments:
hook - the hook object to add post-binary-hooks to hook - the hook object to add post-binary-hooks to
toolchain - the toolchain object for inspection toolchain - the toolchain object for inspection
Return Value:
A callable if any post-build hook is applicable or None
""" """
# If there's no hook, simply return
try: try:
hook_data = self.post_binary_hook hook_data = self.post_binary_hook
except AttributeError: except AttributeError:
return return None
# A hook was found. The hook's name is in the format # A hook was found. The hook's name is in the format
# "classname.functionname" # "classname.functionname"
temp = hook_data["function"].split(".") temp = hook_data["function"].split(".")
@ -403,7 +405,7 @@ class Target(namedtuple("Target", "name json_data resolution_order resolution_or
toolchain_restrictions = set(hook_data.get("toolchains", [])) toolchain_restrictions = set(hook_data.get("toolchains", []))
if toolchain_restrictions and \ if toolchain_restrictions and \
not set(toolchain_labels).intersection(toolchain_restrictions): not set(toolchain_labels).intersection(toolchain_restrictions):
return return None
return getattr(cls, function_name) return getattr(cls, function_name)
################################################################################ ################################################################################