From ad09ba0dccca95077e145f46c36d88d63a2d0fa3 Mon Sep 17 00:00:00 2001 From: Donatien Garnier Date: Wed, 16 May 2018 13:54:25 +0100 Subject: [PATCH] Fix handling of security escalation in on_connection_complete() --- features/FEATURE_BLE/source/generic/GenericGap.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/features/FEATURE_BLE/source/generic/GenericGap.cpp b/features/FEATURE_BLE/source/generic/GenericGap.cpp index faa78eb4d3..12bcd14c48 100644 --- a/features/FEATURE_BLE/source/generic/GenericGap.cpp +++ b/features/FEATURE_BLE/source/generic/GenericGap.cpp @@ -1235,11 +1235,12 @@ void GenericGap::on_connection_complete(const pal::GapConnectionCompleteEvent& e // Now starts pairing or authentication procedures if required if(needs_pairing) { SecurityManager &sm = createBLEInstance()->getSecurityManager(); - sm.requestPairing(e.connection_handle); + // Request authentication to start pairing procedure + sm.requestAuthentication(e.connection_handle); } else if(needs_authentication) { - SecurityManager &sm = createBLEInstance()->getSecurityManager(); - sm.requestAuthentication(e.connection_handle); + // TODO: GAP Authentication != Security Manager authentication + // Needs to be implemented } } else { // for now notify user that the connection failled by issuing a timeout