mirror of https://github.com/ARMmbed/mbed-os.git
				
				
				
			Apply suggestions from code review
Commit the reviewer suggestions Co-authored-by: Lingkai Dong <lingkai.dong@arm.com>pull/13335/head
							parent
							
								
									947d2d75b9
								
							
						
					
					
						commit
						a4c1071c5b
					
				| 
						 | 
					@ -12,7 +12,6 @@ set(unittest-includes ${unittest-includes}
 | 
				
			||||||
  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
					  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
				
			||||||
  ../drivers
 | 
					  ../drivers
 | 
				
			||||||
  ../hal
 | 
					  ../hal
 | 
				
			||||||
  ../features/cellular
 | 
					 | 
				
			||||||
)
 | 
					)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
# Source files
 | 
					# Source files
 | 
				
			||||||
| 
						 | 
					@ -60,4 +59,3 @@ set(unittest-test-flags
 | 
				
			||||||
  -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
 | 
					  -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
 | 
				
			||||||
  -DMBED_CONF_CELLULAR_USE_SMS=1
 | 
					  -DMBED_CONF_CELLULAR_USE_SMS=1
 | 
				
			||||||
)
 | 
					)
 | 
				
			||||||
 | 
					 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}
 | 
				
			||||||
  ../connectivity/cellular/include/cellular/framework/common
 | 
					  ../connectivity/cellular/include/cellular/framework/common
 | 
				
			||||||
  ../connectivity/cellular/include/cellular/framework/AT
 | 
					  ../connectivity/cellular/include/cellular/framework/AT
 | 
				
			||||||
  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
					  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
				
			||||||
  ../features/cellular
 | 
					 | 
				
			||||||
)
 | 
					)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
# Source files
 | 
					# Source files
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}
 | 
				
			||||||
  ../connectivity/cellular/include/cellular/framework/common
 | 
					  ../connectivity/cellular/include/cellular/framework/common
 | 
				
			||||||
  ../connectivity/cellular/include/cellular/framework/AT
 | 
					  ../connectivity/cellular/include/cellular/framework/AT
 | 
				
			||||||
  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
					  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
				
			||||||
  ../features/cellular
 | 
					 | 
				
			||||||
)
 | 
					)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
# Source files
 | 
					# Source files
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}
 | 
				
			||||||
  ../connectivity/cellular/include/cellular/framework/common
 | 
					  ../connectivity/cellular/include/cellular/framework/common
 | 
				
			||||||
  ../connectivity/cellular/include/cellular/framework/AT
 | 
					  ../connectivity/cellular/include/cellular/framework/AT
 | 
				
			||||||
  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
					  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
				
			||||||
  ../features/cellular
 | 
					 | 
				
			||||||
)
 | 
					)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
# Source files
 | 
					# Source files
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}
 | 
				
			||||||
  ../connectivity/cellular/include/cellular/framework/common
 | 
					  ../connectivity/cellular/include/cellular/framework/common
 | 
				
			||||||
  ../connectivity/cellular/include/cellular/framework/AT
 | 
					  ../connectivity/cellular/include/cellular/framework/AT
 | 
				
			||||||
  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
					  ../features/frameworks/mbed-client-randlib/mbed-client-randlib
 | 
				
			||||||
  ../features/cellular
 | 
					 | 
				
			||||||
)
 | 
					)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
# Source files
 | 
					# Source files
 | 
				
			||||||
| 
						 | 
					@ -51,4 +50,3 @@ set(unittest-test-flags
 | 
				
			||||||
  -DDEVICE_INTERRUPTIN=1
 | 
					  -DDEVICE_INTERRUPTIN=1
 | 
				
			||||||
  -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
 | 
					  -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
 | 
				
			||||||
)
 | 
					)
 | 
				
			||||||
 | 
					 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -48,4 +48,3 @@ set(unittest-test-flags
 | 
				
			||||||
  -DDEVICE_SERIAL=1
 | 
					  -DDEVICE_SERIAL=1
 | 
				
			||||||
  -DDEVICE_INTERRUPTIN=1
 | 
					  -DDEVICE_INTERRUPTIN=1
 | 
				
			||||||
)
 | 
					)
 | 
				
			||||||
 | 
					 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -5,7 +5,6 @@
 | 
				
			||||||
 | 
					
 | 
				
			||||||
# Add test specific include paths
 | 
					# Add test specific include paths
 | 
				
			||||||
set(unittest-includes ${unittest-includes}
 | 
					set(unittest-includes ${unittest-includes}
 | 
				
			||||||
  ../features/cellular
 | 
					 | 
				
			||||||
)
 | 
					)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
set(unittest-sources
 | 
					set(unittest-sources
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in New Issue