ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

NSAPI - Don't send trailing garbage in DNS queries 

Observed during investigation of
https://github.com/ARMmbed/mbed-os/issues/4246 - DNS queries sent
the entire buffer, not just the bit filled in.

Inefficient, especially for 6LoWPAN, and a security hole - the trailing
data could be previously-used heap.
pull/4274/head
Kevin Bracey 2017-05-05 11:33:14 +03:00
parent 8543279901
commit 984e87d8e9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
features/netsocket/nsapi_dns.cpp
View File

@ -227,7 +227,7 @@ static nsapi_size_or_error_t nsapi_dns_query_multiple(NetworkStack *stack, const
uint8_t *question = packet;
dns_append_question(&question, host, version);
err = socket.sendto(SocketAddress(dns_servers[i], 53), packet, DNS_BUFFER_SIZE);
err = socket.sendto(SocketAddress(dns_servers[i], 53), packet, question - packet);
// send may fail for various reasons, including wrong address type - move on
if (err < 0) {
continue;