ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

SerialBase.h|cpp [-Wreorder] compiler warning fix 

This fixes:

```
[Warning] SerialBase.h@351,22: 'mbed::SerialBase::_flow2' will be initialized after [-Wreorder]
[Warning] SerialBase.h@343,22:   'bool mbed::SerialBase::_rx_enabled' [-Wreorder]
[Warning] SerialBase.cpp@26,1:   when initialized here [-Wreorder]

```

by using C++11 style initializer for SerialBase

Kudos to Kevin Bracey, as her his suggestion - we can drop the initializer
list if we just set the values directly in the SerialBase.h. No need to
worry about the "right order" after that.
pull/11839/head
Janne Kiiskila 2019-11-07 17:19:57 +02:00
parent 0d26be4af2
commit 916b91f13e
2 changed files with 11 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/SerialBase.h
View File

@ -329,26 +329,26 @@ protected:
#if DEVICE_SERIAL_ASYNCH
CThunk<SerialBase> _thunk_irq;
DMAUsage _tx_usage;
DMAUsage _rx_usage;
DMAUsage _tx_usage = DMA_USAGE_NEVER;
DMAUsage _rx_usage = DMA_USAGE_NEVER;
event_callback_t _tx_callback;
event_callback_t _rx_callback;
bool _tx_asynch_set;
bool _rx_asynch_set;
bool _tx_asynch_set = false;
bool _rx_asynch_set = false;
#endif
serial_t _serial;
serial_t _serial {};
Callback<void()> _irq[IrqCnt];
int _baud;
bool _rx_enabled;
bool _tx_enabled;
bool _rx_enabled = true;
bool _tx_enabled = true;
const PinName _tx_pin;
const PinName _rx_pin;
#if DEVICE_SERIAL_FC
Flow _flow_type;
PinName _flow1;
PinName _flow2;
Flow _flow_type = Disabled;
PinName _flow1 = NC;
PinName _flow2 = NC;
#endif
#endif

13
drivers/source/SerialBase.cpp
View File

@ -25,20 +25,9 @@ namespace mbed {
SerialBase::SerialBase(PinName tx, PinName rx, int baud) :
#if DEVICE_SERIAL_ASYNCH
_thunk_irq(this), _tx_usage(DMA_USAGE_NEVER),
_rx_usage(DMA_USAGE_NEVER), _tx_callback(NULL),
_rx_callback(NULL), _tx_asynch_set(false),
_rx_asynch_set(false),
_thunk_irq(this),
#endif
_serial(),
_baud(baud),
#if DEVICE_SERIAL_FC
_flow_type(Disabled),
_flow1(NC),
_flow2(NC),
#endif
_rx_enabled(true),
_tx_enabled(true),
_tx_pin(tx),
_rx_pin(rx)
{