ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Make _unacknowledged_ticks uint32_t to prevent overflow

pull/13867/head
Marc Emmers 2020-11-05 15:26:44 +01:00
parent cdc2d45e05
commit 8b7e7ee8f6
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
platform/include/platform/internal/SysTimer.h
View File

@ -191,7 +191,7 @@ public:
*/ */
std::chrono::duration<int, period> unacknowledged_ticks() const std::chrono::duration<int, period> unacknowledged_ticks() const
{ {
return std::chrono::duration<int, period>(core_util_atomic_load_u8(&_unacknowledged_ticks)); return std::chrono::duration<int, period>(core_util_atomic_load_u32(&_unacknowledged_ticks));
} }
/** Get the current tick count /** Get the current tick count
@ -248,7 +248,7 @@ protected:
const highres_time_point _epoch; const highres_time_point _epoch;
highres_time_point _time; highres_time_point _time;
uint64_t _tick; uint64_t _tick;
uint8_t _unacknowledged_ticks; uint32_t _unacknowledged_ticks;
bool _wake_time_set; bool _wake_time_set;
bool _wake_time_passed; bool _wake_time_passed;
bool _wake_early; bool _wake_early;

13
platform/source/SysTimer.cpp
View File

@ -191,10 +191,15 @@ void SysTimer<Period, IRQ>::acknowledge_tick()
{ {
// Try to avoid missed ticks if OS's IRQ level is not keeping // Try to avoid missed ticks if OS's IRQ level is not keeping
// up with our handler. // up with our handler.
// 8-bit counter to save space, and also make sure it we don't // This value should not get large during normal operation.
// try TOO hard to resync if something goes really awry - // However, when interrupts are not handled for a while
// resync will reset if the count hits 256. // (e.g. by debug halt or large critical sections) this
if (core_util_atomic_decr_u8(&_unacknowledged_ticks, 1) > 0) { // number will get large very quickly. All these un-
// acknowledged ticks need to be processed because otherwise
// the OS timing will be off. Processing may take a while.
// For more info see: https://github.com/ARMmbed/mbed-os/issues/13801
if (core_util_atomic_decr_u32(&_unacknowledged_ticks, 1) > 0) {
_set_irq_pending(); _set_irq_pending();
} }
} }