review comments addressed

pull/10666/head
paul-szczepanek-arm 2019-04-01 15:49:03 +01:00 committed by Martin Kojtal
parent 7894a9321d
commit 87f5e1f057
6 changed files with 10 additions and 14 deletions

View File

@ -5,6 +5,11 @@
"help": "Handle VS HCI commands. Valid values are 0 (ignore) and 1 (handle).",
"value": 0,
"macro_name": "LHCI_ENABLE_VS"
},
"uart-hci": {
"help": "Does the board have a UART HCI. Valid values are 0 and 1 (must provide UART through PAL).",
"value": 0,
"macro_name": "CHCI_TR_UART"
}
}
}

View File

@ -69,7 +69,7 @@ uint16_t FakeChciTrWrite(uint8_t prot, uint8_t controller_type, uint16_t len, ui
break;
}
return controllerToHostWrite(prot, hci_type, len, pData);
return ControllerToHostWrite(prot, hci_type, len, pData);
}
#ifdef __cplusplus

View File

@ -30,13 +30,13 @@ extern "C" {
* @param pData Data to be sent.
* @return Number of bytes processed.
*/
uint16_t controllerToHostWrite(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *pData);
uint16_t ControllerToHostWrite(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *pData);
/**
* Send bytes from host to controller.
*
* @param prot Protocol, must be CHCI_TR_PROT_BLE.
* @param type HCI type, HCI_ACL_TYPE or HCI_CMD_TYPE.
* @param hci_type HCI type, HCI_ACL_TYPE or HCI_CMD_TYPE.
* @param len Buffer length.
* @param pData Data to be sent.
* @return Number of bytes processed.
@ -47,7 +47,7 @@ uint16_t FakeChciTrRead(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *p
* Send bytes from controller to host.
*
* @param prot Protocol, must be CHCI_TR_PROT_BLE.
* @param type Controller type, CHCI_TR_TYPE_DATA or CHCI_TR_TYPE_EVT.
* @param controller_type Controller type, CHCI_TR_TYPE_DATA or CHCI_TR_TYPE_EVT.
* @param len Buffer length.
* @param pData Data to be sent.
* @return Number of bytes processed.

View File

@ -227,8 +227,6 @@ ble::vendor::cordio::buf_pool_desc_t NRFCordioHCIDriver::get_buffer_pool_descrip
return buf_pool_desc_t(buffer, pool_desc);
}
void PlatformLoadBdAddress(uint8_t *pDevAddr);
void NRFCordioHCIDriver::do_initialize()
{
if(_is_init) {

View File

@ -56,7 +56,7 @@ extern "C" void chciDrvInit(void)
}
// Callback from Cordio stack
extern "C" uint16_t controllerToHostWrite(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *pData)
extern "C" uint16_t ControllerToHostWrite(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *pData)
{
WSF_ASSERT(prot == CHCI_TR_PROT_BLE);

View File

@ -1,12 +1,5 @@
{
"name": "cordio-nordic-ll",
"config": {
"uart-hci": {
"help": "Does the board have a UART HCI. Valid values are 0 and 1 (must provide UART through PAL).",
"value": 0,
"macro_name": "CHCI_TR_UART"
}
},
"macros": [
"INIT_BROADCASTER",
"INIT_OBSERVER",