diff --git a/libraries/USBDevice/USBMSD/USBMSD.cpp b/libraries/USBDevice/USBMSD/USBMSD.cpp index f2b6e3d791..ee5ad24733 100644 --- a/libraries/USBDevice/USBMSD/USBMSD.cpp +++ b/libraries/USBDevice/USBMSD/USBMSD.cpp @@ -135,10 +135,10 @@ bool USBMSD::connect(bool blocking) { } void USBMSD::disconnect() { + USBDevice::disconnect(); //De-allocate MSD page size: free(page); page = NULL; - USBDevice::disconnect(); } void USBMSD::reset() { diff --git a/libraries/USBDevice/USBSerial/CircBuffer.h b/libraries/USBDevice/USBSerial/CircBuffer.h index 78d5eecc6c..ea46bdfe6f 100644 --- a/libraries/USBDevice/USBSerial/CircBuffer.h +++ b/libraries/USBDevice/USBSerial/CircBuffer.h @@ -19,20 +19,10 @@ #ifndef CIRCBUFFER_H #define CIRCBUFFER_H -template +template class CircBuffer { public: - CircBuffer(int length) { - write = 0; - read = 0; - size = length + 1; - buf = (T *)malloc(size * sizeof(T)); - }; - - ~CircBuffer() { - free(buf); - } - + CircBuffer():write(0), read(0){} bool isFull() { return ((write + 1) % size == read); }; @@ -66,8 +56,8 @@ public: private: volatile uint16_t write; volatile uint16_t read; - uint16_t size; - T * buf; + static const int size = Size+1; //a modern optimizer should be able to remove this so it uses no ram. + T buf[Size]; }; #endif diff --git a/libraries/USBDevice/USBSerial/USBSerial.h b/libraries/USBDevice/USBSerial/USBSerial.h index e83aea6b18..164cf9bc7d 100644 --- a/libraries/USBDevice/USBSerial/USBSerial.h +++ b/libraries/USBDevice/USBSerial/USBSerial.h @@ -56,7 +56,7 @@ public: * @param connect_blocking define if the connection must be blocked if USB not plugged in * */ - USBSerial(uint16_t vendor_id = 0x1f00, uint16_t product_id = 0x2012, uint16_t product_release = 0x0001, bool connect_blocking = true): USBCDC(vendor_id, product_id, product_release, connect_blocking), buf(128){ + USBSerial(uint16_t vendor_id = 0x1f00, uint16_t product_id = 0x2012, uint16_t product_release = 0x0001, bool connect_blocking = true): USBCDC(vendor_id, product_id, product_release, connect_blocking){ settingsChangedCallback = 0; }; @@ -154,7 +154,7 @@ protected: private: FunctionPointer rx; - CircBuffer buf; + CircBuffer buf; void (*settingsChangedCallback)(int baud, int bits, int parity, int stop); };