ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Changed suggested things 

Removed context check from do_user_authentication.
pull/7228/head
Yoshihiro TSUBOI 2018-06-11 15:20:15 +09:00 committed by adbridge
parent b3ebb5229a
commit 7bc411eedb
3 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
features/cellular/framework/AT/AT_CellularNetwork.cpp
View File

@ -437,11 +437,6 @@ void AT_CellularNetwork::ppp_status_cb(nsapi_event_t event, intptr_t parameter)
nsapi_error_t AT_CellularNetwork::do_user_authentication() nsapi_error_t AT_CellularNetwork::do_user_authentication()
{ {
// try to find or create context with suitable stack
if (!get_context()) {
return NSAPI_ERROR_NO_CONNECTION;
}
// if user has defined user name and password we need to call CGAUTH before activating or modifying context // if user has defined user name and password we need to call CGAUTH before activating or modifying context
if (_pwd && _uname) { if (_pwd && _uname) {
_at.cmd_start("AT+CGAUTH="); _at.cmd_start("AT+CGAUTH=");

2
features/cellular/framework/AT/AT_CellularNetwork.h
View File

@ -154,6 +154,7 @@ private:
void free_credentials(); void free_credentials();
nsapi_error_t open_data_channel(); nsapi_error_t open_data_channel();
bool get_context();
bool set_new_context(int cid); bool set_new_context(int cid);
nsapi_error_t delete_current_context(); nsapi_error_t delete_current_context();
@ -179,7 +180,6 @@ protected:
int _cell_id; int _cell_id;
nsapi_connection_status_t _connect_status; nsapi_connection_status_t _connect_status;
virtual nsapi_error_t do_user_authentication(); virtual nsapi_error_t do_user_authentication();
bool get_context();
bool _new_context_set; bool _new_context_set;
bool _is_context_active; bool _is_context_active;
RegistrationStatus _reg_status; RegistrationStatus _reg_status;

5
features/cellular/framework/targets/QUECTEL/UG96/QUECTEL_UG96_CellularNetwork.cpp
View File

@ -45,11 +45,6 @@ nsapi_error_t QUECTEL_UG96_CellularNetwork::set_access_technology_impl(RadioAcce
nsapi_error_t QUECTEL_UG96_CellularNetwork::do_user_authentication() nsapi_error_t QUECTEL_UG96_CellularNetwork::do_user_authentication()
{ {
// try to find or create context with suitable stack
if (!get_context()) {
return NSAPI_ERROR_NO_CONNECTION;
}
if (_pwd && _uname) { if (_pwd && _uname) {
_at.cmd_start("AT+QICSGP="); _at.cmd_start("AT+QICSGP=");
_at.write_int(_cid); _at.write_int(_cid);