From 7a81783285bee9b911b6772a6b5e56bb2ff9189c Mon Sep 17 00:00:00 2001 From: George Psimenos Date: Tue, 12 Jan 2021 14:54:00 +0000 Subject: [PATCH] Remove const suffix --- .../source/MbedTester.cpp | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/features/frameworks/COMPONENT_FPGA_CI_TEST_SHIELD/source/MbedTester.cpp b/features/frameworks/COMPONENT_FPGA_CI_TEST_SHIELD/source/MbedTester.cpp index 0b706cdd56..b570c25918 100644 --- a/features/frameworks/COMPONENT_FPGA_CI_TEST_SHIELD/source/MbedTester.cpp +++ b/features/frameworks/COMPONENT_FPGA_CI_TEST_SHIELD/source/MbedTester.cpp @@ -29,12 +29,11 @@ namespace { const auto physical_pins = 128; const auto logical_pins = 8; - const auto firmware_size_const = 2192012; const auto firmware_region_size = 0x220000; const auto firmware_header_size = 0x10000; const auto flash_sector_size = 0x1000; const auto length_size = 0x4; - const auto crc_size_const = 0x4; + const auto fixed_crc_size = 0x4; const auto flash_spi_freq_hz = 2000000; const auto analog_count = 4; @@ -694,10 +693,10 @@ bool MbedTester::firmware_dump(mbed::FileHandle *dest, mbed::Callback firmware_region_size - length_size - crc_size_const) { - data_size = firmware_region_size - length_size - crc_size_const; + if (data_size > firmware_region_size - length_size - fixed_crc_size) { + data_size = firmware_region_size - length_size - fixed_crc_size; } - const uint32_t firmware_size = data_size + length_size + crc_size_const; + const uint32_t firmware_size = data_size + length_size + fixed_crc_size; // Dump firmware while (offset < firmware_size) { @@ -809,7 +808,7 @@ bool MbedTester::firmware_update(mbed::FileHandle *src, mbed::Callback file_size - crc_size_const) { + if (offset + program_size > file_size - fixed_crc_size) { // Overlap with the CRC field - for (uint32_t i = 0; i < crc_size_const; i++) { - uint32_t byte_offset = file_size - crc_size_const + i; + for (uint32_t i = 0; i < fixed_crc_size; i++) { + uint32_t byte_offset = file_size - fixed_crc_size + i; if ((byte_offset >= offset) && (byte_offset < offset + program_size)) { uint32_t buf_pos = byte_offset - offset; stored_crc |= buf[buf_pos] << (i * 8);