From 77e7720cb0f152161ce30dd0f2d2c648bb966768 Mon Sep 17 00:00:00 2001
From: Jerome Coutant <jerome.coutant@st.com>
Date: Tue, 20 Jul 2021 16:15:21 +0200
Subject: [PATCH] pinvalidate.py script: add SPI and I2C alias check

Goal is to follow
hal/include/hal/PinNameAliases.h
---
 hal/tests/pinvalidate/pinvalidate.py | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/hal/tests/pinvalidate/pinvalidate.py b/hal/tests/pinvalidate/pinvalidate.py
index 0a9e697932..c1452c13a5 100755
--- a/hal/tests/pinvalidate/pinvalidate.py
+++ b/hal/tests/pinvalidate/pinvalidate.py
@@ -440,6 +440,22 @@ def legacy_assignment_check(pin_name_content):
         invalid_items.append({"key": key, "val": val, "message": message})
     return invalid_items
 
+
+def legacy_alias_check(pin_name_content):
+    invalid_items = []
+    legacy_assignments = dict(
+        re.findall(
+            r"^\s*((?:SPI|I2C)_\w*)\s*=\s*([a-zA-Z0-9_]+)",
+            pin_name_content,
+            re.MULTILINE,
+        )
+    )
+    for key, val in legacy_assignments.items():
+        message = "legacy assignment; SPI_xxx and I2C_xxx must be #define'd"
+        invalid_items.append({"key": key, "val": val, "message": message})
+    return invalid_items
+
+
 def legacy_uart_check(pin_name_dict):
     invalid_items = []
     if "CONSOLE_TX" not in pin_name_dict or "CONSOLE_RX" not in pin_name_dict:
@@ -662,6 +678,12 @@ test_cases = [
         "case_function": legacy_assignment_check,
         "case_input": "content",
     },
+    {
+        "suite_name": "generic",
+        "case_name": "alias",
+        "case_function": legacy_alias_check,
+        "case_input": "content",
+    },
     {
         "suite_name": "generic",
         "case_name": "uart",