mirror of https://github.com/ARMmbed/mbed-os.git
Fixed RTC host test (0 sec scenario):
Boolean value used to calclate single RTC test PASS / FAIL was not used to calculate overall result. ==== ISSUE ==== The test suite treats the RTC test as successful, but test itself reports failures. Which one is correct – does it fail or does it pass? See below: HOST: Run test... MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 4.02 sec... FAIL MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 1.04 sec... FAIL MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 1.04 sec... FAIL MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 1.03 sec... FAIL MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 1.04 sec... FAIL {{success}} {{end}} Test::Output::Finish TargetTest::ARM_MPS2_M4::ARM::MBED_16::RTC [OK] in 30.37 of 40 sec ==== FIX ==== HOST: Run test... MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 0.04 sec... FAIL MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 1.04 sec... FAIL MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 1.04 sec... FAIL MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 1.04 sec... FAIL MBED: [0] [1970-01-01 00:00:00 AM] HOST: [0] [1970-01-01 00:00:00 AM] received time +0 sec after 1.04 sec... FAIL {{failure}} {{end}}pull/922/head
parent
c9e93d21e3
commit
7596acd726
|
@ -38,8 +38,9 @@ class RTCTest():
|
|||
sec = int(m.groups()[0])
|
||||
time_str = m.groups()[1]
|
||||
correct_time_str = strftime("%Y-%m-%d %H:%M:%S %p", gmtime(float(sec)))
|
||||
test_result = test_result and (time_str == correct_time_str)
|
||||
result_msg = "OK" if (time_str == correct_time_str and sec > 0 and sec > sec_prev) else "FAIL"
|
||||
single_result = time_str == correct_time_str and sec > 0 and sec > sec_prev
|
||||
test_result = test_result and single_result
|
||||
result_msg = "OK" if single_result else "FAIL"
|
||||
selftest.notify("HOST: [%s] [%s] received time %+d sec after %.2f sec... %s"% (sec, time_str, sec - sec_prev, delta, result_msg))
|
||||
sec_prev = sec
|
||||
else:
|
||||
|
|
Loading…
Reference in New Issue