ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add deprecation note to CAN attach 

attach members not using Callback class are not compatible with
const and volatile types. This was missed when callback was initially
added
pull/4111/head
Sam Grove 2017-04-12 10:25:40 -05:00
parent 26b9a1f6a3
commit 710af8f09b
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/CAN.h
View File

@ -224,11 +224,17 @@ public:
* @param obj pointer to the object to call the member function on * @param obj pointer to the object to call the member function on
* @param method pointer to the member function to be called * @param method pointer to the member function to be called
* @param type Which CAN interrupt to attach the member function to (CAN::RxIrq for message received, TxIrq for transmitted or aborted, EwIrq for error warning, DoIrq for data overrun, WuIrq for wake-up, EpIrq for error passive, AlIrq for arbitration lost, BeIrq for bus error) * @param type Which CAN interrupt to attach the member function to (CAN::RxIrq for message received, TxIrq for transmitted or aborted, EwIrq for error warning, DoIrq for data overrun, WuIrq for wake-up, EpIrq for error passive, AlIrq for arbitration lost, BeIrq for bus error)
* @deprecated
* The attach function does not support cv-qualifiers. Replaced by
* attach(callback(obj, method), type).
*/ */
template<typename T> template<typename T>
MBED_DEPRECATED_SINCE("mbed-os-5.1",
"The attach function does not support cv-qualifiers. Replaced by "
"attach(callback(obj, method), type).")
void attach(T* obj, void (T::*method)(), IrqType type=RxIrq) { void attach(T* obj, void (T::*method)(), IrqType type=RxIrq) {
// Underlying call thread safe // Underlying call thread safe
attach(Callback<void()>(obj, method), type); attach(callback(obj, method), type);
} }
/** Attach a member function to call whenever a CAN frame received interrupt /** Attach a member function to call whenever a CAN frame received interrupt
@ -237,11 +243,17 @@ public:
* @param obj pointer to the object to call the member function on * @param obj pointer to the object to call the member function on
* @param method pointer to the member function to be called * @param method pointer to the member function to be called
* @param type Which CAN interrupt to attach the member function to (CAN::RxIrq for message received, TxIrq for transmitted or aborted, EwIrq for error warning, DoIrq for data overrun, WuIrq for wake-up, EpIrq for error passive, AlIrq for arbitration lost, BeIrq for bus error) * @param type Which CAN interrupt to attach the member function to (CAN::RxIrq for message received, TxIrq for transmitted or aborted, EwIrq for error warning, DoIrq for data overrun, WuIrq for wake-up, EpIrq for error passive, AlIrq for arbitration lost, BeIrq for bus error)
* @deprecated
* The attach function does not support cv-qualifiers. Replaced by
* attach(callback(obj, method), type).
*/ */
template<typename T> template<typename T>
MBED_DEPRECATED_SINCE("mbed-os-5.1",
"The attach function does not support cv-qualifiers. Replaced by "
"attach(callback(obj, method), type).")
void attach(T* obj, void (*method)(T*), IrqType type=RxIrq) { void attach(T* obj, void (*method)(T*), IrqType type=RxIrq) {
// Underlying call thread safe // Underlying call thread safe
attach(Callback<void()>(obj, method), type); attach(callback(obj, method), type);
} }
static void _irq_handler(uint32_t id, CanIrqType type); static void _irq_handler(uint32_t id, CanIrqType type);